]> git.bitcoin.ninja Git - rust-lightning/blob - lightning/src/ln/functional_test_utils.rs
82c5d2901e2c15ddedf1ca35548492207f392858
[rust-lightning] / lightning / src / ln / functional_test_utils.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 //! A bunch of useful utilities for building networks of nodes and exchanging messages between
11 //! nodes for functional tests.
12
13 use chain::{BestBlock, Confirm, Listen, Watch};
14 use chain::channelmonitor::ChannelMonitor;
15 use chain::transaction::OutPoint;
16 use ln::{PaymentPreimage, PaymentHash, PaymentSecret};
17 use ln::channelmanager::{ChainParameters, ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentSendFailure};
18 use routing::router::{Route, get_route};
19 use routing::network_graph::{NetGraphMsgHandler, NetworkGraph};
20 use ln::features::{InitFeatures, InvoiceFeatures};
21 use ln::msgs;
22 use ln::msgs::{ChannelMessageHandler,RoutingMessageHandler};
23 use util::enforcing_trait_impls::EnforcingSigner;
24 use util::test_utils;
25 use util::test_utils::TestChainMonitor;
26 use util::events::{Event, MessageSendEvent, MessageSendEventsProvider, PaymentPurpose};
27 use util::errors::APIError;
28 use util::config::UserConfig;
29 use util::ser::{ReadableArgs, Writeable, Readable};
30
31 use bitcoin::blockdata::block::{Block, BlockHeader};
32 use bitcoin::blockdata::constants::genesis_block;
33 use bitcoin::blockdata::transaction::{Transaction, TxOut};
34 use bitcoin::network::constants::Network;
35
36 use bitcoin::hashes::sha256::Hash as Sha256;
37 use bitcoin::hashes::Hash;
38 use bitcoin::hash_types::BlockHash;
39
40 use bitcoin::secp256k1::key::PublicKey;
41
42 use io;
43 use prelude::*;
44 use core::cell::RefCell;
45 use std::rc::Rc;
46 use sync::{Arc, Mutex};
47 use core::mem;
48
49 pub const CHAN_CONFIRM_DEPTH: u32 = 10;
50
51 /// Mine the given transaction in the next block and then mine CHAN_CONFIRM_DEPTH - 1 blocks on
52 /// top, giving the given transaction CHAN_CONFIRM_DEPTH confirmations.
53 pub fn confirm_transaction<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction) {
54         confirm_transaction_at(node, tx, node.best_block_info().1 + 1);
55         connect_blocks(node, CHAN_CONFIRM_DEPTH - 1);
56 }
57 /// Mine a signle block containing the given transaction
58 pub fn mine_transaction<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction) {
59         let height = node.best_block_info().1 + 1;
60         confirm_transaction_at(node, tx, height);
61 }
62 /// Mine the given transaction at the given height, mining blocks as required to build to that
63 /// height
64 pub fn confirm_transaction_at<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction, conf_height: u32) {
65         let first_connect_height = node.best_block_info().1 + 1;
66         assert!(first_connect_height <= conf_height);
67         if conf_height > first_connect_height {
68                 connect_blocks(node, conf_height - first_connect_height);
69         }
70         let mut block = Block {
71                 header: BlockHeader { version: 0x20000000, prev_blockhash: node.best_block_hash(), merkle_root: Default::default(), time: conf_height, bits: 42, nonce: 42 },
72                 txdata: Vec::new(),
73         };
74         for _ in 0..*node.network_chan_count.borrow() { // Make sure we don't end up with channels at the same short id by offsetting by chan_count
75                 block.txdata.push(Transaction { version: 0, lock_time: 0, input: Vec::new(), output: Vec::new() });
76         }
77         block.txdata.push(tx.clone());
78         connect_block(node, &block);
79 }
80
81 /// The possible ways we may notify a ChannelManager of a new block
82 #[derive(Clone, Copy, PartialEq)]
83 pub enum ConnectStyle {
84         /// Calls best_block_updated first, detecting transactions in the block only after receiving the
85         /// header and height information.
86         BestBlockFirst,
87         /// The same as BestBlockFirst, however when we have multiple blocks to connect, we only
88         /// make a single best_block_updated call.
89         BestBlockFirstSkippingBlocks,
90         /// Calls transactions_confirmed first, detecting transactions in the block before updating the
91         /// header and height information.
92         TransactionsFirst,
93         /// The same as TransactionsFirst, however when we have multiple blocks to connect, we only
94         /// make a single best_block_updated call.
95         TransactionsFirstSkippingBlocks,
96         /// Provides the full block via the chain::Listen interface. In the current code this is
97         /// equivalent to TransactionsFirst with some additional assertions.
98         FullBlockViaListen,
99 }
100
101 pub fn connect_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, depth: u32) -> BlockHash {
102         let skip_intermediaries = match *node.connect_style.borrow() {
103                 ConnectStyle::BestBlockFirstSkippingBlocks|ConnectStyle::TransactionsFirstSkippingBlocks => true,
104                 _ => false,
105         };
106
107         let height = node.best_block_info().1 + 1;
108         let mut block = Block {
109                 header: BlockHeader { version: 0x2000000, prev_blockhash: node.best_block_hash(), merkle_root: Default::default(), time: height, bits: 42, nonce: 42 },
110                 txdata: vec![],
111         };
112         assert!(depth >= 1);
113         for i in 1..depth {
114                 do_connect_block(node, &block, skip_intermediaries);
115                 block = Block {
116                         header: BlockHeader { version: 0x20000000, prev_blockhash: block.header.block_hash(), merkle_root: Default::default(), time: height + i, bits: 42, nonce: 42 },
117                         txdata: vec![],
118                 };
119         }
120         connect_block(node, &block);
121         block.header.block_hash()
122 }
123
124 pub fn connect_block<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, block: &Block) {
125         do_connect_block(node, block, false);
126 }
127
128 fn do_connect_block<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, block: &Block, skip_intermediaries: bool) {
129         let height = node.best_block_info().1 + 1;
130         if !skip_intermediaries {
131                 let txdata: Vec<_> = block.txdata.iter().enumerate().collect();
132                 match *node.connect_style.borrow() {
133                         ConnectStyle::BestBlockFirst|ConnectStyle::BestBlockFirstSkippingBlocks => {
134                                 node.chain_monitor.chain_monitor.best_block_updated(&block.header, height);
135                                 node.chain_monitor.chain_monitor.transactions_confirmed(&block.header, &txdata, height);
136                                 node.node.best_block_updated(&block.header, height);
137                                 node.node.transactions_confirmed(&block.header, &txdata, height);
138                         },
139                         ConnectStyle::TransactionsFirst|ConnectStyle::TransactionsFirstSkippingBlocks => {
140                                 node.chain_monitor.chain_monitor.transactions_confirmed(&block.header, &txdata, height);
141                                 node.chain_monitor.chain_monitor.best_block_updated(&block.header, height);
142                                 node.node.transactions_confirmed(&block.header, &txdata, height);
143                                 node.node.best_block_updated(&block.header, height);
144                         },
145                         ConnectStyle::FullBlockViaListen => {
146                                 node.chain_monitor.chain_monitor.block_connected(&block, height);
147                                 node.node.block_connected(&block, height);
148                         }
149                 }
150         }
151         node.node.test_process_background_events();
152         node.blocks.lock().unwrap().push((block.header, height));
153 }
154
155 pub fn disconnect_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, count: u32) {
156         for i in 0..count {
157                 let orig_header = node.blocks.lock().unwrap().pop().unwrap();
158                 assert!(orig_header.1 > 0); // Cannot disconnect genesis
159                 let prev_header = node.blocks.lock().unwrap().last().unwrap().clone();
160
161                 match *node.connect_style.borrow() {
162                         ConnectStyle::FullBlockViaListen => {
163                                 node.chain_monitor.chain_monitor.block_disconnected(&orig_header.0, orig_header.1);
164                                 Listen::block_disconnected(node.node, &orig_header.0, orig_header.1);
165                         },
166                         ConnectStyle::BestBlockFirstSkippingBlocks|ConnectStyle::TransactionsFirstSkippingBlocks => {
167                                 if i == count - 1 {
168                                         node.chain_monitor.chain_monitor.best_block_updated(&prev_header.0, prev_header.1);
169                                         node.node.best_block_updated(&prev_header.0, prev_header.1);
170                                 }
171                         },
172                         _ => {
173                                 node.chain_monitor.chain_monitor.best_block_updated(&prev_header.0, prev_header.1);
174                                 node.node.best_block_updated(&prev_header.0, prev_header.1);
175                         },
176                 }
177         }
178 }
179
180 pub fn disconnect_all_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>) {
181         let count = node.blocks.lock().unwrap().len() as u32 - 1;
182         disconnect_blocks(node, count);
183 }
184
185 pub struct TestChanMonCfg {
186         pub tx_broadcaster: test_utils::TestBroadcaster,
187         pub fee_estimator: test_utils::TestFeeEstimator,
188         pub chain_source: test_utils::TestChainSource,
189         pub persister: test_utils::TestPersister,
190         pub logger: test_utils::TestLogger,
191         pub keys_manager: test_utils::TestKeysInterface,
192 }
193
194 pub struct NodeCfg<'a> {
195         pub chain_source: &'a test_utils::TestChainSource,
196         pub tx_broadcaster: &'a test_utils::TestBroadcaster,
197         pub fee_estimator: &'a test_utils::TestFeeEstimator,
198         pub chain_monitor: test_utils::TestChainMonitor<'a>,
199         pub keys_manager: &'a test_utils::TestKeysInterface,
200         pub logger: &'a test_utils::TestLogger,
201         pub node_seed: [u8; 32],
202         pub features: InitFeatures,
203 }
204
205 pub struct Node<'a, 'b: 'a, 'c: 'b> {
206         pub chain_source: &'c test_utils::TestChainSource,
207         pub tx_broadcaster: &'c test_utils::TestBroadcaster,
208         pub chain_monitor: &'b test_utils::TestChainMonitor<'c>,
209         pub keys_manager: &'b test_utils::TestKeysInterface,
210         pub node: &'a ChannelManager<EnforcingSigner, &'b TestChainMonitor<'c>, &'c test_utils::TestBroadcaster, &'b test_utils::TestKeysInterface, &'c test_utils::TestFeeEstimator, &'c test_utils::TestLogger>,
211         pub net_graph_msg_handler: NetGraphMsgHandler<&'c test_utils::TestChainSource, &'c test_utils::TestLogger>,
212         pub node_seed: [u8; 32],
213         pub network_payment_count: Rc<RefCell<u8>>,
214         pub network_chan_count: Rc<RefCell<u32>>,
215         pub logger: &'c test_utils::TestLogger,
216         pub blocks: Arc<Mutex<Vec<(BlockHeader, u32)>>>,
217         pub connect_style: Rc<RefCell<ConnectStyle>>,
218 }
219 impl<'a, 'b, 'c> Node<'a, 'b, 'c> {
220         pub fn best_block_hash(&self) -> BlockHash {
221                 self.blocks.lock().unwrap().last().unwrap().0.block_hash()
222         }
223         pub fn best_block_info(&self) -> (BlockHash, u32) {
224                 self.blocks.lock().unwrap().last().map(|(a, b)| (a.block_hash(), *b)).unwrap()
225         }
226         pub fn get_block_header(&self, height: u32) -> BlockHeader {
227                 self.blocks.lock().unwrap()[height as usize].0
228         }
229 }
230
231 impl<'a, 'b, 'c> Drop for Node<'a, 'b, 'c> {
232         fn drop(&mut self) {
233                 if !::std::thread::panicking() {
234                         // Check that we processed all pending events
235                         assert!(self.node.get_and_clear_pending_msg_events().is_empty());
236                         assert!(self.node.get_and_clear_pending_events().is_empty());
237                         assert!(self.chain_monitor.added_monitors.lock().unwrap().is_empty());
238
239                         // Check that if we serialize the Router, we can deserialize it again.
240                         {
241                                 let mut w = test_utils::TestVecWriter(Vec::new());
242                                 let network_graph_ser = self.net_graph_msg_handler.network_graph.read().unwrap();
243                                 network_graph_ser.write(&mut w).unwrap();
244                                 let network_graph_deser = <NetworkGraph>::read(&mut io::Cursor::new(&w.0)).unwrap();
245                                 assert!(network_graph_deser == *self.net_graph_msg_handler.network_graph.read().unwrap());
246                                 let net_graph_msg_handler = NetGraphMsgHandler::from_net_graph(
247                                         Some(self.chain_source), self.logger, network_graph_deser
248                                 );
249                                 let mut chan_progress = 0;
250                                 loop {
251                                         let orig_announcements = self.net_graph_msg_handler.get_next_channel_announcements(chan_progress, 255);
252                                         let deserialized_announcements = net_graph_msg_handler.get_next_channel_announcements(chan_progress, 255);
253                                         assert!(orig_announcements == deserialized_announcements);
254                                         chan_progress = match orig_announcements.last() {
255                                                 Some(announcement) => announcement.0.contents.short_channel_id + 1,
256                                                 None => break,
257                                         };
258                                 }
259                                 let mut node_progress = None;
260                                 loop {
261                                         let orig_announcements = self.net_graph_msg_handler.get_next_node_announcements(node_progress.as_ref(), 255);
262                                         let deserialized_announcements = net_graph_msg_handler.get_next_node_announcements(node_progress.as_ref(), 255);
263                                         assert!(orig_announcements == deserialized_announcements);
264                                         node_progress = match orig_announcements.last() {
265                                                 Some(announcement) => Some(announcement.contents.node_id),
266                                                 None => break,
267                                         };
268                                 }
269                         }
270
271                         // Check that if we serialize and then deserialize all our channel monitors we get the
272                         // same set of outputs to watch for on chain as we have now. Note that if we write
273                         // tests that fully close channels and remove the monitors at some point this may break.
274                         let feeest = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
275                         let mut deserialized_monitors = Vec::new();
276                         {
277                                 let old_monitors = self.chain_monitor.chain_monitor.monitors.read().unwrap();
278                                 for (_, old_monitor) in old_monitors.iter() {
279                                         let mut w = test_utils::TestVecWriter(Vec::new());
280                                         old_monitor.write(&mut w).unwrap();
281                                         let (_, deserialized_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
282                                                 &mut io::Cursor::new(&w.0), self.keys_manager).unwrap();
283                                         deserialized_monitors.push(deserialized_monitor);
284                                 }
285                         }
286
287                         // Before using all the new monitors to check the watch outpoints, use the full set of
288                         // them to ensure we can write and reload our ChannelManager.
289                         {
290                                 let mut channel_monitors = HashMap::new();
291                                 for monitor in deserialized_monitors.iter_mut() {
292                                         channel_monitors.insert(monitor.get_funding_txo().0, monitor);
293                                 }
294
295                                 let mut w = test_utils::TestVecWriter(Vec::new());
296                                 self.node.write(&mut w).unwrap();
297                                 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut io::Cursor::new(w.0), ChannelManagerReadArgs {
298                                         default_config: *self.node.get_current_default_configuration(),
299                                         keys_manager: self.keys_manager,
300                                         fee_estimator: &test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) },
301                                         chain_monitor: self.chain_monitor,
302                                         tx_broadcaster: &test_utils::TestBroadcaster {
303                                                 txn_broadcasted: Mutex::new(self.tx_broadcaster.txn_broadcasted.lock().unwrap().clone()),
304                                                 blocks: Arc::new(Mutex::new(self.tx_broadcaster.blocks.lock().unwrap().clone())),
305                                         },
306                                         logger: &self.logger,
307                                         channel_monitors,
308                                 }).unwrap();
309                         }
310
311                         let persister = test_utils::TestPersister::new();
312                         let broadcaster = test_utils::TestBroadcaster {
313                                 txn_broadcasted: Mutex::new(self.tx_broadcaster.txn_broadcasted.lock().unwrap().clone()),
314                                 blocks: Arc::new(Mutex::new(self.tx_broadcaster.blocks.lock().unwrap().clone())),
315                         };
316                         let chain_source = test_utils::TestChainSource::new(Network::Testnet);
317                         let chain_monitor = test_utils::TestChainMonitor::new(Some(&chain_source), &broadcaster, &self.logger, &feeest, &persister, &self.keys_manager);
318                         for deserialized_monitor in deserialized_monitors.drain(..) {
319                                 if let Err(_) = chain_monitor.watch_channel(deserialized_monitor.get_funding_txo().0, deserialized_monitor) {
320                                         panic!();
321                                 }
322                         }
323                         assert_eq!(*chain_source.watched_txn.lock().unwrap(), *self.chain_source.watched_txn.lock().unwrap());
324                         assert_eq!(*chain_source.watched_outputs.lock().unwrap(), *self.chain_source.watched_outputs.lock().unwrap());
325                 }
326         }
327 }
328
329 pub fn create_chan_between_nodes<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
330         create_chan_between_nodes_with_value(node_a, node_b, 100000, 10001, a_flags, b_flags)
331 }
332
333 pub fn create_chan_between_nodes_with_value<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
334         let (funding_locked, channel_id, tx) = create_chan_between_nodes_with_value_a(node_a, node_b, channel_value, push_msat, a_flags, b_flags);
335         let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(node_a, node_b, &funding_locked);
336         (announcement, as_update, bs_update, channel_id, tx)
337 }
338
339 macro_rules! get_revoke_commit_msgs {
340         ($node: expr, $node_id: expr) => {
341                 {
342                         let events = $node.node.get_and_clear_pending_msg_events();
343                         assert_eq!(events.len(), 2);
344                         (match events[0] {
345                                 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
346                                         assert_eq!(*node_id, $node_id);
347                                         (*msg).clone()
348                                 },
349                                 _ => panic!("Unexpected event"),
350                         }, match events[1] {
351                                 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
352                                         assert_eq!(*node_id, $node_id);
353                                         assert!(updates.update_add_htlcs.is_empty());
354                                         assert!(updates.update_fulfill_htlcs.is_empty());
355                                         assert!(updates.update_fail_htlcs.is_empty());
356                                         assert!(updates.update_fail_malformed_htlcs.is_empty());
357                                         assert!(updates.update_fee.is_none());
358                                         updates.commitment_signed.clone()
359                                 },
360                                 _ => panic!("Unexpected event"),
361                         })
362                 }
363         }
364 }
365
366 /// Get an specific event message from the pending events queue.
367 #[macro_export]
368 macro_rules! get_event_msg {
369         ($node: expr, $event_type: path, $node_id: expr) => {
370                 {
371                         let events = $node.node.get_and_clear_pending_msg_events();
372                         assert_eq!(events.len(), 1);
373                         match events[0] {
374                                 $event_type { ref node_id, ref msg } => {
375                                         assert_eq!(*node_id, $node_id);
376                                         (*msg).clone()
377                                 },
378                                 _ => panic!("Unexpected event"),
379                         }
380                 }
381         }
382 }
383
384 /// Get a specific event from the pending events queue.
385 #[macro_export]
386 macro_rules! get_event {
387         ($node: expr, $event_type: path) => {
388                 {
389                         let mut events = $node.node.get_and_clear_pending_events();
390                         assert_eq!(events.len(), 1);
391                         let ev = events.pop().unwrap();
392                         match ev {
393                                 $event_type { .. } => {
394                                         ev
395                                 },
396                                 _ => panic!("Unexpected event"),
397                         }
398                 }
399         }
400 }
401
402 #[cfg(test)]
403 macro_rules! get_htlc_update_msgs {
404         ($node: expr, $node_id: expr) => {
405                 {
406                         let events = $node.node.get_and_clear_pending_msg_events();
407                         assert_eq!(events.len(), 1);
408                         match events[0] {
409                                 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
410                                         assert_eq!(*node_id, $node_id);
411                                         (*updates).clone()
412                                 },
413                                 _ => panic!("Unexpected event"),
414                         }
415                 }
416         }
417 }
418
419 #[cfg(test)]
420 macro_rules! get_channel_ref {
421         ($node: expr, $lock: ident, $channel_id: expr) => {
422                 {
423                         $lock = $node.node.channel_state.lock().unwrap();
424                         $lock.by_id.get_mut(&$channel_id).unwrap()
425                 }
426         }
427 }
428
429 #[cfg(test)]
430 macro_rules! get_feerate {
431         ($node: expr, $channel_id: expr) => {
432                 {
433                         let mut lock;
434                         let chan = get_channel_ref!($node, lock, $channel_id);
435                         chan.get_feerate()
436                 }
437         }
438 }
439
440 /// Returns any local commitment transactions for the channel.
441 #[macro_export]
442 macro_rules! get_local_commitment_txn {
443         ($node: expr, $channel_id: expr) => {
444                 {
445                         let monitors = $node.chain_monitor.chain_monitor.monitors.read().unwrap();
446                         let mut commitment_txn = None;
447                         for (funding_txo, monitor) in monitors.iter() {
448                                 if funding_txo.to_channel_id() == $channel_id {
449                                         commitment_txn = Some(monitor.unsafe_get_latest_holder_commitment_txn(&$node.logger));
450                                         break;
451                                 }
452                         }
453                         commitment_txn.unwrap()
454                 }
455         }
456 }
457
458 /// Check the error from attempting a payment.
459 #[macro_export]
460 macro_rules! unwrap_send_err {
461         ($res: expr, $all_failed: expr, $type: pat, $check: expr) => {
462                 match &$res {
463                         &Err(PaymentSendFailure::AllFailedRetrySafe(ref fails)) if $all_failed => {
464                                 assert_eq!(fails.len(), 1);
465                                 match fails[0] {
466                                         $type => { $check },
467                                         _ => panic!(),
468                                 }
469                         },
470                         &Err(PaymentSendFailure::PartialFailure(ref fails)) if !$all_failed => {
471                                 assert_eq!(fails.len(), 1);
472                                 match fails[0] {
473                                         Err($type) => { $check },
474                                         _ => panic!(),
475                                 }
476                         },
477                         _ => panic!(),
478                 }
479         }
480 }
481
482 /// Check whether N channel monitor(s) have been added.
483 #[macro_export]
484 macro_rules! check_added_monitors {
485         ($node: expr, $count: expr) => {
486                 {
487                         let mut added_monitors = $node.chain_monitor.added_monitors.lock().unwrap();
488                         assert_eq!(added_monitors.len(), $count);
489                         added_monitors.clear();
490                 }
491         }
492 }
493
494 pub fn create_funding_transaction<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, expected_chan_value: u64, expected_user_chan_id: u64) -> ([u8; 32], Transaction, OutPoint) {
495         let chan_id = *node.network_chan_count.borrow();
496
497         let events = node.node.get_and_clear_pending_events();
498         assert_eq!(events.len(), 1);
499         match events[0] {
500                 Event::FundingGenerationReady { ref temporary_channel_id, ref channel_value_satoshis, ref output_script, user_channel_id } => {
501                         assert_eq!(*channel_value_satoshis, expected_chan_value);
502                         assert_eq!(user_channel_id, expected_user_chan_id);
503
504                         let tx = Transaction { version: chan_id as i32, lock_time: 0, input: Vec::new(), output: vec![TxOut {
505                                 value: *channel_value_satoshis, script_pubkey: output_script.clone(),
506                         }]};
507                         let funding_outpoint = OutPoint { txid: tx.txid(), index: 0 };
508                         (*temporary_channel_id, tx, funding_outpoint)
509                 },
510                 _ => panic!("Unexpected event"),
511         }
512 }
513
514 pub fn create_chan_between_nodes_with_value_init<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> Transaction {
515         node_a.node.create_channel(node_b.node.get_our_node_id(), channel_value, push_msat, 42, None).unwrap();
516         node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), a_flags, &get_event_msg!(node_a, MessageSendEvent::SendOpenChannel, node_b.node.get_our_node_id()));
517         node_a.node.handle_accept_channel(&node_b.node.get_our_node_id(), b_flags, &get_event_msg!(node_b, MessageSendEvent::SendAcceptChannel, node_a.node.get_our_node_id()));
518
519         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(node_a, channel_value, 42);
520
521         node_a.node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
522         check_added_monitors!(node_a, 0);
523
524         node_b.node.handle_funding_created(&node_a.node.get_our_node_id(), &get_event_msg!(node_a, MessageSendEvent::SendFundingCreated, node_b.node.get_our_node_id()));
525         {
526                 let mut added_monitors = node_b.chain_monitor.added_monitors.lock().unwrap();
527                 assert_eq!(added_monitors.len(), 1);
528                 assert_eq!(added_monitors[0].0, funding_output);
529                 added_monitors.clear();
530         }
531
532         node_a.node.handle_funding_signed(&node_b.node.get_our_node_id(), &get_event_msg!(node_b, MessageSendEvent::SendFundingSigned, node_a.node.get_our_node_id()));
533         {
534                 let mut added_monitors = node_a.chain_monitor.added_monitors.lock().unwrap();
535                 assert_eq!(added_monitors.len(), 1);
536                 assert_eq!(added_monitors[0].0, funding_output);
537                 added_monitors.clear();
538         }
539
540         let events_4 = node_a.node.get_and_clear_pending_events();
541         assert_eq!(events_4.len(), 0);
542
543         assert_eq!(node_a.tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
544         assert_eq!(node_a.tx_broadcaster.txn_broadcasted.lock().unwrap()[0], tx);
545         node_a.tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
546
547         tx
548 }
549
550 pub fn create_chan_between_nodes_with_value_confirm_first<'a, 'b, 'c, 'd>(node_recv: &'a Node<'b, 'c, 'c>, node_conf: &'a Node<'b, 'c, 'd>, tx: &Transaction, conf_height: u32) {
551         confirm_transaction_at(node_conf, tx, conf_height);
552         connect_blocks(node_conf, CHAN_CONFIRM_DEPTH - 1);
553         node_recv.node.handle_funding_locked(&node_conf.node.get_our_node_id(), &get_event_msg!(node_conf, MessageSendEvent::SendFundingLocked, node_recv.node.get_our_node_id()));
554 }
555
556 pub fn create_chan_between_nodes_with_value_confirm_second<'a, 'b, 'c>(node_recv: &Node<'a, 'b, 'c>, node_conf: &Node<'a, 'b, 'c>) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32]) {
557         let channel_id;
558         let events_6 = node_conf.node.get_and_clear_pending_msg_events();
559         assert_eq!(events_6.len(), 2);
560         ((match events_6[0] {
561                 MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
562                         channel_id = msg.channel_id.clone();
563                         assert_eq!(*node_id, node_recv.node.get_our_node_id());
564                         msg.clone()
565                 },
566                 _ => panic!("Unexpected event"),
567         }, match events_6[1] {
568                 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
569                         assert_eq!(*node_id, node_recv.node.get_our_node_id());
570                         msg.clone()
571                 },
572                 _ => panic!("Unexpected event"),
573         }), channel_id)
574 }
575
576 pub fn create_chan_between_nodes_with_value_confirm<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, tx: &Transaction) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32]) {
577         let conf_height = core::cmp::max(node_a.best_block_info().1 + 1, node_b.best_block_info().1 + 1);
578         create_chan_between_nodes_with_value_confirm_first(node_a, node_b, tx, conf_height);
579         confirm_transaction_at(node_a, tx, conf_height);
580         connect_blocks(node_a, CHAN_CONFIRM_DEPTH - 1);
581         create_chan_between_nodes_with_value_confirm_second(node_b, node_a)
582 }
583
584 pub fn create_chan_between_nodes_with_value_a<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32], Transaction) {
585         let tx = create_chan_between_nodes_with_value_init(node_a, node_b, channel_value, push_msat, a_flags, b_flags);
586         let (msgs, chan_id) = create_chan_between_nodes_with_value_confirm(node_a, node_b, &tx);
587         (msgs, chan_id, tx)
588 }
589
590 pub fn create_chan_between_nodes_with_value_b<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, as_funding_msgs: &(msgs::FundingLocked, msgs::AnnouncementSignatures)) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate) {
591         node_b.node.handle_funding_locked(&node_a.node.get_our_node_id(), &as_funding_msgs.0);
592         let bs_announcement_sigs = get_event_msg!(node_b, MessageSendEvent::SendAnnouncementSignatures, node_a.node.get_our_node_id());
593         node_b.node.handle_announcement_signatures(&node_a.node.get_our_node_id(), &as_funding_msgs.1);
594
595         let events_7 = node_b.node.get_and_clear_pending_msg_events();
596         assert_eq!(events_7.len(), 1);
597         let (announcement, bs_update) = match events_7[0] {
598                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
599                         (msg, update_msg)
600                 },
601                 _ => panic!("Unexpected event"),
602         };
603
604         node_a.node.handle_announcement_signatures(&node_b.node.get_our_node_id(), &bs_announcement_sigs);
605         let events_8 = node_a.node.get_and_clear_pending_msg_events();
606         assert_eq!(events_8.len(), 1);
607         let as_update = match events_8[0] {
608                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
609                         assert!(*announcement == *msg);
610                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
611                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
612                         update_msg
613                 },
614                 _ => panic!("Unexpected event"),
615         };
616
617         *node_a.network_chan_count.borrow_mut() += 1;
618
619         ((*announcement).clone(), (*as_update).clone(), (*bs_update).clone())
620 }
621
622 pub fn create_announced_chan_between_nodes<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
623         create_announced_chan_between_nodes_with_value(nodes, a, b, 100000, 10001, a_flags, b_flags)
624 }
625
626 pub fn create_announced_chan_between_nodes_with_value<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
627         let chan_announcement = create_chan_between_nodes_with_value(&nodes[a], &nodes[b], channel_value, push_msat, a_flags, b_flags);
628         update_nodes_with_chan_announce(nodes, a, b, &chan_announcement.0, &chan_announcement.1, &chan_announcement.2);
629         (chan_announcement.1, chan_announcement.2, chan_announcement.3, chan_announcement.4)
630 }
631
632 pub fn update_nodes_with_chan_announce<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, ann: &msgs::ChannelAnnouncement, upd_1: &msgs::ChannelUpdate, upd_2: &msgs::ChannelUpdate) {
633         nodes[a].node.broadcast_node_announcement([0, 0, 0], [0; 32], Vec::new());
634         let a_events = nodes[a].node.get_and_clear_pending_msg_events();
635         assert!(a_events.len() >= 2);
636
637         // ann should be re-generated by broadcast_node_announcement - check that we have it.
638         let mut found_ann_1 = false;
639         for event in a_events.iter() {
640                 match event {
641                         MessageSendEvent::BroadcastChannelAnnouncement { ref msg, .. } => {
642                                 if msg == ann { found_ann_1 = true; }
643                         },
644                         MessageSendEvent::BroadcastNodeAnnouncement { .. } => {},
645                         _ => panic!("Unexpected event {:?}", event),
646                 }
647         }
648         assert!(found_ann_1);
649
650         let a_node_announcement = match a_events.last().unwrap() {
651                 MessageSendEvent::BroadcastNodeAnnouncement { ref msg } => {
652                         (*msg).clone()
653                 },
654                 _ => panic!("Unexpected event"),
655         };
656
657         nodes[b].node.broadcast_node_announcement([1, 1, 1], [1; 32], Vec::new());
658         let b_events = nodes[b].node.get_and_clear_pending_msg_events();
659         assert!(b_events.len() >= 2);
660
661         // ann should be re-generated by broadcast_node_announcement - check that we have it.
662         let mut found_ann_2 = false;
663         for event in b_events.iter() {
664                 match event {
665                         MessageSendEvent::BroadcastChannelAnnouncement { ref msg, .. } => {
666                                 if msg == ann { found_ann_2 = true; }
667                         },
668                         MessageSendEvent::BroadcastNodeAnnouncement { .. } => {},
669                         _ => panic!("Unexpected event"),
670                 }
671         }
672         assert!(found_ann_2);
673
674         let b_node_announcement = match b_events.last().unwrap() {
675                 MessageSendEvent::BroadcastNodeAnnouncement { ref msg } => {
676                         (*msg).clone()
677                 },
678                 _ => panic!("Unexpected event"),
679         };
680
681         for node in nodes {
682                 assert!(node.net_graph_msg_handler.handle_channel_announcement(ann).unwrap());
683                 node.net_graph_msg_handler.handle_channel_update(upd_1).unwrap();
684                 node.net_graph_msg_handler.handle_channel_update(upd_2).unwrap();
685                 node.net_graph_msg_handler.handle_node_announcement(&a_node_announcement).unwrap();
686                 node.net_graph_msg_handler.handle_node_announcement(&b_node_announcement).unwrap();
687         }
688 }
689
690 macro_rules! check_spends {
691         ($tx: expr, $($spends_txn: expr),*) => {
692                 {
693                         let get_output = |out_point: &bitcoin::blockdata::transaction::OutPoint| {
694                                 $(
695                                         if out_point.txid == $spends_txn.txid() {
696                                                 return $spends_txn.output.get(out_point.vout as usize).cloned()
697                                         }
698                                 )*
699                                 None
700                         };
701                         let mut total_value_in = 0;
702                         for input in $tx.input.iter() {
703                                 total_value_in += get_output(&input.previous_output).unwrap().value;
704                         }
705                         let mut total_value_out = 0;
706                         for output in $tx.output.iter() {
707                                 total_value_out += output.value;
708                         }
709                         let min_fee = ($tx.get_weight() as u64 + 3) / 4; // One sat per vbyte (ie per weight/4, rounded up)
710                         // Input amount - output amount = fee, so check that out + min_fee is smaller than input
711                         assert!(total_value_out + min_fee <= total_value_in);
712                         $tx.verify(get_output).unwrap();
713                 }
714         }
715 }
716
717 macro_rules! get_closing_signed_broadcast {
718         ($node: expr, $dest_pubkey: expr) => {
719                 {
720                         let events = $node.get_and_clear_pending_msg_events();
721                         assert!(events.len() == 1 || events.len() == 2);
722                         (match events[events.len() - 1] {
723                                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
724                                         assert_eq!(msg.contents.flags & 2, 2);
725                                         msg.clone()
726                                 },
727                                 _ => panic!("Unexpected event"),
728                         }, if events.len() == 2 {
729                                 match events[0] {
730                                         MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
731                                                 assert_eq!(*node_id, $dest_pubkey);
732                                                 Some(msg.clone())
733                                         },
734                                         _ => panic!("Unexpected event"),
735                                 }
736                         } else { None })
737                 }
738         }
739 }
740
741 /// Check that a channel's closing channel update has been broadcasted, and optionally
742 /// check whether an error message event has occurred.
743 #[macro_export]
744 macro_rules! check_closed_broadcast {
745         ($node: expr, $with_error_msg: expr) => {{
746                 let events = $node.node.get_and_clear_pending_msg_events();
747                 assert_eq!(events.len(), if $with_error_msg { 2 } else { 1 });
748                 match events[0] {
749                         MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
750                                 assert_eq!(msg.contents.flags & 2, 2);
751                         },
752                         _ => panic!("Unexpected event"),
753                 }
754                 if $with_error_msg {
755                         match events[1] {
756                                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id: _ } => {
757                                         // TODO: Check node_id
758                                         Some(msg.clone())
759                                 },
760                                 _ => panic!("Unexpected event"),
761                         }
762                 } else { None }
763         }}
764 }
765
766 pub fn close_channel<'a, 'b, 'c>(outbound_node: &Node<'a, 'b, 'c>, inbound_node: &Node<'a, 'b, 'c>, channel_id: &[u8; 32], funding_tx: Transaction, close_inbound_first: bool) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, Transaction) {
767         let (node_a, broadcaster_a, struct_a) = if close_inbound_first { (&inbound_node.node, &inbound_node.tx_broadcaster, inbound_node) } else { (&outbound_node.node, &outbound_node.tx_broadcaster, outbound_node) };
768         let (node_b, broadcaster_b, struct_b) = if close_inbound_first { (&outbound_node.node, &outbound_node.tx_broadcaster, outbound_node) } else { (&inbound_node.node, &inbound_node.tx_broadcaster, inbound_node) };
769         let (tx_a, tx_b);
770
771         node_a.close_channel(channel_id).unwrap();
772         node_b.handle_shutdown(&node_a.get_our_node_id(), &InitFeatures::known(), &get_event_msg!(struct_a, MessageSendEvent::SendShutdown, node_b.get_our_node_id()));
773
774         let events_1 = node_b.get_and_clear_pending_msg_events();
775         assert!(events_1.len() >= 1);
776         let shutdown_b = match events_1[0] {
777                 MessageSendEvent::SendShutdown { ref node_id, ref msg } => {
778                         assert_eq!(node_id, &node_a.get_our_node_id());
779                         msg.clone()
780                 },
781                 _ => panic!("Unexpected event"),
782         };
783
784         let closing_signed_b = if !close_inbound_first {
785                 assert_eq!(events_1.len(), 1);
786                 None
787         } else {
788                 Some(match events_1[1] {
789                         MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
790                                 assert_eq!(node_id, &node_a.get_our_node_id());
791                                 msg.clone()
792                         },
793                         _ => panic!("Unexpected event"),
794                 })
795         };
796
797         node_a.handle_shutdown(&node_b.get_our_node_id(), &InitFeatures::known(), &shutdown_b);
798         let (as_update, bs_update) = if close_inbound_first {
799                 assert!(node_a.get_and_clear_pending_msg_events().is_empty());
800                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &closing_signed_b.unwrap());
801
802                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &get_event_msg!(struct_a, MessageSendEvent::SendClosingSigned, node_b.get_our_node_id()));
803                 assert_eq!(broadcaster_b.txn_broadcasted.lock().unwrap().len(), 1);
804                 tx_b = broadcaster_b.txn_broadcasted.lock().unwrap().remove(0);
805                 let (bs_update, closing_signed_b) = get_closing_signed_broadcast!(node_b, node_a.get_our_node_id());
806
807                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &closing_signed_b.unwrap());
808                 let (as_update, none_a) = get_closing_signed_broadcast!(node_a, node_b.get_our_node_id());
809                 assert!(none_a.is_none());
810                 assert_eq!(broadcaster_a.txn_broadcasted.lock().unwrap().len(), 1);
811                 tx_a = broadcaster_a.txn_broadcasted.lock().unwrap().remove(0);
812                 (as_update, bs_update)
813         } else {
814                 let closing_signed_a = get_event_msg!(struct_a, MessageSendEvent::SendClosingSigned, node_b.get_our_node_id());
815
816                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &closing_signed_a);
817                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &get_event_msg!(struct_b, MessageSendEvent::SendClosingSigned, node_a.get_our_node_id()));
818
819                 assert_eq!(broadcaster_a.txn_broadcasted.lock().unwrap().len(), 1);
820                 tx_a = broadcaster_a.txn_broadcasted.lock().unwrap().remove(0);
821                 let (as_update, closing_signed_a) = get_closing_signed_broadcast!(node_a, node_b.get_our_node_id());
822
823                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &closing_signed_a.unwrap());
824                 let (bs_update, none_b) = get_closing_signed_broadcast!(node_b, node_a.get_our_node_id());
825                 assert!(none_b.is_none());
826                 assert_eq!(broadcaster_b.txn_broadcasted.lock().unwrap().len(), 1);
827                 tx_b = broadcaster_b.txn_broadcasted.lock().unwrap().remove(0);
828                 (as_update, bs_update)
829         };
830         assert_eq!(tx_a, tx_b);
831         check_spends!(tx_a, funding_tx);
832
833         (as_update, bs_update, tx_a)
834 }
835
836 pub struct SendEvent {
837         pub node_id: PublicKey,
838         pub msgs: Vec<msgs::UpdateAddHTLC>,
839         pub commitment_msg: msgs::CommitmentSigned,
840 }
841 impl SendEvent {
842         pub fn from_commitment_update(node_id: PublicKey, updates: msgs::CommitmentUpdate) -> SendEvent {
843                 assert!(updates.update_fulfill_htlcs.is_empty());
844                 assert!(updates.update_fail_htlcs.is_empty());
845                 assert!(updates.update_fail_malformed_htlcs.is_empty());
846                 assert!(updates.update_fee.is_none());
847                 SendEvent { node_id: node_id, msgs: updates.update_add_htlcs, commitment_msg: updates.commitment_signed }
848         }
849
850         pub fn from_event(event: MessageSendEvent) -> SendEvent {
851                 match event {
852                         MessageSendEvent::UpdateHTLCs { node_id, updates } => SendEvent::from_commitment_update(node_id, updates),
853                         _ => panic!("Unexpected event type!"),
854                 }
855         }
856
857         pub fn from_node<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>) -> SendEvent {
858                 let mut events = node.node.get_and_clear_pending_msg_events();
859                 assert_eq!(events.len(), 1);
860                 SendEvent::from_event(events.pop().unwrap())
861         }
862 }
863
864 macro_rules! commitment_signed_dance {
865         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr, true /* skip last step */) => {
866                 {
867                         check_added_monitors!($node_a, 0);
868                         assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
869                         $node_a.node.handle_commitment_signed(&$node_b.node.get_our_node_id(), &$commitment_signed);
870                         check_added_monitors!($node_a, 1);
871                         commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, false);
872                 }
873         };
874         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, true /* return extra message */, true /* return last RAA */) => {
875                 {
876                         let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!($node_a, $node_b.node.get_our_node_id());
877                         check_added_monitors!($node_b, 0);
878                         assert!($node_b.node.get_and_clear_pending_msg_events().is_empty());
879                         $node_b.node.handle_revoke_and_ack(&$node_a.node.get_our_node_id(), &as_revoke_and_ack);
880                         assert!($node_b.node.get_and_clear_pending_msg_events().is_empty());
881                         check_added_monitors!($node_b, 1);
882                         $node_b.node.handle_commitment_signed(&$node_a.node.get_our_node_id(), &as_commitment_signed);
883                         let (bs_revoke_and_ack, extra_msg_option) = {
884                                 let events = $node_b.node.get_and_clear_pending_msg_events();
885                                 assert!(events.len() <= 2);
886                                 (match events[0] {
887                                         MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
888                                                 assert_eq!(*node_id, $node_a.node.get_our_node_id());
889                                                 (*msg).clone()
890                                         },
891                                         _ => panic!("Unexpected event"),
892                                 }, events.get(1).map(|e| e.clone()))
893                         };
894                         check_added_monitors!($node_b, 1);
895                         if $fail_backwards {
896                                 assert!($node_a.node.get_and_clear_pending_events().is_empty());
897                                 assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
898                         }
899                         (extra_msg_option, bs_revoke_and_ack)
900                 }
901         };
902         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr, true /* skip last step */, false /* return extra message */, true /* return last RAA */) => {
903                 {
904                         check_added_monitors!($node_a, 0);
905                         assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
906                         $node_a.node.handle_commitment_signed(&$node_b.node.get_our_node_id(), &$commitment_signed);
907                         check_added_monitors!($node_a, 1);
908                         let (extra_msg_option, bs_revoke_and_ack) = commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true, true);
909                         assert!(extra_msg_option.is_none());
910                         bs_revoke_and_ack
911                 }
912         };
913         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, true /* return extra message */) => {
914                 {
915                         let (extra_msg_option, bs_revoke_and_ack) = commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true, true);
916                         $node_a.node.handle_revoke_and_ack(&$node_b.node.get_our_node_id(), &bs_revoke_and_ack);
917                         check_added_monitors!($node_a, 1);
918                         extra_msg_option
919                 }
920         };
921         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, false /* no extra message */) => {
922                 {
923                         assert!(commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true).is_none());
924                 }
925         };
926         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr) => {
927                 {
928                         commitment_signed_dance!($node_a, $node_b, $commitment_signed, $fail_backwards, true);
929                         if $fail_backwards {
930                                 expect_pending_htlcs_forwardable!($node_a);
931                                 check_added_monitors!($node_a, 1);
932
933                                 let channel_state = $node_a.node.channel_state.lock().unwrap();
934                                 assert_eq!(channel_state.pending_msg_events.len(), 1);
935                                 if let MessageSendEvent::UpdateHTLCs { ref node_id, .. } = channel_state.pending_msg_events[0] {
936                                         assert_ne!(*node_id, $node_b.node.get_our_node_id());
937                                 } else { panic!("Unexpected event"); }
938                         } else {
939                                 assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
940                         }
941                 }
942         }
943 }
944
945 /// Get a payment preimage and hash.
946 #[macro_export]
947 macro_rules! get_payment_preimage_hash {
948         ($dest_node: expr) => {
949                 {
950                         let payment_preimage = PaymentPreimage([*$dest_node.network_payment_count.borrow(); 32]);
951                         *$dest_node.network_payment_count.borrow_mut() += 1;
952                         let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
953                         let payment_secret = $dest_node.node.create_inbound_payment_for_hash(payment_hash, None, 7200, 0).unwrap();
954                         (payment_preimage, payment_hash, payment_secret)
955                 }
956         }
957 }
958
959 #[cfg(test)]
960 macro_rules! get_route_and_payment_hash {
961         ($send_node: expr, $recv_node: expr, $recv_value: expr) => {{
962                 let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash!($recv_node);
963                 let net_graph_msg_handler = &$send_node.net_graph_msg_handler;
964                 let route = get_route(&$send_node.node.get_our_node_id(),
965                         &net_graph_msg_handler.network_graph.read().unwrap(),
966                         &$recv_node.node.get_our_node_id(), None, None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, $send_node.logger).unwrap();
967                 (route, payment_hash, payment_preimage, payment_secret)
968         }}
969 }
970
971 macro_rules! expect_pending_htlcs_forwardable_ignore {
972         ($node: expr) => {{
973                 let events = $node.node.get_and_clear_pending_events();
974                 assert_eq!(events.len(), 1);
975                 match events[0] {
976                         Event::PendingHTLCsForwardable { .. } => { },
977                         _ => panic!("Unexpected event"),
978                 };
979         }}
980 }
981
982 macro_rules! expect_pending_htlcs_forwardable {
983         ($node: expr) => {{
984                 expect_pending_htlcs_forwardable_ignore!($node);
985                 $node.node.process_pending_htlc_forwards();
986         }}
987 }
988
989 #[cfg(any(test, feature = "unstable"))]
990 macro_rules! expect_payment_received {
991         ($node: expr, $expected_payment_hash: expr, $expected_payment_secret: expr, $expected_recv_value: expr) => {
992                 let events = $node.node.get_and_clear_pending_events();
993                 assert_eq!(events.len(), 1);
994                 match events[0] {
995                         Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
996                                 assert_eq!($expected_payment_hash, *payment_hash);
997                                 assert_eq!($expected_recv_value, amt);
998                                 match purpose {
999                                         PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1000                                                 assert!(payment_preimage.is_none());
1001                                                 assert_eq!($expected_payment_secret, *payment_secret);
1002                                         },
1003                                         _ => {},
1004                                 }
1005                         },
1006                         _ => panic!("Unexpected event"),
1007                 }
1008         }
1009 }
1010
1011 macro_rules! expect_payment_sent {
1012         ($node: expr, $expected_payment_preimage: expr) => {
1013                 let events = $node.node.get_and_clear_pending_events();
1014                 assert_eq!(events.len(), 1);
1015                 match events[0] {
1016                         Event::PaymentSent { ref payment_preimage } => {
1017                                 assert_eq!($expected_payment_preimage, *payment_preimage);
1018                         },
1019                         _ => panic!("Unexpected event"),
1020                 }
1021         }
1022 }
1023
1024 macro_rules! expect_payment_forwarded {
1025         ($node: expr, $expected_fee: expr, $upstream_force_closed: expr) => {
1026                 let events = $node.node.get_and_clear_pending_events();
1027                 assert_eq!(events.len(), 1);
1028                 match events[0] {
1029                         Event::PaymentForwarded { fee_earned_msat, claim_from_onchain_tx } => {
1030                                 assert_eq!(fee_earned_msat, $expected_fee);
1031                                 assert_eq!(claim_from_onchain_tx, $upstream_force_closed);
1032                         },
1033                         _ => panic!("Unexpected event"),
1034                 }
1035         }
1036 }
1037
1038 #[cfg(test)]
1039 macro_rules! expect_payment_failure_chan_update {
1040         ($node: expr, $scid: expr, $chan_closed: expr) => {
1041                 let events = $node.node.get_and_clear_pending_msg_events();
1042                 assert_eq!(events.len(), 1);
1043                 match events[0] {
1044                         MessageSendEvent::PaymentFailureNetworkUpdate { ref update } => {
1045                                 match update {
1046                                         &HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg } if !$chan_closed => {
1047                                                 assert_eq!(msg.contents.short_channel_id, $scid);
1048                                                 assert_eq!(msg.contents.flags & 2, 0);
1049                                         },
1050                                         &HTLCFailChannelUpdate::ChannelClosed { short_channel_id, is_permanent } if $chan_closed => {
1051                                                 assert_eq!(short_channel_id, $scid);
1052                                                 assert!(is_permanent);
1053                                         },
1054                                         _ => panic!("Unexpected update type"),
1055                                 }
1056                         },
1057                         _ => panic!("Unexpected event"),
1058                 }
1059         }
1060 }
1061
1062 #[cfg(test)]
1063 macro_rules! expect_payment_failed {
1064         ($node: expr, $expected_payment_hash: expr, $rejected_by_dest: expr $(, $expected_error_code: expr, $expected_error_data: expr)*) => {
1065                 let events = $node.node.get_and_clear_pending_events();
1066                 assert_eq!(events.len(), 1);
1067                 match events[0] {
1068                         Event::PaymentFailed { ref payment_hash, rejected_by_dest, ref error_code, ref error_data } => {
1069                                 assert_eq!(*payment_hash, $expected_payment_hash, "unexpected payment_hash");
1070                                 assert_eq!(rejected_by_dest, $rejected_by_dest, "unexpected rejected_by_dest value");
1071                                 assert!(error_code.is_some(), "expected error_code.is_some() = true");
1072                                 assert!(error_data.is_some(), "expected error_data.is_some() = true");
1073                                 $(
1074                                         assert_eq!(error_code.unwrap(), $expected_error_code, "unexpected error code");
1075                                         assert_eq!(&error_data.as_ref().unwrap()[..], $expected_error_data, "unexpected error data");
1076                                 )*
1077                         },
1078                         _ => panic!("Unexpected event"),
1079                 }
1080         }
1081 }
1082
1083 pub fn send_along_route_with_secret<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, route: Route, expected_paths: &[&[&Node<'a, 'b, 'c>]], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: PaymentSecret) {
1084         origin_node.node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
1085         check_added_monitors!(origin_node, expected_paths.len());
1086         pass_along_route(origin_node, expected_paths, recv_value, our_payment_hash, our_payment_secret);
1087 }
1088
1089 pub fn pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_path: &[&Node<'a, 'b, 'c>], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: Option<PaymentSecret>, ev: MessageSendEvent, payment_received_expected: bool, expected_preimage: Option<PaymentPreimage>) {
1090         let mut payment_event = SendEvent::from_event(ev);
1091         let mut prev_node = origin_node;
1092
1093         for (idx, &node) in expected_path.iter().enumerate() {
1094                 assert_eq!(node.node.get_our_node_id(), payment_event.node_id);
1095
1096                 node.node.handle_update_add_htlc(&prev_node.node.get_our_node_id(), &payment_event.msgs[0]);
1097                 check_added_monitors!(node, 0);
1098                 commitment_signed_dance!(node, prev_node, payment_event.commitment_msg, false);
1099
1100                 expect_pending_htlcs_forwardable!(node);
1101
1102                 if idx == expected_path.len() - 1 {
1103                         let events_2 = node.node.get_and_clear_pending_events();
1104                         if payment_received_expected {
1105                                 assert_eq!(events_2.len(), 1);
1106                                 match events_2[0] {
1107                                         Event::PaymentReceived { ref payment_hash, ref purpose, amt} => {
1108                                                 assert_eq!(our_payment_hash, *payment_hash);
1109                                                 match &purpose {
1110                                                         PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1111                                                                 assert_eq!(expected_preimage, *payment_preimage);
1112                                                                 assert_eq!(our_payment_secret.unwrap(), *payment_secret);
1113                                                         },
1114                                                         PaymentPurpose::SpontaneousPayment(payment_preimage) => {
1115                                                                 assert_eq!(expected_preimage.unwrap(), *payment_preimage);
1116                                                                 assert!(our_payment_secret.is_none());
1117                                                         },
1118                                                 }
1119                                                 assert_eq!(amt, recv_value);
1120                                         },
1121                                         _ => panic!("Unexpected event"),
1122                                 }
1123                         } else {
1124                                 assert!(events_2.is_empty());
1125                         }
1126                 } else {
1127                         let mut events_2 = node.node.get_and_clear_pending_msg_events();
1128                         assert_eq!(events_2.len(), 1);
1129                         check_added_monitors!(node, 1);
1130                         payment_event = SendEvent::from_event(events_2.remove(0));
1131                         assert_eq!(payment_event.msgs.len(), 1);
1132                 }
1133
1134                 prev_node = node;
1135         }
1136 }
1137
1138 pub fn pass_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&[&Node<'a, 'b, 'c>]], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: PaymentSecret) {
1139         let mut events = origin_node.node.get_and_clear_pending_msg_events();
1140         assert_eq!(events.len(), expected_route.len());
1141         for (path_idx, (ev, expected_path)) in events.drain(..).zip(expected_route.iter()).enumerate() {
1142                 // Once we've gotten through all the HTLCs, the last one should result in a
1143                 // PaymentReceived (but each previous one should not!), .
1144                 let expect_payment = path_idx == expected_route.len() - 1;
1145                 pass_along_path(origin_node, expected_path, recv_value, our_payment_hash.clone(), Some(our_payment_secret), ev, expect_payment, None);
1146         }
1147 }
1148
1149 pub fn send_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, route: Route, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64) -> (PaymentPreimage, PaymentHash, PaymentSecret) {
1150         let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(expected_route.last().unwrap());
1151         send_along_route_with_secret(origin_node, route, &[expected_route], recv_value, our_payment_hash, our_payment_secret);
1152         (our_payment_preimage, our_payment_hash, our_payment_secret)
1153 }
1154
1155 pub fn claim_payment_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_paths: &[&[&Node<'a, 'b, 'c>]], skip_last: bool, our_payment_preimage: PaymentPreimage) {
1156         for path in expected_paths.iter() {
1157                 assert_eq!(path.last().unwrap().node.get_our_node_id(), expected_paths[0].last().unwrap().node.get_our_node_id());
1158         }
1159         assert!(expected_paths[0].last().unwrap().node.claim_funds(our_payment_preimage));
1160         check_added_monitors!(expected_paths[0].last().unwrap(), expected_paths.len());
1161
1162         macro_rules! msgs_from_ev {
1163                 ($ev: expr) => {
1164                         match $ev {
1165                                 &MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
1166                                         assert!(update_add_htlcs.is_empty());
1167                                         assert_eq!(update_fulfill_htlcs.len(), 1);
1168                                         assert!(update_fail_htlcs.is_empty());
1169                                         assert!(update_fail_malformed_htlcs.is_empty());
1170                                         assert!(update_fee.is_none());
1171                                         ((update_fulfill_htlcs[0].clone(), commitment_signed.clone()), node_id.clone())
1172                                 },
1173                                 _ => panic!("Unexpected event"),
1174                         }
1175                 }
1176         }
1177         let mut per_path_msgs: Vec<((msgs::UpdateFulfillHTLC, msgs::CommitmentSigned), PublicKey)> = Vec::with_capacity(expected_paths.len());
1178         let events = expected_paths[0].last().unwrap().node.get_and_clear_pending_msg_events();
1179         assert_eq!(events.len(), expected_paths.len());
1180         for ev in events.iter() {
1181                 per_path_msgs.push(msgs_from_ev!(ev));
1182         }
1183
1184         for (expected_route, (path_msgs, next_hop)) in expected_paths.iter().zip(per_path_msgs.drain(..)) {
1185                 let mut next_msgs = Some(path_msgs);
1186                 let mut expected_next_node = next_hop;
1187
1188                 macro_rules! last_update_fulfill_dance {
1189                         ($node: expr, $prev_node: expr) => {
1190                                 {
1191                                         $node.node.handle_update_fulfill_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1192                                         check_added_monitors!($node, 0);
1193                                         assert!($node.node.get_and_clear_pending_msg_events().is_empty());
1194                                         commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, false);
1195                                 }
1196                         }
1197                 }
1198                 macro_rules! mid_update_fulfill_dance {
1199                         ($node: expr, $prev_node: expr, $new_msgs: expr) => {
1200                                 {
1201                                         $node.node.handle_update_fulfill_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1202                                         let fee = $node.node.channel_state.lock().unwrap().by_id.get(&next_msgs.as_ref().unwrap().0.channel_id).unwrap().config.forwarding_fee_base_msat;
1203                                         expect_payment_forwarded!($node, Some(fee as u64), false);
1204                                         check_added_monitors!($node, 1);
1205                                         let new_next_msgs = if $new_msgs {
1206                                                 let events = $node.node.get_and_clear_pending_msg_events();
1207                                                 assert_eq!(events.len(), 1);
1208                                                 let (res, nexthop) = msgs_from_ev!(&events[0]);
1209                                                 expected_next_node = nexthop;
1210                                                 Some(res)
1211                                         } else {
1212                                                 assert!($node.node.get_and_clear_pending_msg_events().is_empty());
1213                                                 None
1214                                         };
1215                                         commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, false);
1216                                         next_msgs = new_next_msgs;
1217                                 }
1218                         }
1219                 }
1220
1221                 let mut prev_node = expected_route.last().unwrap();
1222                 for (idx, node) in expected_route.iter().rev().enumerate().skip(1) {
1223                         assert_eq!(expected_next_node, node.node.get_our_node_id());
1224                         let update_next_msgs = !skip_last || idx != expected_route.len() - 1;
1225                         if next_msgs.is_some() {
1226                                 mid_update_fulfill_dance!(node, prev_node, update_next_msgs);
1227                         } else {
1228                                 assert!(!update_next_msgs);
1229                                 assert!(node.node.get_and_clear_pending_msg_events().is_empty());
1230                         }
1231                         if !skip_last && idx == expected_route.len() - 1 {
1232                                 assert_eq!(expected_next_node, origin_node.node.get_our_node_id());
1233                         }
1234
1235                         prev_node = node;
1236                 }
1237
1238                 if !skip_last {
1239                         last_update_fulfill_dance!(origin_node, expected_route.first().unwrap());
1240                         expect_payment_sent!(origin_node, our_payment_preimage);
1241                 }
1242         }
1243 }
1244
1245 pub fn claim_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], our_payment_preimage: PaymentPreimage) {
1246         claim_payment_along_route(origin_node, &[expected_route], false, our_payment_preimage);
1247 }
1248
1249 pub const TEST_FINAL_CLTV: u32 = 70;
1250
1251 pub fn route_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64) -> (PaymentPreimage, PaymentHash, PaymentSecret) {
1252         let net_graph_msg_handler = &origin_node.net_graph_msg_handler;
1253         let route = get_route(&origin_node.node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
1254                 &expected_route.last().unwrap().node.get_our_node_id(), Some(InvoiceFeatures::known()),
1255                 Some(&origin_node.node.list_usable_channels().iter().collect::<Vec<_>>()), &[],
1256                 recv_value, TEST_FINAL_CLTV, origin_node.logger).unwrap();
1257         assert_eq!(route.paths.len(), 1);
1258         assert_eq!(route.paths[0].len(), expected_route.len());
1259         for (node, hop) in expected_route.iter().zip(route.paths[0].iter()) {
1260                 assert_eq!(hop.pubkey, node.node.get_our_node_id());
1261         }
1262
1263         send_along_route(origin_node, route, expected_route, recv_value)
1264 }
1265
1266 pub fn route_over_limit<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64)  {
1267         let net_graph_msg_handler = &origin_node.net_graph_msg_handler;
1268         let route = get_route(&origin_node.node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &expected_route.last().unwrap().node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), recv_value, TEST_FINAL_CLTV, origin_node.logger).unwrap();
1269         assert_eq!(route.paths.len(), 1);
1270         assert_eq!(route.paths[0].len(), expected_route.len());
1271         for (node, hop) in expected_route.iter().zip(route.paths[0].iter()) {
1272                 assert_eq!(hop.pubkey, node.node.get_our_node_id());
1273         }
1274
1275         let (_, our_payment_hash, our_payment_preimage) = get_payment_preimage_hash!(expected_route.last().unwrap());
1276         unwrap_send_err!(origin_node.node.send_payment(&route, our_payment_hash, &Some(our_payment_preimage)), true, APIError::ChannelUnavailable { ref err },
1277                 assert!(err.contains("Cannot send value that would put us over the max HTLC value in flight our peer will accept")));
1278 }
1279
1280 pub fn send_payment<'a, 'b, 'c>(origin: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64)  {
1281         let our_payment_preimage = route_payment(&origin, expected_route, recv_value).0;
1282         claim_payment(&origin, expected_route, our_payment_preimage);
1283 }
1284
1285 pub fn fail_payment_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], skip_last: bool, our_payment_hash: PaymentHash)  {
1286         assert!(expected_route.last().unwrap().node.fail_htlc_backwards(&our_payment_hash));
1287         expect_pending_htlcs_forwardable!(expected_route.last().unwrap());
1288         check_added_monitors!(expected_route.last().unwrap(), 1);
1289
1290         let mut next_msgs: Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned)> = None;
1291         macro_rules! update_fail_dance {
1292                 ($node: expr, $prev_node: expr, $last_node: expr) => {
1293                         {
1294                                 $node.node.handle_update_fail_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1295                                 commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, !$last_node);
1296                                 if skip_last && $last_node {
1297                                         expect_pending_htlcs_forwardable!($node);
1298                                 }
1299                         }
1300                 }
1301         }
1302
1303         let mut expected_next_node = expected_route.last().unwrap().node.get_our_node_id();
1304         let mut prev_node = expected_route.last().unwrap();
1305         for (idx, node) in expected_route.iter().rev().enumerate() {
1306                 assert_eq!(expected_next_node, node.node.get_our_node_id());
1307                 if next_msgs.is_some() {
1308                         // We may be the "last node" for the purpose of the commitment dance if we're
1309                         // skipping the last node (implying it is disconnected) and we're the
1310                         // second-to-last node!
1311                         update_fail_dance!(node, prev_node, skip_last && idx == expected_route.len() - 1);
1312                 }
1313
1314                 let events = node.node.get_and_clear_pending_msg_events();
1315                 if !skip_last || idx != expected_route.len() - 1 {
1316                         assert_eq!(events.len(), 1);
1317                         match events[0] {
1318                                 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
1319                                         assert!(update_add_htlcs.is_empty());
1320                                         assert!(update_fulfill_htlcs.is_empty());
1321                                         assert_eq!(update_fail_htlcs.len(), 1);
1322                                         assert!(update_fail_malformed_htlcs.is_empty());
1323                                         assert!(update_fee.is_none());
1324                                         expected_next_node = node_id.clone();
1325                                         next_msgs = Some((update_fail_htlcs[0].clone(), commitment_signed.clone()));
1326                                 },
1327                                 _ => panic!("Unexpected event"),
1328                         }
1329                 } else {
1330                         assert!(events.is_empty());
1331                 }
1332                 if !skip_last && idx == expected_route.len() - 1 {
1333                         assert_eq!(expected_next_node, origin_node.node.get_our_node_id());
1334                 }
1335
1336                 prev_node = node;
1337         }
1338
1339         if !skip_last {
1340                 update_fail_dance!(origin_node, expected_route.first().unwrap(), true);
1341
1342                 let events = origin_node.node.get_and_clear_pending_events();
1343                 assert_eq!(events.len(), 1);
1344                 match events[0] {
1345                         Event::PaymentFailed { payment_hash, rejected_by_dest, .. } => {
1346                                 assert_eq!(payment_hash, our_payment_hash);
1347                                 assert!(rejected_by_dest);
1348                         },
1349                         _ => panic!("Unexpected event"),
1350                 }
1351         }
1352 }
1353
1354 pub fn fail_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], our_payment_hash: PaymentHash)  {
1355         fail_payment_along_route(origin_node, expected_route, false, our_payment_hash);
1356 }
1357
1358 pub fn create_chanmon_cfgs(node_count: usize) -> Vec<TestChanMonCfg> {
1359         let mut chan_mon_cfgs = Vec::new();
1360         for i in 0..node_count {
1361                 let tx_broadcaster = test_utils::TestBroadcaster {
1362                         txn_broadcasted: Mutex::new(Vec::new()),
1363                         blocks: Arc::new(Mutex::new(vec![(genesis_block(Network::Testnet).header, 0)])),
1364                 };
1365                 let fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
1366                 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
1367                 let logger = test_utils::TestLogger::with_id(format!("node {}", i));
1368                 let persister = test_utils::TestPersister::new();
1369                 let seed = [i as u8; 32];
1370                 let keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
1371
1372                 chan_mon_cfgs.push(TestChanMonCfg{ tx_broadcaster, fee_estimator, chain_source, logger, persister, keys_manager });
1373         }
1374
1375         chan_mon_cfgs
1376 }
1377
1378 pub fn create_node_cfgs<'a>(node_count: usize, chanmon_cfgs: &'a Vec<TestChanMonCfg>) -> Vec<NodeCfg<'a>> {
1379         let mut nodes = Vec::new();
1380
1381         for i in 0..node_count {
1382                 let chain_monitor = test_utils::TestChainMonitor::new(Some(&chanmon_cfgs[i].chain_source), &chanmon_cfgs[i].tx_broadcaster, &chanmon_cfgs[i].logger, &chanmon_cfgs[i].fee_estimator, &chanmon_cfgs[i].persister, &chanmon_cfgs[i].keys_manager);
1383                 let seed = [i as u8; 32];
1384                 nodes.push(NodeCfg {
1385                         chain_source: &chanmon_cfgs[i].chain_source,
1386                         logger: &chanmon_cfgs[i].logger,
1387                         tx_broadcaster: &chanmon_cfgs[i].tx_broadcaster,
1388                         fee_estimator: &chanmon_cfgs[i].fee_estimator,
1389                         chain_monitor,
1390                         keys_manager: &chanmon_cfgs[i].keys_manager,
1391                         node_seed: seed,
1392                         features: InitFeatures::known(),
1393                 });
1394         }
1395
1396         nodes
1397 }
1398
1399 pub fn test_default_channel_config() -> UserConfig {
1400         let mut default_config = UserConfig::default();
1401         // Set cltv_expiry_delta slightly lower to keep the final CLTV values inside one byte in our
1402         // tests so that our script-length checks don't fail (see ACCEPTED_HTLC_SCRIPT_WEIGHT).
1403         default_config.channel_options.cltv_expiry_delta = 6*6;
1404         default_config.channel_options.announced_channel = true;
1405         default_config.peer_channel_config_limits.force_announced_channel_preference = false;
1406         // When most of our tests were written, the default HTLC minimum was fixed at 1000.
1407         // It now defaults to 1, so we simply set it to the expected value here.
1408         default_config.own_channel_config.our_htlc_minimum_msat = 1000;
1409         // When most of our tests were written, we didn't have the notion of a `max_dust_htlc_exposure_msat`,
1410         // It now defaults to 5_000_000 msat; to avoid interfering with tests we bump it to 50_000_000 msat.
1411         default_config.channel_options.max_dust_htlc_exposure_msat = 50_000_000;
1412         default_config
1413 }
1414
1415 pub fn create_node_chanmgrs<'a, 'b>(node_count: usize, cfgs: &'a Vec<NodeCfg<'b>>, node_config: &[Option<UserConfig>]) -> Vec<ChannelManager<EnforcingSigner, &'a TestChainMonitor<'b>, &'b test_utils::TestBroadcaster, &'a test_utils::TestKeysInterface, &'b test_utils::TestFeeEstimator, &'b test_utils::TestLogger>> {
1416         let mut chanmgrs = Vec::new();
1417         for i in 0..node_count {
1418                 let network = Network::Testnet;
1419                 let params = ChainParameters {
1420                         network,
1421                         best_block: BestBlock::from_genesis(network),
1422                 };
1423                 let node = ChannelManager::new(cfgs[i].fee_estimator, &cfgs[i].chain_monitor, cfgs[i].tx_broadcaster, cfgs[i].logger, cfgs[i].keys_manager,
1424                         if node_config[i].is_some() { node_config[i].clone().unwrap() } else { test_default_channel_config() }, params);
1425                 chanmgrs.push(node);
1426         }
1427
1428         chanmgrs
1429 }
1430
1431 pub fn create_network<'a, 'b: 'a, 'c: 'b>(node_count: usize, cfgs: &'b Vec<NodeCfg<'c>>, chan_mgrs: &'a Vec<ChannelManager<EnforcingSigner, &'b TestChainMonitor<'c>, &'c test_utils::TestBroadcaster, &'b test_utils::TestKeysInterface, &'c test_utils::TestFeeEstimator, &'c test_utils::TestLogger>>) -> Vec<Node<'a, 'b, 'c>> {
1432         let mut nodes = Vec::new();
1433         let chan_count = Rc::new(RefCell::new(0));
1434         let payment_count = Rc::new(RefCell::new(0));
1435         let connect_style = Rc::new(RefCell::new(ConnectStyle::FullBlockViaListen));
1436
1437         for i in 0..node_count {
1438                 let net_graph_msg_handler = NetGraphMsgHandler::new(cfgs[i].chain_source.genesis_hash, None, cfgs[i].logger);
1439                 nodes.push(Node{ chain_source: cfgs[i].chain_source,
1440                                  tx_broadcaster: cfgs[i].tx_broadcaster, chain_monitor: &cfgs[i].chain_monitor,
1441                                  keys_manager: &cfgs[i].keys_manager, node: &chan_mgrs[i], net_graph_msg_handler,
1442                                  node_seed: cfgs[i].node_seed, network_chan_count: chan_count.clone(),
1443                                  network_payment_count: payment_count.clone(), logger: cfgs[i].logger,
1444                                  blocks: Arc::clone(&cfgs[i].tx_broadcaster.blocks),
1445                                  connect_style: Rc::clone(&connect_style),
1446                 })
1447         }
1448
1449         for i in 0..node_count {
1450                 for j in (i+1)..node_count {
1451                         nodes[i].node.peer_connected(&nodes[j].node.get_our_node_id(), &msgs::Init { features: cfgs[j].features.clone() });
1452                         nodes[j].node.peer_connected(&nodes[i].node.get_our_node_id(), &msgs::Init { features: cfgs[i].features.clone() });
1453                 }
1454         }
1455
1456         nodes
1457 }
1458
1459 // Note that the following only works for CLTV values up to 128
1460 pub const ACCEPTED_HTLC_SCRIPT_WEIGHT: usize = 137; //Here we have a diff due to HTLC CLTV expiry being < 2^15 in test
1461 pub const OFFERED_HTLC_SCRIPT_WEIGHT: usize = 133;
1462
1463 #[derive(PartialEq)]
1464 pub enum HTLCType { NONE, TIMEOUT, SUCCESS }
1465 /// Tests that the given node has broadcast transactions for the given Channel
1466 ///
1467 /// First checks that the latest holder commitment tx has been broadcast, unless an explicit
1468 /// commitment_tx is provided, which may be used to test that a remote commitment tx was
1469 /// broadcast and the revoked outputs were claimed.
1470 ///
1471 /// Next tests that there is (or is not) a transaction that spends the commitment transaction
1472 /// that appears to be the type of HTLC transaction specified in has_htlc_tx.
1473 ///
1474 /// All broadcast transactions must be accounted for in one of the above three types of we'll
1475 /// also fail.
1476 pub fn test_txn_broadcast<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, chan: &(msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction), commitment_tx: Option<Transaction>, has_htlc_tx: HTLCType) -> Vec<Transaction>  {
1477         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1478         assert!(node_txn.len() >= if commitment_tx.is_some() { 0 } else { 1 } + if has_htlc_tx == HTLCType::NONE { 0 } else { 1 });
1479
1480         let mut res = Vec::with_capacity(2);
1481         node_txn.retain(|tx| {
1482                 if tx.input.len() == 1 && tx.input[0].previous_output.txid == chan.3.txid() {
1483                         check_spends!(tx, chan.3);
1484                         if commitment_tx.is_none() {
1485                                 res.push(tx.clone());
1486                         }
1487                         false
1488                 } else { true }
1489         });
1490         if let Some(explicit_tx) = commitment_tx {
1491                 res.push(explicit_tx.clone());
1492         }
1493
1494         assert_eq!(res.len(), 1);
1495
1496         if has_htlc_tx != HTLCType::NONE {
1497                 node_txn.retain(|tx| {
1498                         if tx.input.len() == 1 && tx.input[0].previous_output.txid == res[0].txid() {
1499                                 check_spends!(tx, res[0]);
1500                                 if has_htlc_tx == HTLCType::TIMEOUT {
1501                                         assert!(tx.lock_time != 0);
1502                                 } else {
1503                                         assert!(tx.lock_time == 0);
1504                                 }
1505                                 res.push(tx.clone());
1506                                 false
1507                         } else { true }
1508                 });
1509                 assert!(res.len() == 2 || res.len() == 3);
1510                 if res.len() == 3 {
1511                         assert_eq!(res[1], res[2]);
1512                 }
1513         }
1514
1515         assert!(node_txn.is_empty());
1516         res
1517 }
1518
1519 /// Tests that the given node has broadcast a claim transaction against the provided revoked
1520 /// HTLC transaction.
1521 pub fn test_revoked_htlc_claim_txn_broadcast<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, revoked_tx: Transaction, commitment_revoked_tx: Transaction)  {
1522         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1523         // We may issue multiple claiming transaction on revoked outputs due to block rescan
1524         // for revoked htlc outputs
1525         if node_txn.len() != 1 && node_txn.len() != 2 && node_txn.len() != 3 { assert!(false); }
1526         node_txn.retain(|tx| {
1527                 if tx.input.len() == 1 && tx.input[0].previous_output.txid == revoked_tx.txid() {
1528                         check_spends!(tx, revoked_tx);
1529                         false
1530                 } else { true }
1531         });
1532         node_txn.retain(|tx| {
1533                 check_spends!(tx, commitment_revoked_tx);
1534                 false
1535         });
1536         assert!(node_txn.is_empty());
1537 }
1538
1539 pub fn check_preimage_claim<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, prev_txn: &Vec<Transaction>) -> Vec<Transaction>  {
1540         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1541
1542         assert!(node_txn.len() >= 1);
1543         assert_eq!(node_txn[0].input.len(), 1);
1544         let mut found_prev = false;
1545
1546         for tx in prev_txn {
1547                 if node_txn[0].input[0].previous_output.txid == tx.txid() {
1548                         check_spends!(node_txn[0], tx);
1549                         assert!(node_txn[0].input[0].witness[2].len() > 106); // must spend an htlc output
1550                         assert_eq!(tx.input.len(), 1); // must spend a commitment tx
1551
1552                         found_prev = true;
1553                         break;
1554                 }
1555         }
1556         assert!(found_prev);
1557
1558         let mut res = Vec::new();
1559         mem::swap(&mut *node_txn, &mut res);
1560         res
1561 }
1562
1563 pub fn handle_announce_close_broadcast_events<'a, 'b, 'c>(nodes: &Vec<Node<'a, 'b, 'c>>, a: usize, b: usize, needs_err_handle: bool, expected_error: &str)  {
1564         let events_1 = nodes[a].node.get_and_clear_pending_msg_events();
1565         assert_eq!(events_1.len(), 2);
1566         let as_update = match events_1[0] {
1567                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
1568                         msg.clone()
1569                 },
1570                 _ => panic!("Unexpected event"),
1571         };
1572         match events_1[1] {
1573                 MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
1574                         assert_eq!(node_id, nodes[b].node.get_our_node_id());
1575                         assert_eq!(msg.data, expected_error);
1576                         if needs_err_handle {
1577                                 nodes[b].node.handle_error(&nodes[a].node.get_our_node_id(), msg);
1578                         }
1579                 },
1580                 _ => panic!("Unexpected event"),
1581         }
1582
1583         let events_2 = nodes[b].node.get_and_clear_pending_msg_events();
1584         assert_eq!(events_2.len(), if needs_err_handle { 1 } else { 2 });
1585         let bs_update = match events_2[0] {
1586                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
1587                         msg.clone()
1588                 },
1589                 _ => panic!("Unexpected event"),
1590         };
1591         if !needs_err_handle {
1592                 match events_2[1] {
1593                         MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
1594                                 assert_eq!(node_id, nodes[a].node.get_our_node_id());
1595                                 assert_eq!(msg.data, expected_error);
1596                         },
1597                         _ => panic!("Unexpected event"),
1598                 }
1599         }
1600
1601         for node in nodes {
1602                 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
1603                 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
1604         }
1605 }
1606
1607 pub fn get_announce_close_broadcast_events<'a, 'b, 'c>(nodes: &Vec<Node<'a, 'b, 'c>>, a: usize, b: usize)  {
1608         handle_announce_close_broadcast_events(nodes, a, b, false, "Commitment or closing transaction was confirmed on chain.");
1609 }
1610
1611 #[cfg(test)]
1612 macro_rules! get_channel_value_stat {
1613         ($node: expr, $channel_id: expr) => {{
1614                 let chan_lock = $node.node.channel_state.lock().unwrap();
1615                 let chan = chan_lock.by_id.get(&$channel_id).unwrap();
1616                 chan.get_value_stat()
1617         }}
1618 }
1619
1620 macro_rules! get_chan_reestablish_msgs {
1621         ($src_node: expr, $dst_node: expr) => {
1622                 {
1623                         let mut res = Vec::with_capacity(1);
1624                         for msg in $src_node.node.get_and_clear_pending_msg_events() {
1625                                 if let MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } = msg {
1626                                         assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1627                                         res.push(msg.clone());
1628                                 } else {
1629                                         panic!("Unexpected event")
1630                                 }
1631                         }
1632                         res
1633                 }
1634         }
1635 }
1636
1637 macro_rules! handle_chan_reestablish_msgs {
1638         ($src_node: expr, $dst_node: expr) => {
1639                 {
1640                         let msg_events = $src_node.node.get_and_clear_pending_msg_events();
1641                         let mut idx = 0;
1642                         let funding_locked = if let Some(&MessageSendEvent::SendFundingLocked { ref node_id, ref msg }) = msg_events.get(0) {
1643                                 idx += 1;
1644                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1645                                 Some(msg.clone())
1646                         } else {
1647                                 None
1648                         };
1649
1650                         if let Some(&MessageSendEvent::SendAnnouncementSignatures { ref node_id, msg: _ }) = msg_events.get(idx) {
1651                                 idx += 1;
1652                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1653                         }
1654
1655                         let mut revoke_and_ack = None;
1656                         let mut commitment_update = None;
1657                         let order = if let Some(ev) = msg_events.get(idx) {
1658                                 match ev {
1659                                         &MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1660                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1661                                                 revoke_and_ack = Some(msg.clone());
1662                                                 idx += 1;
1663                                                 RAACommitmentOrder::RevokeAndACKFirst
1664                                         },
1665                                         &MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1666                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1667                                                 commitment_update = Some(updates.clone());
1668                                                 idx += 1;
1669                                                 RAACommitmentOrder::CommitmentFirst
1670                                         },
1671                                         &MessageSendEvent::SendChannelUpdate { .. } => RAACommitmentOrder::CommitmentFirst,
1672                                         _ => panic!("Unexpected event"),
1673                                 }
1674                         } else {
1675                                 RAACommitmentOrder::CommitmentFirst
1676                         };
1677
1678                         if let Some(ev) = msg_events.get(idx) {
1679                                 match ev {
1680                                         &MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1681                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1682                                                 assert!(revoke_and_ack.is_none());
1683                                                 revoke_and_ack = Some(msg.clone());
1684                                                 idx += 1;
1685                                         },
1686                                         &MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1687                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1688                                                 assert!(commitment_update.is_none());
1689                                                 commitment_update = Some(updates.clone());
1690                                                 idx += 1;
1691                                         },
1692                                         &MessageSendEvent::SendChannelUpdate { .. } => {},
1693                                         _ => panic!("Unexpected event"),
1694                                 }
1695                         }
1696
1697                         if let Some(&MessageSendEvent::SendChannelUpdate { ref node_id, ref msg }) = msg_events.get(idx) {
1698                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1699                                 assert_eq!(msg.contents.flags & 2, 0); // "disabled" flag must not be set as we just reconnected.
1700                         }
1701
1702                         (funding_locked, revoke_and_ack, commitment_update, order)
1703                 }
1704         }
1705 }
1706
1707 /// pending_htlc_adds includes both the holding cell and in-flight update_add_htlcs, whereas
1708 /// for claims/fails they are separated out.
1709 pub fn reconnect_nodes<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, send_funding_locked: (bool, bool), pending_htlc_adds: (i64, i64), pending_htlc_claims: (usize, usize), pending_htlc_fails: (usize, usize), pending_cell_htlc_claims: (usize, usize), pending_cell_htlc_fails: (usize, usize), pending_raa: (bool, bool))  {
1710         node_a.node.peer_connected(&node_b.node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1711         let reestablish_1 = get_chan_reestablish_msgs!(node_a, node_b);
1712         node_b.node.peer_connected(&node_a.node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1713         let reestablish_2 = get_chan_reestablish_msgs!(node_b, node_a);
1714
1715         if send_funding_locked.0 {
1716                 // If a expects a funding_locked, it better not think it has received a revoke_and_ack
1717                 // from b
1718                 for reestablish in reestablish_1.iter() {
1719                         assert_eq!(reestablish.next_remote_commitment_number, 0);
1720                 }
1721         }
1722         if send_funding_locked.1 {
1723                 // If b expects a funding_locked, it better not think it has received a revoke_and_ack
1724                 // from a
1725                 for reestablish in reestablish_2.iter() {
1726                         assert_eq!(reestablish.next_remote_commitment_number, 0);
1727                 }
1728         }
1729         if send_funding_locked.0 || send_funding_locked.1 {
1730                 // If we expect any funding_locked's, both sides better have set
1731                 // next_holder_commitment_number to 1
1732                 for reestablish in reestablish_1.iter() {
1733                         assert_eq!(reestablish.next_local_commitment_number, 1);
1734                 }
1735                 for reestablish in reestablish_2.iter() {
1736                         assert_eq!(reestablish.next_local_commitment_number, 1);
1737                 }
1738         }
1739
1740         let mut resp_1 = Vec::new();
1741         for msg in reestablish_1 {
1742                 node_b.node.handle_channel_reestablish(&node_a.node.get_our_node_id(), &msg);
1743                 resp_1.push(handle_chan_reestablish_msgs!(node_b, node_a));
1744         }
1745         if pending_cell_htlc_claims.0 != 0 || pending_cell_htlc_fails.0 != 0 {
1746                 check_added_monitors!(node_b, 1);
1747         } else {
1748                 check_added_monitors!(node_b, 0);
1749         }
1750
1751         let mut resp_2 = Vec::new();
1752         for msg in reestablish_2 {
1753                 node_a.node.handle_channel_reestablish(&node_b.node.get_our_node_id(), &msg);
1754                 resp_2.push(handle_chan_reestablish_msgs!(node_a, node_b));
1755         }
1756         if pending_cell_htlc_claims.1 != 0 || pending_cell_htlc_fails.1 != 0 {
1757                 check_added_monitors!(node_a, 1);
1758         } else {
1759                 check_added_monitors!(node_a, 0);
1760         }
1761
1762         // We don't yet support both needing updates, as that would require a different commitment dance:
1763         assert!((pending_htlc_adds.0 == 0 && pending_htlc_claims.0 == 0 && pending_htlc_fails.0 == 0 &&
1764                          pending_cell_htlc_claims.0 == 0 && pending_cell_htlc_fails.0 == 0) ||
1765                         (pending_htlc_adds.1 == 0 && pending_htlc_claims.1 == 0 && pending_htlc_fails.1 == 0 &&
1766                          pending_cell_htlc_claims.1 == 0 && pending_cell_htlc_fails.1 == 0));
1767
1768         for chan_msgs in resp_1.drain(..) {
1769                 if send_funding_locked.0 {
1770                         node_a.node.handle_funding_locked(&node_b.node.get_our_node_id(), &chan_msgs.0.unwrap());
1771                         let announcement_event = node_a.node.get_and_clear_pending_msg_events();
1772                         if !announcement_event.is_empty() {
1773                                 assert_eq!(announcement_event.len(), 1);
1774                                 if let MessageSendEvent::SendAnnouncementSignatures { .. } = announcement_event[0] {
1775                                         //TODO: Test announcement_sigs re-sending
1776                                 } else { panic!("Unexpected event!"); }
1777                         }
1778                 } else {
1779                         assert!(chan_msgs.0.is_none());
1780                 }
1781                 if pending_raa.0 {
1782                         assert!(chan_msgs.3 == RAACommitmentOrder::RevokeAndACKFirst);
1783                         node_a.node.handle_revoke_and_ack(&node_b.node.get_our_node_id(), &chan_msgs.1.unwrap());
1784                         assert!(node_a.node.get_and_clear_pending_msg_events().is_empty());
1785                         check_added_monitors!(node_a, 1);
1786                 } else {
1787                         assert!(chan_msgs.1.is_none());
1788                 }
1789                 if pending_htlc_adds.0 != 0 || pending_htlc_claims.0 != 0 || pending_htlc_fails.0 != 0 || pending_cell_htlc_claims.0 != 0 || pending_cell_htlc_fails.0 != 0 {
1790                         let commitment_update = chan_msgs.2.unwrap();
1791                         if pending_htlc_adds.0 != -1 { // We use -1 to denote a response commitment_signed
1792                                 assert_eq!(commitment_update.update_add_htlcs.len(), pending_htlc_adds.0 as usize);
1793                         } else {
1794                                 assert!(commitment_update.update_add_htlcs.is_empty());
1795                         }
1796                         assert_eq!(commitment_update.update_fulfill_htlcs.len(), pending_htlc_claims.0 + pending_cell_htlc_claims.0);
1797                         assert_eq!(commitment_update.update_fail_htlcs.len(), pending_htlc_fails.0 + pending_cell_htlc_fails.0);
1798                         assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
1799                         for update_add in commitment_update.update_add_htlcs {
1800                                 node_a.node.handle_update_add_htlc(&node_b.node.get_our_node_id(), &update_add);
1801                         }
1802                         for update_fulfill in commitment_update.update_fulfill_htlcs {
1803                                 node_a.node.handle_update_fulfill_htlc(&node_b.node.get_our_node_id(), &update_fulfill);
1804                         }
1805                         for update_fail in commitment_update.update_fail_htlcs {
1806                                 node_a.node.handle_update_fail_htlc(&node_b.node.get_our_node_id(), &update_fail);
1807                         }
1808
1809                         if pending_htlc_adds.0 != -1 { // We use -1 to denote a response commitment_signed
1810                                 commitment_signed_dance!(node_a, node_b, commitment_update.commitment_signed, false);
1811                         } else {
1812                                 node_a.node.handle_commitment_signed(&node_b.node.get_our_node_id(), &commitment_update.commitment_signed);
1813                                 check_added_monitors!(node_a, 1);
1814                                 let as_revoke_and_ack = get_event_msg!(node_a, MessageSendEvent::SendRevokeAndACK, node_b.node.get_our_node_id());
1815                                 // No commitment_signed so get_event_msg's assert(len == 1) passes
1816                                 node_b.node.handle_revoke_and_ack(&node_a.node.get_our_node_id(), &as_revoke_and_ack);
1817                                 assert!(node_b.node.get_and_clear_pending_msg_events().is_empty());
1818                                 check_added_monitors!(node_b, 1);
1819                         }
1820                 } else {
1821                         assert!(chan_msgs.2.is_none());
1822                 }
1823         }
1824
1825         for chan_msgs in resp_2.drain(..) {
1826                 if send_funding_locked.1 {
1827                         node_b.node.handle_funding_locked(&node_a.node.get_our_node_id(), &chan_msgs.0.unwrap());
1828                         let announcement_event = node_b.node.get_and_clear_pending_msg_events();
1829                         if !announcement_event.is_empty() {
1830                                 assert_eq!(announcement_event.len(), 1);
1831                                 if let MessageSendEvent::SendAnnouncementSignatures { .. } = announcement_event[0] {
1832                                         //TODO: Test announcement_sigs re-sending
1833                                 } else { panic!("Unexpected event!"); }
1834                         }
1835                 } else {
1836                         assert!(chan_msgs.0.is_none());
1837                 }
1838                 if pending_raa.1 {
1839                         assert!(chan_msgs.3 == RAACommitmentOrder::RevokeAndACKFirst);
1840                         node_b.node.handle_revoke_and_ack(&node_a.node.get_our_node_id(), &chan_msgs.1.unwrap());
1841                         assert!(node_b.node.get_and_clear_pending_msg_events().is_empty());
1842                         check_added_monitors!(node_b, 1);
1843                 } else {
1844                         assert!(chan_msgs.1.is_none());
1845                 }
1846                 if pending_htlc_adds.1 != 0 || pending_htlc_claims.1 != 0 || pending_htlc_fails.1 != 0 || pending_cell_htlc_claims.1 != 0 || pending_cell_htlc_fails.1 != 0 {
1847                         let commitment_update = chan_msgs.2.unwrap();
1848                         if pending_htlc_adds.1 != -1 { // We use -1 to denote a response commitment_signed
1849                                 assert_eq!(commitment_update.update_add_htlcs.len(), pending_htlc_adds.1 as usize);
1850                         }
1851                         assert_eq!(commitment_update.update_fulfill_htlcs.len(), pending_htlc_claims.1 + pending_cell_htlc_claims.1);
1852                         assert_eq!(commitment_update.update_fail_htlcs.len(), pending_htlc_fails.1 + pending_cell_htlc_fails.1);
1853                         assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
1854                         for update_add in commitment_update.update_add_htlcs {
1855                                 node_b.node.handle_update_add_htlc(&node_a.node.get_our_node_id(), &update_add);
1856                         }
1857                         for update_fulfill in commitment_update.update_fulfill_htlcs {
1858                                 node_b.node.handle_update_fulfill_htlc(&node_a.node.get_our_node_id(), &update_fulfill);
1859                         }
1860                         for update_fail in commitment_update.update_fail_htlcs {
1861                                 node_b.node.handle_update_fail_htlc(&node_a.node.get_our_node_id(), &update_fail);
1862                         }
1863
1864                         if pending_htlc_adds.1 != -1 { // We use -1 to denote a response commitment_signed
1865                                 commitment_signed_dance!(node_b, node_a, commitment_update.commitment_signed, false);
1866                         } else {
1867                                 node_b.node.handle_commitment_signed(&node_a.node.get_our_node_id(), &commitment_update.commitment_signed);
1868                                 check_added_monitors!(node_b, 1);
1869                                 let bs_revoke_and_ack = get_event_msg!(node_b, MessageSendEvent::SendRevokeAndACK, node_a.node.get_our_node_id());
1870                                 // No commitment_signed so get_event_msg's assert(len == 1) passes
1871                                 node_a.node.handle_revoke_and_ack(&node_b.node.get_our_node_id(), &bs_revoke_and_ack);
1872                                 assert!(node_a.node.get_and_clear_pending_msg_events().is_empty());
1873                                 check_added_monitors!(node_a, 1);
1874                         }
1875                 } else {
1876                         assert!(chan_msgs.2.is_none());
1877                 }
1878         }
1879 }