X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=ts%2Fstructs%2FChannelDetails.ts;fp=ts%2Fstructs%2FChannelDetails.ts;h=5e8c88a20fcfd3e28d452c802a7e40f626d6d734;hb=fed2245c60159f6c074c9ed5c0f3ce273ad9841b;hp=3643d2a1dfb24f525ca869fb675576948a4752c9;hpb=e9c2970adecaa14b3e83e11eb160a7bcbdae20da;p=ldk-java

diff --git a/ts/structs/ChannelDetails.ts b/ts/structs/ChannelDetails.ts
index 3643d2a1..5e8c88a2 100644
--- a/ts/structs/ChannelDetails.ts
+++ b/ts/structs/ChannelDetails.ts
@@ -21,6 +21,7 @@ import * as bindings from '../bindings' // TODO: figure out location
 	public ChannelDetails clone() {
 		number ret = bindings.ChannelDetails_clone(this.ptr);
 		const ret_hu_conv: ChannelDetails = new ChannelDetails(null, ret);
+		ret_hu_conv.ptrs_to.add(this);
 		return ret_hu_conv;
 	}
 
@@ -45,12 +46,21 @@ import * as bindings from '../bindings' // TODO: figure out location
 	public InitFeatures get_counterparty_features() {
 		number ret = bindings.ChannelDetails_get_counterparty_features(this.ptr);
 		const ret_hu_conv: InitFeatures = new InitFeatures(null, ret);
+		ret_hu_conv.ptrs_to.add(this);
 		return ret_hu_conv;
 	}
 
 	public void set_counterparty_features(InitFeatures val) {
 		bindings.ChannelDetails_set_counterparty_features(this.ptr, val == null ? 0 : val.ptr & ~1);
 		this.ptrs_to.add(val);
+		// Due to rust's strict-ownership memory model, in some cases we need to "move"
+		// an object to pass exclusive ownership to the function being called.
+		// In most cases, we avoid this being visible in GC'd languages by cloning the object
+		// at the FFI layer, creating a new object which Rust can claim ownership of
+		// However, in some cases (eg here), there is no way to clone an object, and thus
+		// we actually have to pass full ownership to Rust.
+		// Thus, after this call, val is reset to null and is now a dummy object.
+		val.ptr = 0;
 	}
 
 	public number get_channel_value_satoshis() {