Matt Corallo [Mon, 10 Feb 2020 22:18:48 +0000 (22:18 +0000)]
Merge pull request #490 from jkczyz/2020-02-initial-routing-sync
Refactor logic for setting initial_routing_sync feature bit
Jeffrey Czyz [Mon, 10 Feb 2020 20:01:35 +0000 (12:01 -0800)]
Add a test for Router's should_request_full_sync
Jeffrey Czyz [Mon, 10 Feb 2020 19:54:46 +0000 (11:54 -0800)]
Move Router test setup to a helper function
Jeffrey Czyz [Mon, 10 Feb 2020 19:13:41 +0000 (11:13 -0800)]
Move initial_routing_sync decision to the Router
PeerManager determines whether the initial_routing_sync feature bit
should be set when sending Init messages to peers. Move this to the
Router as it is better able to determine if a full sync is needed.
Matt Corallo [Mon, 10 Feb 2020 18:47:44 +0000 (18:47 +0000)]
Merge pull request #445 from TheBlueMatt/2020-01-fuzz-enforcer-fix
Fix EnforcingChannelKeys panic when our counterparty burns their $.
Matt Corallo [Mon, 10 Feb 2020 17:52:29 +0000 (17:52 +0000)]
Merge pull request #487 from moneyball/master
remove unnecessary reference to LDK
Steve Lee [Mon, 10 Feb 2020 03:08:35 +0000 (19:08 -0800)]
Update README.md
Matt Corallo [Sat, 8 Feb 2020 21:21:07 +0000 (21:21 +0000)]
Merge pull request #479 from moneyball/master
Updated the status of the project
Matt Corallo [Sat, 8 Feb 2020 21:20:20 +0000 (21:20 +0000)]
Merge pull request #478 from arik-so/remove_decodeerror_macro
remove decode_error macro only used once
Matt Corallo [Thu, 16 Jan 2020 23:53:32 +0000 (18:53 -0500)]
Test that EnforcingChannelKeys doesn't panic on duplicate RAAs
Matt Corallo [Sun, 12 Jan 2020 23:04:40 +0000 (18:04 -0500)]
Fix EnforcingChannelKeys panic when our counterparty burns their $.
If our counterparty burns their funds by revoking their current
commitment transaction before we've sent them a new one, we'll step
forward the remote commitment number. This would be otherwise fine
(and may even encourage them to broadcast their revoked state(s) on
chain), except that our new EnforcingChannelKeys expects us to not
jump forward in time. Since it isn't too important that we punish
our counterparty in such a corner-case, we opt to just close the
channel in such a case and move on.
Steve Lee [Fri, 7 Feb 2020 21:34:23 +0000 (13:34 -0800)]
Update README.md
Steve Lee [Fri, 7 Feb 2020 05:43:47 +0000 (21:43 -0800)]
Updated the status of the project
It needs review and completion of the missing BOLT specification parts.
Arik Sosman [Thu, 6 Feb 2020 22:17:44 +0000 (14:17 -0800)]
remove decode_error macro only used once
Matt Corallo [Wed, 5 Feb 2020 21:18:42 +0000 (21:18 +0000)]
Merge pull request #463 from jkczyz/2020-01-wire-encode
Encapsulate message wire encoding into a module
Jeffrey Czyz [Mon, 27 Jan 2020 21:44:36 +0000 (13:44 -0800)]
Use a tuple struct for MessageType
Jeffrey Czyz [Fri, 24 Jan 2020 14:43:58 +0000 (06:43 -0800)]
Move message type parity logic to the wire module
Create a MessageType abstraction and use it throughout the wire module's
external interfaces. Include an is_even method for clients to determine
how to handle unknown messages.
Jeffrey Czyz [Tue, 21 Jan 2020 23:26:21 +0000 (15:26 -0800)]
Encapsulate message wire encoding into a module
Lightning messages are identified by a 2-byte type when encoded on the
wire. Rather than expecting callers to know message types when sending
messages to peers, have each message implement a trait defining the
message type. Provide an interface for reading and writing messages
as well as a Message enum for matching the decoded message, including
unknown messages.
Matt Corallo [Wed, 5 Feb 2020 01:23:44 +0000 (01:23 +0000)]
Merge pull request #454 from TheBlueMatt/2020-01-fuzz-mega-value
Panic on txn with value > 21mill in ChannelMonitor::block_connected, Clean up fuzz targets a bit
Matt Corallo [Wed, 5 Feb 2020 01:17:46 +0000 (01:17 +0000)]
Merge pull request #466 from lightning-signer/chanmon-keys
Add ChannelKeys to ChannelMonitor
Devrandom [Tue, 4 Feb 2020 17:15:59 +0000 (09:15 -0800)]
Add ChannelKeys to ChannelMonitor
Devrandom [Tue, 4 Feb 2020 17:05:25 +0000 (09:05 -0800)]
move ChannelMonitor.write* in preparation for adding ChannelKeys
Matt Corallo [Sat, 25 Jan 2020 22:11:27 +0000 (22:11 +0000)]
Merge pull request #459 from ariard/2020-01-fix-htlc-height-timer
Fix bumping timer for claiming revoked HTLC outputs
Matt Corallo [Sat, 25 Jan 2020 21:17:12 +0000 (21:17 +0000)]
Merge pull request #460 from lightning-signer/channel-value
Channel value to ChannelKeys constructor
Matt Corallo [Sat, 25 Jan 2020 20:50:10 +0000 (20:50 +0000)]
Merge pull request #458 from TheBlueMatt/2020-01-spendable-docs
Clean up documentation around spendable outputs significantly.
Matt Corallo [Sat, 25 Jan 2020 20:41:10 +0000 (20:41 +0000)]
Merge pull request #443 from valentinewallace/channelmgr-arcs-to-derefs
Drop ChannelManager's ChannelMonitor Arc for Deref
Matt Corallo [Wed, 22 Jan 2020 23:31:57 +0000 (18:31 -0500)]
Clean up documentation around spendable outputs significantly.
* Fixed a number of grammar issues
* Clarified the docs for users who are intimately farmiliar with
arbitrary lines of text copied from the BOLTs
* Added a bit more text so that things are easier to read and less
disjoint.
* Clarified exactly how the witness stack should look since I had
to go dig for it.
Valentine Wallace [Thu, 16 Jan 2020 18:26:38 +0000 (13:26 -0500)]
Update ChannelManager's ChannelMonitor Arc to be a Deref
Additional changes:
* Update fuzz crate to match ChannelManager's new API
* Update lightning-net-tokio library to match ChannelManager's new ChannelMonitor Deref API
* Update tests to match ChannelManager's new ChannelMonitor Deref API
Devrandom [Thu, 23 Jan 2020 22:32:29 +0000 (14:32 -0800)]
Remove unnecessary sign_closing_transaction arg
Devrandom [Thu, 23 Jan 2020 21:33:31 +0000 (13:33 -0800)]
channel value to ChannelKeys constructor
Antoine Riard [Thu, 23 Jan 2020 00:51:19 +0000 (19:51 -0500)]
Fix bumping timer for claiming revoked HTLC outputs
Previously, we were using their_to_self_delay instead of
our_to_self_delay which was falsifying test.
Matt Corallo [Wed, 22 Jan 2020 20:57:36 +0000 (20:57 +0000)]
Merge pull request #457 from ariard/2020-01-fix-append-onchain
Fix spurious calls of broadcast_by_local_state
Matt Corallo [Wed, 22 Jan 2020 20:18:30 +0000 (20:18 +0000)]
Merge pull request #433 from TheBlueMatt/2019-12-features-in-routes
Plumb Features through into Routes
Antoine Riard [Wed, 22 Jan 2020 18:53:12 +0000 (13:53 -0500)]
Fix spurious calls of broadcast_by_local_state
Matt Corallo [Fri, 17 Jan 2020 22:36:46 +0000 (17:36 -0500)]
DRY-up list_channels by having a common lister that takes a filter
Matt Corallo [Sat, 28 Dec 2019 06:10:14 +0000 (01:10 -0500)]
Pass node features through to RouteHops
This exposes the latest Init-context features in the ChannelDetails
passed to the Router during route calculation, which combines those
with the Node-context features tracked from node_announcements to
provide the latest Node-context features in RouteHop structs.
Fields are also added for Channel-context features, though those are
only partially used since no such features are defined today anyway.
These will be useful when determining whether to use new
TLV-formatted onion hop datas when generating onions for peers.
Matt Corallo [Sun, 29 Dec 2019 19:22:43 +0000 (14:22 -0500)]
Keep track of the Init Features for every connected/channel'd peer
Since we want to keep track of the Init-context features for every
peer we have channels with, we have to keep them for as long as the
peer is connected (since we may open a channel with them at any
point).
We go ahead and take this opportunity to create a new per-peer-state
struct which has two levels of mutexes which is appropriate for
moving channel storage to.
Since we can't process messages from a given peer in parallel, the
inner lock is a regular mutex, but the outer lock is RW so that we
can process for different peers at the same time with an outer read
lock.
Matt Corallo [Sat, 28 Dec 2019 03:50:42 +0000 (22:50 -0500)]
Pass peer's Init message through to ChannelManager
Matt Corallo [Mon, 20 Jan 2020 03:46:00 +0000 (03:46 +0000)]
Merge pull request #451 from lightning-signer/txkeys
Provide remote channel public keys to signer
Devrandom [Fri, 17 Jan 2020 22:31:29 +0000 (14:31 -0800)]
Use ChannelPublicKeys in Channel
Devrandom [Fri, 17 Jan 2020 20:46:54 +0000 (12:46 -0800)]
Hide derived fields in TxCreationKeys
Devrandom [Fri, 17 Jan 2020 00:51:15 +0000 (16:51 -0800)]
Provide remote channel public keys to signer
Matt Corallo [Sun, 19 Jan 2020 21:03:25 +0000 (16:03 -0500)]
Panic on txn with value > 21mill in ChannelMonitor::block_connected
full_stack_target found a crash where we may overflow ruring fee
calculation if a transaction appears on-chain with massive value
available for us to claim. Since these transactions are clearly
bogus, we shouldn't allow full_stack_target to connect them, but
we also improve the error generated by explicitly panicing on them.
Matt Corallo [Sun, 19 Jan 2020 20:38:34 +0000 (15:38 -0500)]
Drop individual fuzz target duplicate_crash tests for file reader
Previously, in each of our fuzz tests we had a dummy test which
had a hard-coded hex string which it passed into the fuzz target
so that when a failing test case was found, its hex could be
copied into the test and you could run cargo test to analyze the
failure. However, this was somewhat unwieldy as converting large
tests back and forth between hex and raw files is quite annoying.
Instead, we replace each of those tests with a test in each target
that looks for files in fuzz/test_cases and runs each file it finds.
Since we're editing every bin target anyway, we also automate adding
no_main to libfuzzer builds with #![cfg_attr].
Matt Corallo [Fri, 17 Jan 2020 22:32:29 +0000 (22:32 +0000)]
Merge pull request #447 from ariard/2020-01-fix-weight-computation
Bound incoming HTLC witnessScript to min/max limits
Antoine Riard [Tue, 14 Jan 2020 18:47:01 +0000 (13:47 -0500)]
Bound incoming HTLC witnessScript to min/max limits
Fix a crash where previously we weren't able to detect any accepted
HTLC if its witness-encoded cltv expiry was different from expected
ACCEPTED_HTLC_SCRIPT_WEIGHT. This should work for any cltv expiry
included between 0 and
16777216 on mainnet, testnet and regtest.
Matt Corallo [Mon, 13 Jan 2020 18:43:54 +0000 (13:43 -0500)]
Fix crash when a claim tx has some non-witness inputs.
The logger which decides what to refer to an on-chain claim tx was
assuming that all inputs would have a witness. While this was fine
for the one-input case, it broke the fuzzer which was connecting a
consensus-invalid transaction. Further, in the case we have multiple
inputs, some may not have a witness, which we shouldn't crash on.
This fixes
9df0250dbbad7449e3ec8f90532ce9197eb31997.
Matt Corallo [Fri, 17 Jan 2020 20:13:46 +0000 (20:13 +0000)]
Merge pull request #450 from ariard/2020-01-fix-fst-blk-disconnection
Fix full_stack_target block disconnection
Antoine Riard [Fri, 17 Jan 2020 19:21:02 +0000 (14:21 -0500)]
Fix full_stack_target mishandling of block disconnection
Antoine Riard [Fri, 17 Jan 2020 19:20:23 +0000 (14:20 -0500)]
Log block disconnection in ChannelMonitor
Matt Corallo [Thu, 16 Jan 2020 23:54:09 +0000 (23:54 +0000)]
Merge pull request #448 from lightning-signer/visibility-for-test
Increase visibility for external integration tests
Devrandom [Wed, 15 Jan 2020 21:59:23 +0000 (13:59 -0800)]
increase visibility for external integration tests
Matt Corallo [Thu, 16 Jan 2020 22:02:20 +0000 (22:02 +0000)]
Merge pull request #444 from lightning-signer/funding-script
Construct funding redeem script in signer
Devrandom [Fri, 10 Jan 2020 01:28:48 +0000 (17:28 -0800)]
construct funding redeem script in signer
Matt Corallo [Thu, 16 Jan 2020 20:18:13 +0000 (20:18 +0000)]
Merge pull request #449 from jkczyz/2020-01-remove-borrow-parts
Remove unnecessary borrow_parts() methods
Jeffrey Czyz [Thu, 16 Jan 2020 18:48:16 +0000 (10:48 -0800)]
Remove unnecessary borrow_parts() methods
Accessing a struct through an std::syn::MutexGuard using implicit
dereferencing can confuse the borrow checker. This situation arises when
obtaining mutable references to more than one field of the struct, which
is normally allowed.
https://doc.rust-lang.org/nomicon/borrow-splitting.html
However, when using implicit dereferencing, a mutable reference to the
the entire struct is taken. Thus, attempting to access another field in
this manner will lead to a compilation error.
https://doc.rust-lang.org/error-index.html#E0499
A simple way to avoid this is to first obtain a mutable reference to the
struct using explicit dereferencing.
Matt Corallo [Mon, 13 Jan 2020 22:53:54 +0000 (22:53 +0000)]
Merge pull request #428 from TheBlueMatt/2019-12-flat-features
Implement Flat Features
Matt Corallo [Wed, 8 Jan 2020 00:21:17 +0000 (19:21 -0500)]
Seal the features contexts
Matt Corallo [Mon, 6 Jan 2020 22:54:02 +0000 (17:54 -0500)]
Move features into a separate module out of msgs.
Matt Corallo [Mon, 13 Jan 2020 18:52:23 +0000 (13:52 -0500)]
Refactor features a bit more to describe what the constructors do
The Features::new() method is nonsense and doesn't describe what
features were being set - we introduce an empty() and supported()
constructors instead.
Matt Corallo [Mon, 13 Jan 2020 18:50:29 +0000 (13:50 -0500)]
Fix Feature endianness by swapping bytes on read/write.
The spec is a bit mum on feature endianness, so I suppose it falls
under the "everything is big endian unless otherwise specified"
clause, but we were treating it as little.
Matt Corallo [Tue, 24 Dec 2019 18:08:33 +0000 (13:08 -0500)]
Relay/store channel/node announces w/ unknown req'd feature bits
This change was made in the flat features BOLT PR, as if a channel
requires some unknown feature bits we should still rumor it, we just
shouldn't route through it.
Matt Corallo [Mon, 23 Dec 2019 22:52:58 +0000 (17:52 -0500)]
Implement Flat Features
This merges local and global features into one struct, which is
parameterized by where it appers. The parameterization restricts
which queries can be made and which features can be set, in line
with the latest BOLT 9.
Closes #427.
Matt Corallo [Mon, 6 Jan 2020 03:59:03 +0000 (03:59 +0000)]
Merge pull request #439 from TheBlueMatt/2020-01-398-fixups
398 with nits fixed.
Antoine Riard [Tue, 5 Nov 2019 23:51:05 +0000 (18:51 -0500)]
Drop Result for ChannelMessageHandler methods
Simplify interfaces between ChannelMessageHandler and PeerManager,
by switching all ChannelMessageHandler errors to HandleError sent
internally instead of being return. With further refactors in Router
and PeerChannelEncryptor, errors management on the PeerManager-side
won't be splitted between try_potential_handleerror and HandleError
processing.
Inside ChannelManager, we now log MsgHandleErrInternal and send
ErrorAction to PeerManager.
On a high-level, it should allow client using API to be more flexible
by polling events instead of waiting function call returns.
We also update handle_error macro to take channel_state_lock from
caller which should avoid some deadlock potential for some edges
cases.
Filter out IgnoreError in handle_error macro, update test in
consequence.
Antoine Riard [Mon, 30 Dec 2019 22:30:27 +0000 (17:30 -0500)]
Add assert_log method to TestLogger to harden test
Extend mock Node with logger.
Matt Corallo [Sun, 5 Jan 2020 17:49:12 +0000 (17:49 +0000)]
Merge pull request #437 from Aleru/new-api-ping
New API for ping generation
Aleru [Fri, 20 Sep 2019 15:16:45 +0000 (11:16 -0400)]
New API for ping generation
New API for generating pings
Matt Corallo [Sat, 28 Dec 2019 17:50:09 +0000 (17:50 +0000)]
Merge pull request #420 from TheBlueMatt/2019-12-chan-ext-signer
Remove signing from Channel
Matt Corallo [Fri, 13 Dec 2019 19:56:57 +0000 (14:56 -0500)]
Sign local HTLC transactions at broadcast-time, instead of generate
Matt Corallo [Fri, 13 Dec 2019 06:58:08 +0000 (01:58 -0500)]
Make ChannelMonitor sign local transactions (at broadcast time)
Matt Corallo [Thu, 12 Dec 2019 19:56:28 +0000 (14:56 -0500)]
Set basic channel info in chanmon all at once, add a bit more info
Matt Corallo [Fri, 13 Dec 2019 03:42:08 +0000 (22:42 -0500)]
Drop duplicative current-local-tx storage in channel.
We now have current-local-tx broadcast ability in channel monitors
directly (for ChannelManager deserialization), so we can just use
that instead of always having the Channel store signed ready-to-go
copies of the latest local commitment transaction.
This is further kinda nice since ChannelMonitor is live and can, eg
broadcast HTLC-Success transactions immediately as they will be
generated at broadcast time instead of in advance.
Finally, this lets us clean up a tiny bit in Channel.
Matt Corallo [Tue, 24 Dec 2019 17:01:26 +0000 (12:01 -0500)]
Fix parameter name incorrectly changed in
4ebe64fafd2ca0e17aab31fb0
Matt Corallo [Sat, 21 Dec 2019 00:35:10 +0000 (00:35 +0000)]
Merge pull request #426 from TheBlueMatt/2019-12-bad-lifetimes
Remove unused lifetimes.
Matt Corallo [Fri, 20 Dec 2019 19:53:16 +0000 (14:53 -0500)]
Remove unused lifetimes.
f71518365f61a5fe2a0340953ad6592c0d2b72cc added a series of lifetimes
which were required for an earlier version of the patch but not the
final version. They can be freely removed.
Matt Corallo [Fri, 13 Dec 2019 22:04:53 +0000 (22:04 +0000)]
Merge pull request #419 from TheBlueMatt/2019-12-simple-signer-api-step
Few more simple signer API additions
Matt Corallo [Fri, 13 Dec 2019 06:57:45 +0000 (01:57 -0500)]
Use external key signer to generate closing transaction signatures
Matt Corallo [Sat, 7 Dec 2019 22:54:55 +0000 (17:54 -0500)]
Sign channel_announcements via a new ChannelKeys API
Matt Corallo [Fri, 6 Dec 2019 19:08:34 +0000 (14:08 -0500)]
Use EnforcingChannelKeys in fuzz targets to get more coverage
Matt Corallo [Thu, 12 Dec 2019 18:01:46 +0000 (18:01 +0000)]
Merge pull request #404 from TheBlueMatt/2019-11-signer-api
Replace keys API with Signer API to support hardware wallets eventually
Matt Corallo [Thu, 12 Dec 2019 16:45:18 +0000 (16:45 +0000)]
Merge pull request #417 from TheBlueMatt/2019-12-ver-bump
Bump to 0.0.10
Matt Corallo [Wed, 11 Dec 2019 20:41:39 +0000 (15:41 -0500)]
Bump versions to 0.0.10
Matt Corallo [Wed, 11 Dec 2019 20:41:24 +0000 (15:41 -0500)]
Bump bitcoin dep to 0.21
Matt Corallo [Wed, 11 Dec 2019 23:17:03 +0000 (18:17 -0500)]
Pre-build fuzz targets at once in travis instead of as we need them
Antoine Riard [Tue, 10 Dec 2019 20:04:53 +0000 (15:04 -0500)]
Document more current security assumption of KeysInterface
Improve some comments of interface methods.
Matt Corallo [Wed, 27 Nov 2019 21:08:48 +0000 (16:08 -0500)]
Make commitment transaction signing a part of ChannelKeys.
This adds a new fn to ChannelKeys which is called when we generte
a new remote commitment transaction for signing. While it may be
theoretically possible to unwind state updates by disconnecting and
reconnecting as well as making appropriate state machine changes,
the effort required to get it correct likely outweighs the UX cost
of "preflighting" the requests to hardwre wallets.
Matt Corallo [Tue, 26 Nov 2019 21:46:33 +0000 (16:46 -0500)]
Make ChannelKeys an API and template Channel with it.
Instead of having in-memory access to the list of private keys
associated with a channel, we should have a generic API which
allows us to request signing, allowing the user to store private
keys any way they like.
The first step is the (rather mechanical) process of templating
the entire tree of ChannelManager -> Channel impls by the
key-providing type. In a later commit we should expose only public
keys where possible.
Matt Corallo [Wed, 11 Dec 2019 20:41:39 +0000 (15:41 -0500)]
Bump versions to 0.0.10
Matt Corallo [Wed, 11 Dec 2019 20:41:24 +0000 (15:41 -0500)]
Bump bitcoin dep to 0.21
Matt Corallo [Wed, 11 Dec 2019 22:06:46 +0000 (22:06 +0000)]
Merge pull request #416 from TheBlueMatt/2019-12-fuzz-clib
Refactor fuzzing to be a C-callable library plus rust binaries
Matt Corallo [Wed, 11 Dec 2019 18:18:43 +0000 (13:18 -0500)]
Refactor fuzzing to be a C-callable library plus rust binaries
This should help us avoid rust's at-load syscalls by calling the
tests from a C program.
Matt Corallo [Wed, 11 Dec 2019 19:50:52 +0000 (19:50 +0000)]
Merge pull request #414 from TheBlueMatt/2019-12-347-nits
347 with travis fix and a few nits.
Matt Corallo [Tue, 10 Dec 2019 20:38:04 +0000 (15:38 -0500)]
Avoid cloning RBF state when we just want to modify fields.
Antoine Riard [Tue, 10 Dec 2019 22:25:27 +0000 (17:25 -0500)]
Add test_bump_txn_sanitize_tracking_maps
Extend test visibility of claim-tracking maps to do so.
Cover both "If 2 claimable-outpoint-spending txn are in 1 block,
clean up properly" and "Clean up claimable_outpoints when
pending_claim_requests is cleaned" fix commits in same patchset.
Antoine Riard [Tue, 10 Dec 2019 20:45:30 +0000 (15:45 -0500)]
Sanitize pending_claim_requests if no more outpoints to claim
Matt Corallo [Tue, 10 Dec 2019 17:06:50 +0000 (12:06 -0500)]
Dont RBF a tx twice if it hits RBF timer when one input is spent
Matt Corallo [Tue, 10 Dec 2019 03:51:36 +0000 (22:51 -0500)]
Clean up claimable_outpoints when pending_claim_requests is cleaned
When claimable_outpoints was introduced in "Move
our_claim_txn_waiting_first_conf to pending_claim_requests", removal
of elements from it (which are just pointers into
pending_claim_requests) was never added.
Matt Corallo [Tue, 10 Dec 2019 03:17:31 +0000 (22:17 -0500)]
If 2 claimable-outpoint-spending txn are in 1 block, clean up properly
This resolves an issue where we will never track 2 on-chain events
which are waiting for ANTI_REORG_DELAY at the same height.
This partially reverts and fixes "Move our_claim_txn_waiting_first_conf
to pending_claim_requests".
Antoine Riard [Tue, 10 Dec 2019 21:28:33 +0000 (16:28 -0500)]
Log block tick in ChannelMonitor