]> git.bitcoin.ninja Git - rust-lightning/commit
Make `funding_transaction_generated` take a `ChannelId` by value 2024-07-chan-by-val
authorMatt Corallo <git@bluematt.me>
Thu, 1 Aug 2024 14:34:33 +0000 (14:34 +0000)
committerMatt Corallo <git@bluematt.me>
Sun, 4 Aug 2024 18:16:22 +0000 (18:16 +0000)
commit1ff249516dba6b045b833d490f0fb58807f716df
tree2df196de0a9f8508f4b26e3abf947b9e3345d1ad
parent8c1b3d1263f6b9247c0c819039ef2027dc4d4588
Make `funding_transaction_generated` take a `ChannelId` by value

`ChannelId` is just a 32-byte array, so there's not a lot of value
in passing it by reference to `funding_transaction_generated`,
which we fix here.

This is also nice for bindings as languages like Java can better
analyze whether the `ChannelManager` ends up with a reference to
the `ChannelId`.
fuzz/src/chanmon_consistency.rs
lightning-background-processor/src/lib.rs
lightning/src/ln/async_signer_tests.rs
lightning/src/ln/chanmon_update_fail_tests.rs
lightning/src/ln/channelmanager.rs
lightning/src/ln/functional_test_utils.rs
lightning/src/ln/functional_tests.rs
lightning/src/ln/priv_short_conf_tests.rs
lightning/src/ln/reload_tests.rs