]> git.bitcoin.ninja Git - rust-lightning/commit
Fix `Route` serialization round-trip
authorMatt Corallo <git@bluematt.me>
Fri, 16 Feb 2024 19:26:22 +0000 (19:26 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 16 Feb 2024 19:26:22 +0000 (19:26 +0000)
commit4026d4efd1eb92c47fe567eee6a9cd8824dc1cf2
tree2f82e69353753d7a8ae406e5f28f3837ec0e284f
parent2ada7911b191f8761dde16b2c78eb5ba92bd4800
Fix `Route` serialization round-trip

When the `max_total_routing_fee_msat` parameter was added to
`RouteParameters`, the serialization used `map` to get the max fee,
accidentally writing an `Option<Option<u64>>`, but then read it as
an `Option<u64>`. Thus, any `Route`s with a `route_params` written
will fail to be read back.

Luckily, this is an incredibly rarely-used bit of code, so only one
user managed to hit it.
lightning/src/routing/router.rs