]> git.bitcoin.ninja Git - rust-lightning/commit
Simplify + clarify random-bytes-fetching from KeysInterface 2020-08-keyif-rand-names
authorMatt Corallo <git@bluematt.me>
Sun, 23 Aug 2020 21:06:33 +0000 (17:06 -0400)
committerMatt Corallo <git@bluematt.me>
Sun, 23 Aug 2020 23:39:59 +0000 (19:39 -0400)
commit6497465762ec566f6d422f155d60864ca0834aff
tree18817850312bd1ee38bc8a4f41e51c87fb8056a7
parent8ac0992b14861b8841c5b7f9cb5b3e7a4db1070d
Simplify + clarify random-bytes-fetching from KeysInterface

Due to a desire to be able to override temporary channel IDs and
onion keys, KeysInterface had two separate fetch-random-32-bytes
interfaces - an onion-key specific version which fetched 2 random
32 byte strings and a temporary-channel-id specific version.

It turns out, we never actually need to override both at once (as
creating a new channel and sending an outbound payment are always
separate top-level calls), so there's no reason to add two
functions to the interface when both really do the same thing.
fuzz/src/chanmon_consistency.rs
fuzz/src/full_stack.rs
lightning/src/chain/keysinterface.rs
lightning/src/ln/channel.rs
lightning/src/ln/channelmanager.rs
lightning/src/ln/functional_tests.rs
lightning/src/util/test_utils.rs