]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Bump MSRV to 1.48
authorMatt Corallo <git@bluematt.me>
Wed, 15 Mar 2023 18:08:35 +0000 (18:08 +0000)
committerMatt Corallo <git@bluematt.me>
Wed, 15 Mar 2023 18:11:43 +0000 (18:11 +0000)
1.48.0 was released at the end of 2020, nearly 2.5 years ago. It
has been the rustc available on Debian stable since bullseye,
released in 2021. supporting Debian oldstable for more than a year
seems more than sufficient time to give Debian folks to upgrade,
and bullseye is set to become `oldstable` later this year with the
release of `bookworm`, likely this summer.

This also allows us to clean up our MSRV substantially, having a
single MSRV across our crates rather than a number of separate
ones. Sadly, windows already requires 1.49.

.github/workflows/build.yml

index 100441d2be200cb85e6e70b296691851f9edb818..af861fcac12a6fb323136a93082ae347d7f84a55 100644 (file)
@@ -10,12 +10,8 @@ jobs:
         platform: [ ubuntu-latest ]
         toolchain: [ stable,
                      beta,
-                     # 1.41.1 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister
-                     1.41.1,
-                     # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, lightning-background-processor
-                     1.45.2,
-                     # 1.47.0 will be the MSRV for no-std builds using hashbrown once core2 is updated
-                     1.47.0]
+                     # 1.48.0 is the MSRV for all LDK crates except lightning-transaction-sync and Windows
+                     1.48.0]
         include:
           - toolchain: stable
             build-net-tokio: true
@@ -56,18 +52,7 @@ jobs:
             build-tx-sync: true
           - toolchain: beta
             test-custom-message: true
-          - toolchain: 1.41.1
-            build-no-std: false
-            test-log-variants: true
-            build-futures: false
-            build-tx-sync: false
-          - toolchain: 1.45.2
-            build-net-old-tokio: true
-            build-net-tokio: true
-            build-no-std: false
-            build-futures: true
-            build-tx-sync: false
-          - toolchain: 1.47.0
+          - toolchain: 1.48.0
             build-futures: true
             build-no-std: true
             build-tx-sync: false