]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Fix outdated PendingOutboundPayment::Abandoned docs
authorValentine Wallace <vwallace@protonmail.com>
Sun, 12 Feb 2023 00:35:48 +0000 (19:35 -0500)
committerValentine Wallace <vwallace@protonmail.com>
Thu, 23 Feb 2023 20:50:25 +0000 (15:50 -0500)
lightning/src/ln/outbound_payment.rs

index a28169032d632262870b5218844b7688fcfd1bde..e1c5fa547f8ede6903c010c7c8fe846bfa45bf08 100644 (file)
@@ -64,13 +64,8 @@ pub(crate) enum PendingOutboundPayment {
                payment_hash: Option<PaymentHash>,
                timer_ticks_without_htlcs: u8,
        },
-       /// When a payer gives up trying to retry a payment, they inform us, letting us generate a
-       /// `PaymentFailed` event when all HTLCs have irrevocably failed. This avoids a number of race
-       /// conditions in MPP-aware payment retriers (1), where the possibility of multiple
-       /// `PaymentPathFailed` events with `all_paths_failed` can be pending at once, confusing a
-       /// downstream event handler as to when a payment has actually failed.
-       ///
-       /// (1) <https://github.com/lightningdevkit/rust-lightning/issues/1164>
+       /// When we've decided to give up retrying a payment, we mark it as abandoned so we can eventually
+       /// generate a `PaymentFailed` event when all HTLCs have irrevocably failed.
        Abandoned {
                session_privs: HashSet<[u8; 32]>,
                payment_hash: PaymentHash,