]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Remove done TODO
authorElias Rohrer <ero@tnull.de>
Mon, 26 Sep 2022 09:20:50 +0000 (11:20 +0200)
committerElias Rohrer <ero@tnull.de>
Mon, 26 Sep 2022 09:20:50 +0000 (11:20 +0200)
The migration to `LockTime` was already done in
7e05623befc111422d1d4230f4e51629566a2ae6, which however did not also
remove the TODO.

lightning/src/ln/channelmanager.rs

index 72f1f4d596f80597736ec1bb59e9b27673eddf96..8c12f5470b9ca0fd36f2e5410efeece305c99d71 100644 (file)
@@ -2935,7 +2935,6 @@ impl<Signer: Sign, M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelMana
                        // Transactions are evaluated as final by network mempools at the next block. However, the modules
                        // constituting our Lightning node might not have perfect sync about their blockchain views. Thus, if
                        // the wallet module is in advance on the LDK view, allow one more block of headroom.
-                       // TODO: updated if/when https://github.com/rust-bitcoin/rust-bitcoin/pull/994 landed and rust-bitcoin bumped.
                        if !funding_transaction.input.iter().all(|input| input.sequence == Sequence::MAX) && LockTime::from(funding_transaction.lock_time).is_block_height() && funding_transaction.lock_time.0 > height + 2 {
                                return Err(APIError::APIMisuseError {
                                        err: "Funding transaction absolute timelock is non-final".to_owned()