Simplify test setup

diff --git a/test/helper.py b/test/helper.py
index 884cf32dc2b8c0246744df57e64b2b60a5fcde94..ad1b74dd30c140b01d8c9a4c51513cb2e3b8997f 100644 (file)
--- a/test/helper.py
+++ b/test/helper.py
@@ -12,12 +12,7 @@ from youtube_dl.utils import (
     compat_urllib_request,
 )
 
-# General configuration (from __init__, not very elegant...)
-jar = compat_cookiejar.CookieJar()
-cookie_processor = compat_urllib_request.HTTPCookieProcessor(jar)
-proxy_handler = compat_urllib_request.ProxyHandler()
-opener = compat_urllib_request.build_opener(proxy_handler, cookie_processor, YoutubeDLHandler())
-compat_urllib_request.install_opener(opener)
+youtube_dl._setup_opener(timeout=10)
 
 PARAMETERS_FILE = os.path.join(os.path.dirname(os.path.abspath(__file__)), "parameters.json")
 with io.open(PARAMETERS_FILE, encoding='utf-8') as pf:

diff --git a/test/test_download.py b/test/test_download.py
index 23d3853c4d10706c379eb5ee2ed69b46c33d7584..fdf59bb5c6af88bc0ee8dcbcbb4bc72b383b7968 100644 (file)
--- a/test/test_download.py
+++ b/test/test_download.py
@@ -19,14 +19,6 @@ PARAMETERS_FILE = os.path.join(os.path.dirname(os.path.abspath(__file__)), "para
 
 RETRIES = 3
 
-# General configuration (from __init__, not very elegant...)
-jar = compat_cookiejar.CookieJar()
-cookie_processor = compat_urllib_request.HTTPCookieProcessor(jar)
-proxy_handler = compat_urllib_request.ProxyHandler()
-opener = compat_urllib_request.build_opener(proxy_handler, cookie_processor, YoutubeDLHandler())
-compat_urllib_request.install_opener(opener)
-socket.setdefaulttimeout(10)
-
 md5 = lambda s: hashlib.md5(s.encode('utf-8')).hexdigest()
 
 class YoutubeDL(youtube_dl.YoutubeDL):
@@ -45,6 +37,7 @@ def _file_md5(fn):
     with open(fn, 'rb') as f:
         return hashlib.md5(f.read()).hexdigest()
 
+import helper  # Set up remaining global configuration
 from helper import get_testcases, try_rm
 defs = get_testcases()