]> git.bitcoin.ninja Git - youtube-dl/commitdiff
[utils] Clarify for redirecting STDIN in get_exe_version()
authorYen Chi Hsuan <yan12125@gmail.com>
Sat, 22 Oct 2016 05:04:05 +0000 (13:04 +0800)
committerYen Chi Hsuan <yan12125@gmail.com>
Sat, 22 Oct 2016 05:04:05 +0000 (13:04 +0800)
youtube_dl/utils.py

index a89ff6908b3bfe2f42488b63ba2515d48e15f4da..2770c5f1c5ee55ea4708ce8cbfc3a0e249a2b23d 100644 (file)
@@ -1818,6 +1818,9 @@ def get_exe_version(exe, args=['--version'],
     """ Returns the version of the specified executable,
     or False if the executable is not present """
     try:
+        # STDIN should be redirected too. On UNIX-like systems, ffmpeg triggers
+        # SIGTTOU if youtube-dl is run in the background.
+        # See https://github.com/rg3/youtube-dl/issues/955#issuecomment-209789656
         out, _ = subprocess.Popen(
             [encodeArgument(exe)] + args,
             stdin=subprocess.PIPE,