]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Pin memchr in our release dependency list due to `core2` using it 2023-09-msrv
authorMatt Corallo <git@bluematt.me>
Thu, 14 Sep 2023 21:49:14 +0000 (21:49 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 15 Sep 2023 17:07:17 +0000 (17:07 +0000)
We're working with rust-bitcoin to remove the `core2` dependency
at https://github.com/rust-bitcoin/rust-bitcoin/pull/2066 but until
that lands and we can upgrade rust-bitcoin we're stuck with it. In
the mean time, we should still pass our MSRV tests.

ci/ci-tests.sh

index 74ba5a7da71d268e473eab0a34bcebbd43727db9..7b925cc8544eca2a077ab7a5b3aa9f2af27c3398 100755 (executable)
@@ -123,6 +123,10 @@ if [[ $RUSTC_MINOR_VERSION -gt 67 ]]; then
        # lightning-transaction-sync's MSRV is 1.67
        cargo check --verbose --color always --features lightning-transaction-sync
 else
+       # The memchr crate switched to an MSRV of 1.60 starting with v2.6.0
+       # This is currently only a release dependency via core2, which we intend to work with
+       # rust-bitcoin to remove soon.
+       [ "$RUSTC_MINOR_VERSION" -lt 60 ] && cargo update -p memchr --precise "2.5.0" --verbose
        cargo check --verbose --color always
 fi
 popd