]> git.bitcoin.ninja Git - youtube-dl/commitdiff
New test-case: extractor names are supposed to be unique
authorMatthieu Muffato <cortexspam-github@yahoo.fr>
Sun, 26 Jun 2016 22:31:55 +0000 (23:31 +0100)
committerSergey M․ <dstftw@gmail.com>
Mon, 27 Jun 2016 15:09:29 +0000 (22:09 +0700)
@dstftw explained in
https://github.com/rg3/youtube-dl/pull/9918#issuecomment-228625878 that
extractor names are supposed to be unique. @dstftw has fixed the two
offending extractors, and here I add a test to ensure this does not
happen in the future.

test/test_all_urls.py

index f5af184e6e0a79ccc11a9a66c2a9f19434087108..133d438eb28dbc3117de047dea95463065d9ef70 100644 (file)
@@ -6,6 +6,7 @@ from __future__ import unicode_literals
 import os
 import sys
 import unittest
+import collections
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 
@@ -130,6 +131,13 @@ class TestAllURLsMatching(unittest.TestCase):
             'https://screen.yahoo.com/smartwatches-latest-wearable-gadgets-163745379-cbs.html',
             ['Yahoo'])
 
+    def test_no_duplicated_ie_names(self):
+        name_accu = collections.defaultdict(list)
+        for ie in self.ies:
+            name_accu[ie.IE_NAME.lower()].append(ie)
+        for (ie_name,ie_list) in name_accu.items():
+            self.assertEqual(len(ie_list), 1, 'Only 1 extractor with IE_NAME "%s" (%s)' % (ie_name, ie_list))
+
 
 if __name__ == '__main__':
     unittest.main()