]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Add ShutdownScript for BOLT 2 acceptable scripts
authorJeffrey Czyz <jkczyz@gmail.com>
Thu, 22 Jul 2021 01:12:14 +0000 (20:12 -0500)
committerJeffrey Czyz <jkczyz@gmail.com>
Mon, 9 Aug 2021 20:55:25 +0000 (15:55 -0500)
BOLT 2 enumerates the script formats that may be used for a shutdown
script. KeysInterface::get_shutdown_pubkey returns a PublicKey used to
form one of the acceptable formats (P2WPKH). Add a ShutdownScript
abstraction to encapsulate all accept formats and be backwards
compatible with P2WPKH scripts serialized as the corresponding
PublicKey.

lightning/src/ln/mod.rs
lightning/src/ln/script.rs [new file with mode: 0644]

index 7500b93c0050400ae1bba70dd78a819336a5afbd..5f928eea072bb85bc3323defe036499e17079e35 100644 (file)
@@ -27,6 +27,7 @@ pub mod msgs;
 pub mod peer_handler;
 pub mod chan_utils;
 pub mod features;
+pub mod script;
 
 #[cfg(feature = "fuzztarget")]
 pub mod peer_channel_encryptor;
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
new file mode 100644 (file)
index 0000000..b6fcdbd
--- /dev/null
@@ -0,0 +1,268 @@
+//! Abstractions for scripts used in the Lightning Network.
+
+use bitcoin::blockdata::opcodes::all::OP_PUSHBYTES_0 as SEGWIT_V0;
+use bitcoin::blockdata::script::{Builder, Script};
+use bitcoin::hashes::Hash;
+use bitcoin::hash_types::{PubkeyHash, ScriptHash, WPubkeyHash, WScriptHash};
+use bitcoin::secp256k1::key::PublicKey;
+
+use ln::features::InitFeatures;
+
+use core::convert::TryFrom;
+use core::num::NonZeroU8;
+
+/// A script pubkey for shutting down a channel as defined by [BOLT #2].
+///
+/// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
+pub struct ShutdownScript(ShutdownScriptImpl);
+
+/// An error occurring when converting from [`Script`] to [`ShutdownScript`].
+#[derive(Debug)]
+pub struct InvalidShutdownScript {
+       /// The script that did not meet the requirements from [BOLT #2].
+       ///
+       /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
+       pub script: Script
+}
+
+enum ShutdownScriptImpl {
+       /// [`PublicKey`] used to form a P2WPKH script pubkey. Used to support backward-compatible
+       /// serialization.
+       Legacy(PublicKey),
+
+       /// [`Script`] adhering to a script pubkey format specified in BOLT #2.
+       Bolt2(Script),
+}
+
+impl ShutdownScript {
+       /// Generates a P2WPKH script pubkey from the given [`PublicKey`].
+       pub fn new_p2wpkh_from_pubkey(pubkey: PublicKey) -> Self {
+               Self(ShutdownScriptImpl::Legacy(pubkey))
+       }
+
+       /// Generates a P2PKH script pubkey from the given [`PubkeyHash`].
+       pub fn new_p2pkh(pubkey_hash: &PubkeyHash) -> Self {
+               Self(ShutdownScriptImpl::Bolt2(Script::new_p2pkh(pubkey_hash)))
+       }
+
+       /// Generates a P2SH script pubkey from the given [`ScriptHash`].
+       pub fn new_p2sh(script_hash: &ScriptHash) -> Self {
+               Self(ShutdownScriptImpl::Bolt2(Script::new_p2sh(script_hash)))
+       }
+
+       /// Generates a P2WPKH script pubkey from the given [`WPubkeyHash`].
+       pub fn new_p2wpkh(pubkey_hash: &WPubkeyHash) -> Self {
+               Self(ShutdownScriptImpl::Bolt2(Script::new_v0_wpkh(pubkey_hash)))
+       }
+
+       /// Generates a P2WSH script pubkey from the given [`WScriptHash`].
+       pub fn new_p2wsh(script_hash: &WScriptHash) -> Self {
+               Self(ShutdownScriptImpl::Bolt2(Script::new_v0_wsh(script_hash)))
+       }
+
+       /// Generates a P2WSH script pubkey from the given segwit version and program.
+       ///
+       /// # Errors
+       ///
+       /// This function may return an error if `program` is invalid for the segwit `version`.
+       pub fn new_witness_program(version: NonZeroU8, program: &[u8]) -> Result<Self, InvalidShutdownScript> {
+               let script = Builder::new()
+                       .push_int(version.get().into())
+                       .push_slice(&program)
+                       .into_script();
+               Self::try_from(script)
+       }
+
+       /// Converts the shutdown script into the underlying [`Script`].
+       pub fn into_inner(self) -> Script {
+               self.into()
+       }
+
+       /// Returns the [`PublicKey`] used for a P2WPKH shutdown script if constructed directly from it.
+       pub fn as_legacy_pubkey(&self) -> Option<&PublicKey> {
+               match &self.0 {
+                       ShutdownScriptImpl::Legacy(pubkey) => Some(pubkey),
+                       ShutdownScriptImpl::Bolt2(_) => None,
+               }
+       }
+
+       /// Returns whether the shutdown script is compatible with the features as defined by BOLT #2.
+       ///
+       /// Specifically, checks for compliance with feature `option_shutdown_anysegwit`.
+       pub fn is_compatible(&self, features: &InitFeatures) -> bool {
+               match &self.0 {
+                       ShutdownScriptImpl::Legacy(_) => true,
+                       ShutdownScriptImpl::Bolt2(script) => is_bolt2_compliant(script, features),
+               }
+       }
+}
+
+fn is_bolt2_compliant(script: &Script, features: &InitFeatures) -> bool {
+       if script.is_p2pkh() || script.is_p2sh() || script.is_v0_p2wpkh() || script.is_v0_p2wsh() {
+               true
+       } else if features.supports_shutdown_anysegwit() {
+               script.is_witness_program() && script.as_bytes()[0] != SEGWIT_V0.into_u8()
+       } else {
+               false
+       }
+}
+
+impl TryFrom<Script> for ShutdownScript {
+       type Error = InvalidShutdownScript;
+
+       fn try_from(script: Script) -> Result<Self, Self::Error> {
+               Self::try_from((script, &InitFeatures::known()))
+       }
+}
+
+impl TryFrom<(Script, &InitFeatures)> for ShutdownScript {
+       type Error = InvalidShutdownScript;
+
+       fn try_from((script, features): (Script, &InitFeatures)) -> Result<Self, Self::Error> {
+               if is_bolt2_compliant(&script, features) {
+                       Ok(Self(ShutdownScriptImpl::Bolt2(script)))
+               } else {
+                       Err(InvalidShutdownScript { script })
+               }
+       }
+}
+
+impl Into<Script> for ShutdownScript {
+       fn into(self) -> Script {
+               match self.0 {
+                       ShutdownScriptImpl::Legacy(pubkey) =>
+                               Script::new_v0_wpkh(&WPubkeyHash::hash(&pubkey.serialize())),
+                       ShutdownScriptImpl::Bolt2(script_pubkey) => script_pubkey,
+               }
+       }
+}
+
+#[cfg(test)]
+mod shutdown_script_tests {
+       use super::ShutdownScript;
+       use bitcoin::bech32::u5;
+       use bitcoin::blockdata::opcodes;
+       use bitcoin::blockdata::script::{Builder, Script};
+       use bitcoin::secp256k1::Secp256k1;
+       use bitcoin::secp256k1::key::{PublicKey, SecretKey};
+       use ln::features::InitFeatures;
+       use core::convert::TryFrom;
+       use core::num::NonZeroU8;
+
+       fn pubkey() -> bitcoin::util::ecdsa::PublicKey {
+               let secp_ctx = Secp256k1::signing_only();
+               let secret_key = SecretKey::from_slice(&[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]).unwrap();
+               bitcoin::util::ecdsa::PublicKey::new(PublicKey::from_secret_key(&secp_ctx, &secret_key))
+       }
+
+       fn redeem_script() -> Script {
+               let pubkey = pubkey();
+               Builder::new()
+                       .push_opcode(opcodes::all::OP_PUSHNUM_2)
+                       .push_key(&pubkey)
+                       .push_key(&pubkey)
+                       .push_opcode(opcodes::all::OP_PUSHNUM_2)
+                       .push_opcode(opcodes::all::OP_CHECKMULTISIG)
+                       .into_script()
+       }
+
+       #[test]
+       fn generates_p2wpkh_from_pubkey() {
+               let pubkey = pubkey();
+               let pubkey_hash = pubkey.wpubkey_hash().unwrap();
+               let p2wpkh_script = Script::new_v0_wpkh(&pubkey_hash);
+
+               let shutdown_script = ShutdownScript::new_p2wpkh_from_pubkey(pubkey.key);
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), p2wpkh_script);
+       }
+
+       #[test]
+       fn generates_p2pkh_from_pubkey_hash() {
+               let pubkey_hash = pubkey().pubkey_hash();
+               let p2pkh_script = Script::new_p2pkh(&pubkey_hash);
+
+               let shutdown_script = ShutdownScript::new_p2pkh(&pubkey_hash);
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), p2pkh_script);
+               assert!(ShutdownScript::try_from(p2pkh_script).is_ok());
+       }
+
+       #[test]
+       fn generates_p2sh_from_script_hash() {
+               let script_hash = redeem_script().script_hash();
+               let p2sh_script = Script::new_p2sh(&script_hash);
+
+               let shutdown_script = ShutdownScript::new_p2sh(&script_hash);
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), p2sh_script);
+               assert!(ShutdownScript::try_from(p2sh_script).is_ok());
+       }
+
+       #[test]
+       fn generates_p2wpkh_from_pubkey_hash() {
+               let pubkey_hash = pubkey().wpubkey_hash().unwrap();
+               let p2wpkh_script = Script::new_v0_wpkh(&pubkey_hash);
+
+               let shutdown_script = ShutdownScript::new_p2wpkh(&pubkey_hash);
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), p2wpkh_script);
+               assert!(ShutdownScript::try_from(p2wpkh_script).is_ok());
+       }
+
+       #[test]
+       fn generates_p2wsh_from_script_hash() {
+               let script_hash = redeem_script().wscript_hash();
+               let p2wsh_script = Script::new_v0_wsh(&script_hash);
+
+               let shutdown_script = ShutdownScript::new_p2wsh(&script_hash);
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), p2wsh_script);
+               assert!(ShutdownScript::try_from(p2wsh_script).is_ok());
+       }
+
+       #[test]
+       fn generates_segwit_from_non_v0_witness_program() {
+               let version = u5::try_from_u8(16).unwrap();
+               let witness_program = Script::new_witness_program(version, &[0; 40]);
+
+               let version = NonZeroU8::new(version.to_u8()).unwrap();
+               let shutdown_script = ShutdownScript::new_witness_program(version, &[0; 40]).unwrap();
+               assert!(shutdown_script.is_compatible(&InitFeatures::known()));
+               assert!(!shutdown_script.is_compatible(&InitFeatures::known().clear_shutdown_anysegwit()));
+               assert_eq!(shutdown_script.into_inner(), witness_program);
+       }
+
+       #[test]
+       fn fails_from_unsupported_script() {
+               let op_return = Script::new_op_return(&[0; 42]);
+               assert!(ShutdownScript::try_from(op_return).is_err());
+       }
+
+       #[test]
+       fn fails_from_invalid_segwit_version() {
+               let version = NonZeroU8::new(17).unwrap();
+               assert!(ShutdownScript::new_witness_program(version, &[0; 40]).is_err());
+       }
+
+       #[test]
+       fn fails_from_invalid_segwit_v0_witness_program() {
+               let witness_program = Script::new_witness_program(u5::try_from_u8(0).unwrap(), &[0; 2]);
+               assert!(ShutdownScript::try_from(witness_program).is_err());
+       }
+
+       #[test]
+       fn fails_from_invalid_segwit_non_v0_witness_program() {
+               let version = u5::try_from_u8(16).unwrap();
+               let witness_program = Script::new_witness_program(version, &[0; 42]);
+               assert!(ShutdownScript::try_from(witness_program).is_err());
+
+               let version = NonZeroU8::new(version.to_u8()).unwrap();
+               assert!(ShutdownScript::new_witness_program(version, &[0; 42]).is_err());
+       }
+}