From: Arik Sosman <git@arik.io>
Date: Wed, 29 Nov 2023 00:11:15 +0000 (-0800)
Subject: Remove superfluous commitment_number parameter.
X-Git-Tag: v0.0.119~39^2~2
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=007e6788f5a6219ed9c034d4746ccef5030e21e8;p=rust-lightning

Remove superfluous commitment_number parameter.
---

diff --git a/lightning/src/sign/mod.rs b/lightning/src/sign/mod.rs
index d8f71f590..65457d27d 100644
--- a/lightning/src/sign/mod.rs
+++ b/lightning/src/sign/mod.rs
@@ -1258,7 +1258,7 @@ impl TaprootChannelSigner for InMemorySigner {
 		todo!()
 	}
 
-	fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
+	fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
 		todo!()
 	}
 
diff --git a/lightning/src/sign/taproot.rs b/lightning/src/sign/taproot.rs
index 0028a0cd1..f2d3f6283 100644
--- a/lightning/src/sign/taproot.rs
+++ b/lightning/src/sign/taproot.rs
@@ -51,8 +51,7 @@ pub trait TaprootChannelSigner: ChannelSigner {
 	/// An external signer implementation should check that the commitment has not been revoked.
 	///
 	// TODO: Document the things someone using this interface should enforce before signing.
-	fn finalize_holder_commitment(&self, commitment_number: u64,
-		commitment_tx: &HolderCommitmentTransaction,
+	fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction,
 		counterparty_partial_signature: PartialSignatureWithNonce,
 		secp_ctx: &Secp256k1<secp256k1::All>
 	) -> Result<PartialSignature, ()>;
diff --git a/lightning/src/util/test_channel_signer.rs b/lightning/src/util/test_channel_signer.rs
index ccdcfdd09..0e3890f54 100644
--- a/lightning/src/util/test_channel_signer.rs
+++ b/lightning/src/util/test_channel_signer.rs
@@ -292,7 +292,7 @@ impl TaprootChannelSigner for TestChannelSigner {
 		todo!()
 	}
 
-	fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
+	fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
 		todo!()
 	}