From: Matt Corallo Date: Fri, 29 Sep 2023 02:50:27 +0000 (+0000) Subject: Add 0.0.117 release notes X-Git-Tag: v0.0.117~1^2~1 X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=3133286c886c05809c7fe83a562e26ebd7a15f7c;p=rust-lightning Add 0.0.117 release notes --- diff --git a/CHANGELOG.md b/CHANGELOG.md index 5eff3eb09..a050afb72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,150 @@ +# 0.0.117 - XXX - "Everything but the Twelve Sinks" + +## API Updates + * `ProbabilisticScorer`'s internal models have been substantially improved, + including better decaying (#1789), a more granular historical channel + liquidity tracker (#2176) and a now-default option to make our estimate for a + channel's current liquidity nonlinear in the channel's capacity (#2547). In + total, these changes should result in improved payment success rates at the + cost of slightly worse routefinding performance. + * Support for custom TLVs for recipients of HTLCs has been added (#2308). + * Support for generating transactions for third-party watchtowers has been + added to `ChannelMonitor/Update`s (#2337). + * `KVStorePersister` has been replaced with a more generic and featureful + `KVStore` interface (#2472). + * A new `MonitorUpdatingPersister` is provided which wraps a `KVStore` and + implements `Persist` by writing differential updates rather than full + `ChannelMonitor`s (#2359). + * Batch funding of outbound channels is now supported using the new + `ChannelManager::batch_funding_transaction_generated` method (#2486). + * `ChannelManager::send_preflight_probes` has been added to probe a payment's + potential paths while a user is providing approval for a payment (#2534). + * Fully asynchronous `ChannelMonitor` updating is available as an alpha + preview. There remain a few known but incredibly rare race conditions which + may lead to loss of funds (#2112, #2169, #2562). + * `ChannelMonitorUpdateStatus::PermanentFailure` has been removed in favor of a + new `ChannelMonitorUpdateStatus::UnrecoverableError`. The new variant panics + on use, rather than force-closing a channel in an unsafe manner, which the + previous variant did (#2562). Rather than panicking with the new variant, + users may wish to use the new asynchronous `ChannelMonitor` updating using + `ChannelMonitorUpdateStatus::InProgress`. + * `RouteParameters::max_total_routing_fee_msat` was added to limit the fees + paid when routing, defaulting to 1% + 50sats when using the new + `from_payment_params_and_value` constructor (#2417, #2603, #2604). + * Implementations of `UtxoSource` are now provided in `lightning-block-sync`. + Those running with a full node should use this to validate gossip (#2248). + * `LockableScore` now supports read locking for parallel routefinding (#2197). + * `ChannelMonitor::get_spendable_outputs` was added to allow for re-generation + of `SpendableOutputDescriptor`s for a channel after they were provided via + `Event::SpendableOutputs` (#2609, #2624). + * `[u8; 32]` has been replaced with a `ChannelId` newtype for chan ids (#2485). + * `NetAddress` was renamed `SocketAddress` (#2549) and `FromStr` impl'd (#2134) + * For `no-std` users, `parse_onion_address` was added which creates a + `NetAddress` from a "...onion" string and port (#2134, #2633). + * HTLC information is now provided in `Event::PaymentClaimed::htlcs` (#2478). + * The success probability used in historical penalties when scoring is now + available via `historical_estimated_payment_success_probability` (#2466). + * `RecentPaymentDetails::*::payment_id` has been added (#2567). + * `Route` now contains a `RouteParameters` rather than a `PaymentParameters`, + tracking the original arguments passed to routefinding (#2555). + * `Balance::*::claimable_amount_satoshis` was renamed `amount_satoshis` (#2460) + * `*Features::set_*_feature_bit` have been added for non-custom flags (#2522). + * `channel_id` was added to `SpendableOutputs` events (#2511). + * `counterparty_node_id` and `channel_capacity_sats` were added to + `ChannelClosed` events (#2387). + * `ChannelMonitor` now implements `Clone` for `Clone`able signers (#2448). + * `create_onion_message` was added to build an onion message (#2583, #2595). + * `HTLCDescriptor` now implements `Writeable`/`Readable` (#2571). + * `SpendableOutputDescriptor` now implements `Hash` (#2602). + * `MonitorUpdateId` now implements `Debug` (#2594). + * `Payment{Hash,Id,Preimage}` now implement `Display` (#2492). + * `NodeSigner::sign_bolt12_invoice{,request}` were added for future use (#2432) + +## Backwards Compatibility + * Users migrating to the new `KVStore` can use a concatentation of + `[{primary_namespace}/[{secondary_namespace}/]]{key}` to build a key + compatible with the previous `KVStorePersister` interface (#2472). + * Downgrading after receipt of a payment with custom HTLC TLVs may result in + unintentionally accepting payments with TLVs you do not understand (#2308). + * `Route` objects (including pending payments) written by LDK versions prior + to 0.0.117 won't be retryable after being deserialized by LDK 0.0.117 or + above (#2555). + * Users of the `MonitorUpdatingPersister` can upgrade seamlessly from the + default `KVStore` `Persist` implementation, however the stored + `ChannelMonitor`s are deliberately unreadable by the default `Persist`. This + ensures the correct downgrade procedure is followed, which is: (#2359) + * First, make a backup copy of all channel state, + * then ensure all `ChannelMonitorUpdate`s stored are fully applied to the + relevant `ChannelMonitor`, + * finally, write each full `ChannelMonitor` using your new `Persist` impl. + +## Bug Fixes + * Anchor channels which were closed by a counterparty broadcasting its + commitment transaction (i.e. force-closing) would previously not generate a + `SpendableOutputs` event for our `to_remote` (i.e. non-HTLC-encumbered) + balance. Those with such balances available should fetch the missing + `SpendableOutputDescriptor`s using the new + `ChannelMonitor::get_spendable_outputs` method (#2605). + * Anchor channels may result in spurious or missing `Balance` entries for HTLC + balances (#2610). + * `ChannelManager::send_spontaneous_payment_with_retry` spuriously did not + provide the recipient with enough information to claim the payment, leading + to all spontaneous payments failing (#2475). + `send_spontaneous_payment_with_route` was unaffected. + * The `keysend` feature on node announcements was spuriously un-set in 0.0.112 + and has been re-enabled (#2465). + * Fixed several races which could lead to deadlock when force-closing a channel + (#2597). These races have not been seen in production. + * The `ChannelManager` is persisted substantially less when it has not changed, + leading to substantially less I/O traffic for it (#2521, #2617). + * Passing new block data to `ChainMonitor` no longer results in all other + monitor operations being blocked until it completes (#2528). + * When retrying payments, any excess amount sent to the recipient in order to + meet an `htlc_minimum` constraint on the path is now no longer included in + the amount we send in the retry (#2575). + * Several edge cases in route-finding around HTLC minimums were fixed which + could have caused invalid routes or panics when built with debug assertions + (#2570, #2575). + * Several edge cases in route-finding around HTLC minimums and route hints + were fixed which would spuriously result in no route found (#2575, #2604). + * The `user_channel_id` passed to `SignerProvider::generate_channel_keys_id` + for inbound channels is now correctly using the one passed to + `ChannelManager::accept_inbound_channel` rather than a default value (#2428). + * Users of `impl_writeable_tlv_based!` no longer have use requirements (#2506). + * No longer force-close channels when counterparties send a `channel_update` + with a bogus `htlc_minimum_msat`, which LND users can manually build (#2611). + +## Node Compatibility + * LDK now ignores `error` messages generated by LND in response to a + `shutdown` message, avoiding force-closes due to LND bug 6039. This may + lead to non-trivial bandwidth usage with LND peers exhibiting this bug + during the cooperative shutdown process (#2507). + +## Security +0.0.117 fixes several loss-of-funds vulnerabilities in anchor output channels, +support for which was added in 0.0.116, in reorg handling, and when accepting +channel(s) from counterparties which are miners. + * When a counterparty broadcasts their latest commitment transaction for a + channel with anchor outputs, we'd previously fail to build claiming + transactions against any HTLC outputs in that transaction. This could lead + to loss of funds if the counterparty is able to eventually claim the HTLC + after a timeout (#2606). + * Anchor channels HTLC claims on-chain previously spent the entire value of any + HTLCs as fee, which has now been fixed (#2587). + * If a channel is closed via an on-chain commitment transaction confirmation + with a pending outbound HTLC in the commitment transaction, followed by a + reorg which replaces the confirmed commitment transaction with a different + (but non-revoked) commitment transaction, all before we learn the payment + preimage for this HTLC, we may previously have not generated a proper + claiming transaction for the HTLC's value (#2623). + * 0.0.117 now correctly handles channels for which our counterparty funded the + channel with a coinbase transaction. As such transactions are not spendable + until they've reached 100 confirmations, this could have resulted in + accepting HTLC(s) which are not enforcible on-chain (#1924). + +up to date as of 620244dc2ec3153a61e009b80a8c59cf41514482 +XXX: add diff statas + # 0.0.116 - Jul 21, 2023 - "Anchoring the Roadmap" ## API Updates diff --git a/pending_changelog/custom_tlv_downgrade.txt b/pending_changelog/custom_tlv_downgrade.txt deleted file mode 100644 index 54a36ca28..000000000 --- a/pending_changelog/custom_tlv_downgrade.txt +++ /dev/null @@ -1,3 +0,0 @@ -## Backwards Compatibility - -* Since the addition of custom HTLC TLV support in 0.0.117, if you downgrade you may unintentionally accept payments with features you don't understand. diff --git a/pending_changelog/kvstore.txt b/pending_changelog/kvstore.txt deleted file mode 100644 index 3fe949500..000000000 --- a/pending_changelog/kvstore.txt +++ /dev/null @@ -1,3 +0,0 @@ -## Backwards Compatibility - -* Users migrating custom persistence backends from the pre-v0.0.117 `KVStorePersister` interface can use a concatenation of `[{primary_namespace}/[{secondary_namespace}/]]{key}` to recover a `key` compatible with the data model previously assumed by `KVStorePersister::persist`. diff --git a/pending_changelog/monitorupdatingpersister.txt b/pending_changelog/monitorupdatingpersister.txt deleted file mode 100644 index 24d63ffe5..000000000 --- a/pending_changelog/monitorupdatingpersister.txt +++ /dev/null @@ -1,5 +0,0 @@ -## Backwards Compatibility - -* The `MonitorUpdatingPersister` can read monitors stored conventionally, such as with the `KVStorePersister` from previous LDK versions. You can use this to migrate _to_ the `MonitorUpdatingPersister`; just "point" `MonitorUpdatingPersister` to existing, fully updated `ChannelMonitors`, and it will read them and work from there. However, downgrading is more complex. Monitors stored with `MonitorUpdatingPersister` have a prepended sentinel value that prevents them from being deserialized by previous `Persist` implementations. This is to ensure that they are not accidentally read and used while pending updates are still stored and not applied, as this could result in penalty transactions. Users who wish to downgrade should perform the following steps: - * Make a backup copy of all channel state. - * Ensure all updates are applied to the monitors. This may be done by loading all the existing data with the `MonitorUpdatingPersister::read_all_channel_monitors_with_updates` function. You can then write the resulting `ChannelMonitor`s using your previous `Persist` implementation. \ No newline at end of file diff --git a/pending_changelog/move_netaddress_to_socketaddress.txt b/pending_changelog/move_netaddress_to_socketaddress.txt deleted file mode 100644 index 5153ed1d0..000000000 --- a/pending_changelog/move_netaddress_to_socketaddress.txt +++ /dev/null @@ -1 +0,0 @@ -* The `NetAddress` has been moved to `SocketAddress`. The fieds `IPv4` and `IPv6` are also rename to `TcpIpV4` and `TcpIpV6` (#2358). diff --git a/pending_changelog/new_channel_id_type_pr_2485.txt b/pending_changelog/new_channel_id_type_pr_2485.txt deleted file mode 100644 index 4ae3c2c62..000000000 --- a/pending_changelog/new_channel_id_type_pr_2485.txt +++ /dev/null @@ -1 +0,0 @@ -* In several APIs, `channel_id` parameters have been changed from type `[u8; 32]` to newly introduced `ChannelId` type, from `ln` namespace (`lightning::ln::ChannelId`) (PR #2485) diff --git a/pending_changelog/routes_route_params.txt b/pending_changelog/routes_route_params.txt deleted file mode 100644 index e88a1c781..000000000 --- a/pending_changelog/routes_route_params.txt +++ /dev/null @@ -1,3 +0,0 @@ -# Backwards Compatibility - -- `Route` objects written with LDK versions prior to 0.0.117 won't be retryable after being deserialized with LDK 0.0.117 or above.