From: Matt Corallo <git@bluematt.me>
Date: Wed, 19 Jul 2023 20:09:23 +0000 (+0000)
Subject: Mark several types no-export which should be exported eventually
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=3149fe03d4ade8cae351edd950784741c9c78bd9;p=rust-lightning

Mark several types no-export which should be exported eventually
---

diff --git a/lightning/src/events/bump_transaction.rs b/lightning/src/events/bump_transaction.rs
index 5963da8e9..02f651c34 100644
--- a/lightning/src/events/bump_transaction.rs
+++ b/lightning/src/events/bump_transaction.rs
@@ -392,6 +392,8 @@ impl Utxo {
 	}
 
 	/// Returns a `Utxo` with the `satisfaction_weight` estimate for a P2WPKH nested in P2SH output.
+	///
+	/// This is not exported to bindings users as WPubkeyHash is not yet exported
 	pub fn new_nested_p2wpkh(outpoint: OutPoint, value: u64, pubkey_hash: &WPubkeyHash) -> Self {
 		let script_sig_size = 1 /* script_sig length */ +
 			1 /* OP_0 */ +
@@ -408,6 +410,8 @@ impl Utxo {
 	}
 
 	/// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v0 P2WPKH output.
+	///
+	/// This is not exported to bindings users as WPubkeyHash is not yet exported
 	pub fn new_v0_p2wpkh(outpoint: OutPoint, value: u64, pubkey_hash: &WPubkeyHash) -> Self {
 		Self {
 			outpoint,
diff --git a/lightning/src/ln/features.rs b/lightning/src/ln/features.rs
index 5de383b1f..e003d9402 100644
--- a/lightning/src/ln/features.rs
+++ b/lightning/src/ln/features.rs
@@ -432,6 +432,7 @@ pub struct Features<T: sealed::Context> {
 	mark: PhantomData<T>,
 }
 
+/// This is not exported to bindings users but probably should be.
 impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Features<T> {
 	fn bitor_assign(&mut self, rhs: Rhs) {
 		let total_feature_len = cmp::max(self.flags.len(), rhs.borrow().flags.len());
@@ -442,6 +443,7 @@ impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Feat
 	}
 }
 
+/// This is not exported to bindings users but probably should be.
 impl<T: sealed::Context> core::ops::BitOr for Features<T> {
 	type Output = Self;
 
diff --git a/lightning/src/offers/invoice.rs b/lightning/src/offers/invoice.rs
index 3681f4424..5b898ee69 100644
--- a/lightning/src/offers/invoice.rs
+++ b/lightning/src/offers/invoice.rs
@@ -586,6 +586,8 @@ impl Bolt12Invoice {
 	}
 
 	/// Signature of the invoice verified using [`Bolt12Invoice::signing_pubkey`].
+	///
+	/// This is not exported to bindings users as Signature is not yet mapped.
 	pub fn signature(&self) -> Signature {
 		self.signature
 	}
diff --git a/lightning/src/sign/mod.rs b/lightning/src/sign/mod.rs
index a71bdae88..bc8c305df 100644
--- a/lightning/src/sign/mod.rs
+++ b/lightning/src/sign/mod.rs
@@ -225,6 +225,8 @@ impl SpendableOutputDescriptor {
 	///
 	/// Note that this does not include any signatures, just the information required to
 	/// construct the transaction and sign it.
+	///
+	/// This is not exported to bindings users as there is no standard serialization for an input.
 	pub fn to_psbt_input(&self) -> bitcoin::psbt::Input {
 		match self {
 			SpendableOutputDescriptor::StaticOutput { output, .. } => {