From: Wilmer Paulino Date: Fri, 29 Mar 2024 18:50:26 +0000 (-0700) Subject: Reserve async signing related channel TLV types X-Git-Tag: v0.0.123-beta~19^2 X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=70e400182edddfeec886ed6d2d0faa8ede022819;p=rust-lightning Reserve async signing related channel TLV types A LDK user deployed to production a WIP version of the async signing branch in which two new TLVs were added to channel. To prevent them from needing to perform a migration, we can just new types for TLVs that have yet to be included in a release. A note has been added to ensure types 45 and 47 are not used for another purpose. --- diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs index cddd6a5e5..ed8c861d7 100644 --- a/lightning/src/ln/channel.rs +++ b/lightning/src/ln/channel.rs @@ -8726,7 +8726,8 @@ impl Writeable for Channel where SP::Target: SignerProvider { (39, pending_outbound_blinding_points, optional_vec), (41, holding_cell_blinding_points, optional_vec), (43, malformed_htlcs, optional_vec), // Added in 0.0.119 - (45, self.context.local_initiated_shutdown, option), // Added in 0.0.122 + // 45 and 47 are reserved for async signing + (49, self.context.local_initiated_shutdown, option), // Added in 0.0.122 }); Ok(()) @@ -9066,7 +9067,8 @@ impl<'a, 'b, 'c, ES: Deref, SP: Deref> ReadableArgs<(&'a ES, &'b SP, u32, &'c Ch (39, pending_outbound_blinding_points_opt, optional_vec), (41, holding_cell_blinding_points_opt, optional_vec), (43, malformed_htlcs, optional_vec), // Added in 0.0.119 - (45, local_initiated_shutdown, option), + // 45 and 47 are reserved for async signing + (49, local_initiated_shutdown, option), }); let (channel_keys_id, holder_signer) = if let Some(channel_keys_id) = channel_keys_id {