From: Matt Corallo <git@bluematt.me>
Date: Thu, 24 Aug 2023 19:57:45 +0000 (+0000)
Subject: Always persist the `ChannelManager` on a failed ChannelUpdate
X-Git-Tag: v0.0.117-alpha1~15^2~3
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=9078c0dc5c30f7fcd1503cf30237cd3fe87154c0;p=rust-lightning

Always persist the `ChannelManager` on a failed ChannelUpdate

If we receive a `ChannelUpdate` message which was invalid, it can
cause us to force-close the channel, which should result in a
`ChannelManager` persistence, though its not critical to do so.
---

diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 1df6db7db..5e9b53606 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -7668,7 +7668,7 @@ where
 			if let Ok(persist) = handle_error!(self, self.internal_channel_update(counterparty_node_id, msg), *counterparty_node_id) {
 				persist
 			} else {
-				NotifyOption::SkipPersistNoEvents
+				NotifyOption::DoPersist
 			}
 		});
 	}