From: Matt Corallo <git@bluematt.me>
Date: Sun, 28 Jul 2019 00:46:17 +0000 (-0400)
Subject: Drop update_fee TODOs as we're gonna drop it before 0.1 anyway
X-Git-Tag: v0.0.12~195^2~1
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=95dc2762ff4153caff99de14978ab4a965d51687;p=rust-lightning

Drop update_fee TODOs as we're gonna drop it before 0.1 anyway

See #365 for more.
---

diff --git a/src/ln/channel.rs b/src/ln/channel.rs
index e838305ad..9283e9a9f 100644
--- a/src/ln/channel.rs
+++ b/src/ln/channel.rs
@@ -909,8 +909,6 @@ impl Channel {
 		{
 			// Make sure that the to_self/to_remote is always either past the appropriate
 			// channel_reserve *or* it is making progress towards it.
-			// TODO: This should happen after fee calculation, but we don't handle that correctly
-			// yet!
 			let mut max_commitment_tx_output = if generated_by_local {
 				self.max_commitment_tx_output_local.lock().unwrap()
 			} else {
@@ -2452,7 +2450,7 @@ impl Channel {
 				update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
 		msgs::CommitmentUpdate {
 			update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
-			update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
+			update_fee: None,
 			commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
 		}
 	}