From: Yen Chi Hsuan <yan12125@gmail.com>
Date: Sat, 22 Oct 2016 05:04:05 +0000 (+0800)
Subject: [utils] Clarify for redirecting STDIN  in get_exe_version()
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=b64d04c119cd835683b95c13667dbae5db8b939f;p=youtube-dl

[utils] Clarify for redirecting STDIN  in get_exe_version()
---

diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index a89ff6908..2770c5f1c 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -1818,6 +1818,9 @@ def get_exe_version(exe, args=['--version'],
     """ Returns the version of the specified executable,
     or False if the executable is not present """
     try:
+        # STDIN should be redirected too. On UNIX-like systems, ffmpeg triggers
+        # SIGTTOU if youtube-dl is run in the background.
+        # See https://github.com/rg3/youtube-dl/issues/955#issuecomment-209789656
         out, _ = subprocess.Popen(
             [encodeArgument(exe)] + args,
             stdin=subprocess.PIPE,