From: Arik Sosman <git@arik.io>
Date: Tue, 30 Jan 2024 19:43:04 +0000 (-0800)
Subject: Improve error message for invalid response lengths.
X-Git-Tag: v0.0.123-beta~89^2
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=bb9b389be610cff034b76d33d0f34b37d9b5ae6e;p=rust-lightning

Improve error message for invalid response lengths.
---

diff --git a/lightning-block-sync/src/http.rs b/lightning-block-sync/src/http.rs
index 58d66686f..aa0d840ad 100644
--- a/lightning-block-sync/src/http.rs
+++ b/lightning-block-sync/src/http.rs
@@ -288,7 +288,7 @@ impl HttpClient {
 			HttpMessageLength::Empty => { Vec::new() },
 			HttpMessageLength::ContentLength(length) => {
 				if length == 0 || length > MAX_HTTP_MESSAGE_BODY_SIZE {
-					return Err(std::io::Error::new(std::io::ErrorKind::InvalidData, "out of range"))
+					return Err(std::io::Error::new(std::io::ErrorKind::InvalidData, format!("invalid response length: {} bytes", length)));
 				} else {
 					let mut content = vec![0; length];
 					#[cfg(feature = "tokio")]
@@ -727,7 +727,7 @@ pub(crate) mod client_tests {
 		match client.get::<BinaryResponse>("/foo", "foo.com").await {
 			Err(e) => {
 				assert_eq!(e.kind(), std::io::ErrorKind::InvalidData);
-				assert_eq!(e.get_ref().unwrap().to_string(), "out of range");
+				assert_eq!(e.get_ref().unwrap().to_string(), "invalid response length: 8032001 bytes");
 			},
 			Ok(_) => panic!("Expected error"),
 		}