From: Matt Corallo <git@bluematt.me>
Date: Thu, 28 Sep 2023 03:03:38 +0000 (+0000)
Subject: `crate`-only several BOLT12 methods that require unbounded generics
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=c818479b8ec72ee5b838a90b2ce84d2b4c23e180;p=rust-lightning

`crate`-only several BOLT12 methods that require unbounded generics

These are not expressible in C/most languages, and thus must be
hidden.
---

diff --git a/lightning/src/offers/invoice.rs b/lightning/src/offers/invoice.rs
index fb47fd8c5..afbd82f74 100644
--- a/lightning/src/offers/invoice.rs
+++ b/lightning/src/offers/invoice.rs
@@ -424,7 +424,7 @@ impl UnsignedBolt12Invoice {
 	/// Note: The hash computation may have included unknown, odd TLV records.
 	///
 	/// This is not exported to bindings users as functions aren't currently mapped.
-	pub fn sign<F, E>(mut self, sign: F) -> Result<Bolt12Invoice, SignError<E>>
+	pub(crate) fn sign<F, E>(mut self, sign: F) -> Result<Bolt12Invoice, SignError<E>>
 	where
 		F: FnOnce(&Self) -> Result<Signature, E>
 	{
diff --git a/lightning/src/offers/invoice_request.rs b/lightning/src/offers/invoice_request.rs
index bd6d58371..b7f48e2dd 100644
--- a/lightning/src/offers/invoice_request.rs
+++ b/lightning/src/offers/invoice_request.rs
@@ -395,7 +395,7 @@ impl UnsignedInvoiceRequest {
 	/// Note: The hash computation may have included unknown, odd TLV records.
 	///
 	/// This is not exported to bindings users as functions are not yet mapped.
-	pub fn sign<F, E>(mut self, sign: F) -> Result<InvoiceRequest, SignError<E>>
+	pub(crate) fn sign<F, E>(mut self, sign: F) -> Result<InvoiceRequest, SignError<E>>
 	where
 		F: FnOnce(&Self) -> Result<Signature, E>
 	{
diff --git a/lightning/src/offers/merkle.rs b/lightning/src/offers/merkle.rs
index 7390b58fe..395538d71 100644
--- a/lightning/src/offers/merkle.rs
+++ b/lightning/src/offers/merkle.rs
@@ -42,7 +42,7 @@ impl TaggedHash {
 	}
 
 	/// Returns the digest to sign.
-	pub fn as_digest(&self) -> &Message {
+	pub(crate) fn as_digest(&self) -> &Message {
 		&self.0
 	}
 }
@@ -55,7 +55,7 @@ impl AsRef<TaggedHash> for TaggedHash {
 
 /// Error when signing messages.
 #[derive(Debug, PartialEq)]
-pub enum SignError<E> {
+pub(crate) enum SignError<E> {
 	/// User-defined error when signing the message.
 	Signing(E),
 	/// Error when verifying the produced signature using the given pubkey.