From: Yen Chi Hsuan <yan12125@gmail.com>
Date: Tue, 17 May 2016 06:38:15 +0000 (+0800)
Subject: [utils] Check for None values in SOCKS proxy
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=cdd94c2eae6c6f0a627d457c3a73894a62eb86c5;p=youtube-dl

[utils] Check for None values in SOCKS proxy

Originally reported at
https://github.com/rg3/youtube-dl/pull/9287#issuecomment-219617864
---

diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 24e74428b..ac60ba18c 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -883,12 +883,17 @@ def make_socks_conn_class(base_class, socks_proxy):
     elif url_components.scheme.lower() == 'socks4a':
         socks_type = ProxyType.SOCKS4A
 
+    def unquote_if_non_empty(s):
+        if not s:
+            return s
+        return compat_urllib_parse_unquote_plus(s)
+
     proxy_args = (
         socks_type,
         url_components.hostname, url_components.port or 1080,
         True,  # Remote DNS
-        compat_urllib_parse_unquote_plus(url_components.username),
-        compat_urllib_parse_unquote_plus(url_components.password),
+        unquote_if_non_empty(url_components.username),
+        unquote_if_non_empty(url_components.password),
     )
 
     class SocksConnection(base_class):