From: Yuntai Kyong Date: Sun, 14 Oct 2018 13:34:45 +0000 (+0900) Subject: Some changes in comments and error messages. X-Git-Tag: v0.0.12~291^2~2 X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=d3ca7da67268568227472bc689268d73b5853e44;p=rust-lightning Some changes in comments and error messages. --- diff --git a/src/ln/channel.rs b/src/ln/channel.rs index 82c26a0aa..464bfc6e3 100644 --- a/src/ln/channel.rs +++ b/src/ln/channel.rs @@ -1545,7 +1545,7 @@ impl Channel { Ok(()) } - /// Removes an outbound HTLC which has been commitment_signed by the remote end + /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed #[inline] fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>, fail_reason: Option) -> Result<&HTLCSource, ChannelError> { for htlc in self.pending_outbound_htlcs.iter_mut() { @@ -1559,13 +1559,13 @@ impl Channel { }; match htlc.state { OutboundHTLCState::LocalAnnounced(_) => - return Err(ChannelError::Close("Remote tried to fulfill HTLC before it had been committed")), + return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC before it had been committed")), OutboundHTLCState::Committed => { htlc.state = OutboundHTLCState::RemoteRemoved; htlc.fail_reason = fail_reason; }, OutboundHTLCState::AwaitingRemoteRevokeToRemove | OutboundHTLCState::AwaitingRemovedRemoteRevoke | OutboundHTLCState::RemoteRemoved => - return Err(ChannelError::Close("Remote tried to fulfill HTLC that they'd already fulfilled")), + return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC that they'd already fulfilled/failed")), } return Ok(&htlc.source); }