From: Jeffrey Czyz <jkczyz@gmail.com>
Date: Mon, 11 Nov 2024 22:43:53 +0000 (-0600)
Subject: Explain no-std Bolt11Invoice::duration_since_epoch
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=e9051f84f2c711387d83f68424bc697bbac1249f;p=rust-lightning

Explain no-std Bolt11Invoice::duration_since_epoch
---

diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 5a20c8e24..61c5958ac 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -9268,6 +9268,10 @@ where
 			SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)
 				.expect("SystemTime::now() should be after SystemTime::UNIX_EPOCH")
 		};
+
+		// This may be up to 2 hours in the future because of bitcoin's block time rule or about
+		// 10-30 minutes in the past if a block hasn't been found recently. This should be fine as
+		// the default invoice expiration is 2 hours, though shorter expirations may be problematic.
 		#[cfg(not(feature = "std"))]
 		let duration_since_epoch =
 			Duration::from_secs(self.highest_seen_timestamp.load(Ordering::Acquire) as u64);