From: Matt Corallo Date: Thu, 8 Dec 2022 00:33:15 +0000 (+0000) Subject: Note that abandon_payment does not persist the state update in docs X-Git-Tag: v0.0.113~6^2 X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=refs%2Fheads%2F2022-12-abandon-crash-reset;p=rust-lightning Note that abandon_payment does not persist the state update in docs If a user calls `abandon_payment`, then restarts without freshly persisting the `ChannelManager`, the payment will still be pending on restart. This was unclear from the docs (and the docs seemed to imply otherwise). Because this doesn't materially impact the usability of `abandon_payment` (users shouldn't be called `retry_payment` on an abandoned one anyway), we simply document it. Fixes #1804. --- diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index bb99b02d9..29304cadb 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -2761,15 +2761,21 @@ impl ChannelManager