From: Matt Corallo <git@bluematt.me>
Date: Fri, 5 May 2023 00:13:25 +0000 (+0000)
Subject: Mention lnd's SCB feature in the corresponding error message
X-Git-Tag: v0.0.116-alpha1~51^2
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=refs%2Fheads%2F2023-05-better-scb-err;p=rust-lightning

Mention lnd's SCB feature in the corresponding error message

It's a bit confusing when we see only "Peer sent a garbage
channel_reestablish" when a peer uses lnd's SCB feature to ask us
to broadcast the latest state. This updates the error message to be
a bit clearer.
---

diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
index 4fd612a4b..5ba3ab83d 100644
--- a/lightning/src/ln/channel.rs
+++ b/lightning/src/ln/channel.rs
@@ -4092,7 +4092,7 @@ impl<Signer: WriteableEcdsaChannelSigner> Channel<Signer> {
 
 		if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
 			msg.next_local_commitment_number == 0 {
-			return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
+			return Err(ChannelError::Close("Peer sent a garbage channel_reestablish (usually an lnd node with lost state asking us to force-close for them)".to_owned()));
 		}
 
 		if msg.next_remote_commitment_number > 0 {