From: Matt Corallo <git@bluematt.me>
Date: Thu, 3 Oct 2024 16:54:20 +0000 (+0000)
Subject: Hold a reference to byte arrays when serializing to bech32
X-Git-Url: http://git.bitcoin.ninja/?a=commitdiff_plain;h=refs%2Fheads%2F2024-10-3270-followups;p=rust-lightning

Hold a reference to byte arrays when serializing to bech32

When we serialize from a byte array to bech32 in
`lightning-invoice`, we can either copy the array itself into the
iterator or hold a reference to the array and iterate through that.

In aa2f6b47df312f026213d0ceaaff20ffe955c377 we opted to copy the
array into the iterator, which is fine for the current array sizes
we're working with, but does result in additional memory on the
stack if, in the future, we end up writing large arrays.

Instead, here, we switch to using the slice serialization code when
writing arrays, (very marginally) reducing code size and reducing
stack usage.
---

diff --git a/lightning-invoice/src/ser.rs b/lightning-invoice/src/ser.rs
index 3d79a2533..66571ee35 100644
--- a/lightning-invoice/src/ser.rs
+++ b/lightning-invoice/src/ser.rs
@@ -29,7 +29,7 @@ pub(crate) trait Base32Len: Base32Iterable {
 
 impl<const N: usize> Base32Iterable for [u8; N] {
 	fn fe_iter<'s>(&'s self) -> Box<dyn Iterator<Item = Fe32> + 's> {
-		Box::new((*self).into_iter().bytes_to_fes())
+		self[..].fe_iter()
 	}
 }