]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
4 years agoMake get_revokable_redeemscript
Antoine Riard [Tue, 5 May 2020 22:48:32 +0000 (18:48 -0400)]
Make get_revokable_redeemscript

4 years agoMake derive_private_key public
Antoine Riard [Tue, 5 May 2020 22:36:06 +0000 (18:36 -0400)]
Make derive_private_key public

4 years agoDry-up witnessScript in sign_remote_htlc_transaction
Antoine Riard [Mon, 4 May 2020 06:35:54 +0000 (02:35 -0400)]
Dry-up witnessScript in sign_remote_htlc_transaction

Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.

4 years agoDry-up witnessScript in sign_justice_transaction
Antoine Riard [Mon, 4 May 2020 06:20:56 +0000 (02:20 -0400)]
Dry-up witnessScript in sign_justice_transaction

Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.

4 years agoImp Writer/Reader for RemoteCommitmentTransaction
Antoine Riard [Wed, 29 Apr 2020 23:43:31 +0000 (19:43 -0400)]
Imp Writer/Reader for RemoteCommitmentTransaction

4 years agoRename RemoteTxCache as RemoteCommitmentTransaction and document better
Antoine Riard [Wed, 29 Apr 2020 23:21:37 +0000 (19:21 -0400)]
Rename RemoteTxCache as RemoteCommitmentTransaction and document better

We also remove an unecessary build warning.

4 years agoRename their_to_self_delay as on_local_tx_csv
Antoine Riard [Thu, 30 Apr 2020 01:22:28 +0000 (21:22 -0400)]
Rename their_to_self_delay as on_local_tx_csv

on_remote_tx_csv is the CSV delay encumbering remote transactions
revokable outputs as required by local.

on_local_tx_csv is the CSV delay encumbering local transactions
revokable outputs as required by remote.

Local/remote is here defined from a code processing viewpoint,
process running this code is "local".

4 years agoDrop remote_csv from OnchainTxHandler, cache it in Monitor's cache
Antoine Riard [Tue, 28 Apr 2020 00:20:43 +0000 (20:20 -0400)]
Drop remote_csv from OnchainTxHandler, cache it in Monitor's cache

4 years agoDedup RemoteTxCache by removing OnchainTxHandler copy
Antoine Riard [Tue, 28 Apr 2020 00:07:17 +0000 (20:07 -0400)]
Dedup RemoteTxCache by removing OnchainTxHandler copy

RemoteTxCache was providing all data needed at transaction
signature for any remote HTLC transaction or justice transaction.
This move was making the API between OnchainTxHandle akward and
scope of responsibilites with ChannelMonitor unclear.

Instead scope OnchainTxHandler to transaction-finalization, fee-bumping
and broadcast only.

4 years agoDuplicate RemoteTxCache in ChannelMonitor
Antoine Riard [Mon, 27 Apr 2020 23:22:10 +0000 (19:22 -0400)]
Duplicate RemoteTxCache in ChannelMonitor

Dry-up remote pubkeys tracking in one struct.

This introduce a duplicate of RemoteTxCache, which is going
to be removed in next commit when OnchainTxHandler version is
removed.

4 years agoRemove SecretKey from DynamicOuputP2WPKH descriptor
Antoine Riard [Tue, 24 Mar 2020 21:03:26 +0000 (17:03 -0400)]
Remove SecretKey from DynamicOuputP2WPKH descriptor

Add sign_payment_transaction in ChanSigner to be able to spend
SpendableOutputDescriptor in test framework

Extend ChannelKeys with remote_pubkeys to access remote revocation
basepoint for witnessScript construction.

4 years agoRemove SecretKey from DynamicOutputP2WSH descriptor
Antoine Riard [Tue, 24 Mar 2020 20:26:46 +0000 (16:26 -0400)]
Remove SecretKey from DynamicOutputP2WSH descriptor

Add sign_delayed_transaction in ChanSigner to be able to spend
SpendableOutputDescriptor in test framework.

4 years agoExtend KeysInterface with derive_channel_keys
Antoine Riard [Wed, 6 May 2020 00:00:01 +0000 (20:00 -0400)]
Extend KeysInterface with derive_channel_keys

A dynamic-p2wsh-output like `to_local` on local commitment/HTLC txn
require a signature from delayed_payment_key to be spend. Instead of
sending private key in descriptor, we ask for spender to derive again
the corresponding ChannelKeys based on key state, uniquely identifying
a channel and encompassing its unique start data.

Descriptor modification is done in next commit.

4 years agoAdd KeysManager::derive_unique_start
Antoine Riard [Tue, 12 May 2020 00:29:39 +0000 (20:29 -0400)]
Add KeysManager::derive_unique_start

In next commit, we add derive_channel_keys, a helper to rederive
keys from a SpendableOuptutDescriptor. We still need to ensure
that user rederive same set of keys even if KeyManager is started
at a later time. For doing so we need to pass starting time as
part of the re-derived sha_state, therefore we need to make it
accessible and part of channel state key material.

Seed is already required to be conserved between KeysManager
serializations.

4 years agoMove remote htlc transaction signature behind ChanSigner
Antoine Riard [Tue, 24 Mar 2020 19:04:36 +0000 (15:04 -0400)]
Move remote htlc transaction signature behind ChanSigner

4 years agoBuild witness_script for remote htlc transactions inside
Antoine Riard [Tue, 24 Mar 2020 18:47:37 +0000 (14:47 -0400)]
Build witness_script for remote htlc transactions inside
OnchainTxHandler

By moving script generation inside OnchainTxHandler, we may dry-up
further ChannelMonitor in next commits

Comment MINIMALIF rule

4 years agoMove justice transaction signature behind ChanSigner
Antoine Riard [Tue, 24 Mar 2020 18:22:16 +0000 (14:22 -0400)]
Move justice transaction signature behind ChanSigner

4 years agoBuild witness_script for justice tx inside OnchainTxHandler
Antoine Riard [Tue, 24 Mar 2020 01:50:23 +0000 (21:50 -0400)]
Build witness_script for justice tx inside OnchainTxHandler

By moving script generation inside OnchainTxHandler, we may dry-up
further ChannelMonitor in next commits.

4 years agoReplace is_htlc in InputMaterial by InputDescriptor
Antoine Riard [Tue, 24 Mar 2020 03:28:00 +0000 (23:28 -0400)]
Replace is_htlc in InputMaterial by InputDescriptor

As we cache more and more transaction elements in OnchainTxHandler
we should dry up completly InputMaterial until them being replaced
directly by InputDescriptor

4 years agoCache remote HTLC inside OnchainTxHandler::RemoteTxCache
Antoine Riard [Tue, 24 Mar 2020 02:17:46 +0000 (22:17 -0400)]
Cache remote HTLC inside OnchainTxHandler::RemoteTxCache

As we can't predict if any and which revoked commitment tx is
going to appear onchain we have by design to cache all htlc information
to regenerate htlc script if needed.

4 years agoCache remote basepoint and remote_csv in new OnchainTxHandler::RemoteTxCache
Antoine Riard [Tue, 24 Mar 2020 01:22:14 +0000 (21:22 -0400)]
Cache remote basepoint and remote_csv in new OnchainTxHandler::RemoteTxCache

Used in next commits to avoid passing script between ChannelMonitor
and OnchainTxHandler. ChannelMonitor duplicata will be removed
in future commits.

4 years agoMerge pull request #539 from TheBlueMatt/2020-03-static-remotekey
Matt Corallo [Wed, 6 May 2020 02:07:02 +0000 (02:07 +0000)]
Merge pull request #539 from TheBlueMatt/2020-03-static-remotekey

Require static_remotekey

4 years agoMerge pull request #613 from valentinewallace/less-confusing-chan-reserve-names
Matt Corallo [Wed, 6 May 2020 02:06:41 +0000 (02:06 +0000)]
Merge pull request #613 from valentinewallace/less-confusing-chan-reserve-names

Make channel reserve variable names less confusing.

4 years agoRename payment_basepoint/key to simply payment_point/key. 2020-03-static-remotekey
Matt Corallo [Mon, 9 Mar 2020 00:38:16 +0000 (20:38 -0400)]
Rename payment_basepoint/key to simply payment_point/key.

We no longer derive any keys from the payment point, so they aren't
a "base" but simply a point/key.

4 years agoRequire option_static_remotekey in channel/channelmonitor.
Matt Corallo [Sun, 3 May 2020 02:00:08 +0000 (22:00 -0400)]
Require option_static_remotekey in channel/channelmonitor.

This simplifies channelmonitor quite nicely (as expected) as we
never have to be concerned with learning data in a DataLossProtect
which is require for us to claim our funds from the latest remote
commitment transaction.

4 years agoAdd detection of feature_static_remotekey support and print
Matt Corallo [Tue, 3 Mar 2020 20:27:45 +0000 (15:27 -0500)]
Add detection of feature_static_remotekey support and print

This adds the ability to check for static_remotekey in appropriate
feature contexts and prints it at connect time. It is still
considered unknown for the purposes of requires_unknown_bits() as
we don't yet implement it.

4 years agoMake channel reserve variable names less confusing.
Valentine Wallace [Fri, 1 May 2020 22:39:18 +0000 (18:39 -0400)]
Make channel reserve variable names less confusing.

Previous to this commit, variables such as their_channel_reserve
referred to the channel reserve that _we_ are required to keep,
(the value is initially set by the remote). Similarly,
variables such as our_channel_reserve referred to the channel
reserve that we require the remote to keep.

Change this to use local_channel_reserve / remote_channel_reserve
to refer to the the channel reserve that the local is required to keep
and the channel reserve that the remote is required to keep, respectively.

4 years agoCheck local signtures explicitly in channel tx-generation tests
Matt Corallo [Mon, 9 Mar 2020 17:45:15 +0000 (13:45 -0400)]
Check local signtures explicitly in channel tx-generation tests

It appears the local signatures which are specified in the channel
transaction-generation tests were never checked directly (though
they were checked as a part of the overall fully-signed-transaction
tests).

Check them explicitly so that they can be updated for static remote
key.

4 years agoAdd additional trace logging in channel signature validation
Matt Corallo [Tue, 28 Apr 2020 23:46:45 +0000 (19:46 -0400)]
Add additional trace logging in channel signature validation

This makes it easier to amend the full_stack_target
test_no_existing_test_breakage test by always providing the
neccessary data in the log.

4 years agoMerge pull request #590 from jkczyz/2020-04-feature-flags
Matt Corallo [Wed, 29 Apr 2020 18:49:39 +0000 (18:49 +0000)]
Merge pull request #590 from jkczyz/2020-04-feature-flags

Features module improvements

4 years agoSanity check that known features are not required
Jeffrey Czyz [Tue, 28 Apr 2020 06:24:46 +0000 (23:24 -0700)]
Sanity check that known features are not required

4 years agoExpand testing of unknown feature bits
Jeffrey Czyz [Tue, 28 Apr 2020 05:12:53 +0000 (22:12 -0700)]
Expand testing of unknown feature bits

Include tests for requires_unknown_bits and supports_unknown_bits when
an unknown even bit, odd bit, or neither is set. Refactor bit clearing
such that tests and production code share the same code path. Fix a
potential spec incompatibility (currently only exposed in testing code)
where trailing zero bytes are not removed after a bit is cleared.

4 years agoGeneralize with_known_relevant_init_flags
Jeffrey Czyz [Wed, 22 Apr 2020 23:52:11 +0000 (16:52 -0700)]
Generalize with_known_relevant_init_flags

Converting from InitFeatures to other Features is accomplished using
Features::with_known_relevant_init_flags. Define a more general
to_context method which converts from Features of one Context to
another.

Additionally, ensure the source context only has known flags before
selecting flags for the target context.

4 years agoGeneralize feature methods to work in any context
Jeffrey Czyz [Thu, 16 Apr 2020 05:44:43 +0000 (22:44 -0700)]
Generalize feature methods to work in any context

Refactoring the features module allowed for making code specific to
certain contexts generalizable. Specifically, KNOWN_FEATURE_MASK
is defined on Context instead of hardcoded in each method
specialization. Thus, such methods are no longer required.

4 years agoRemove duplicate specification of features
Jeffrey Czyz [Thu, 16 Apr 2020 00:16:45 +0000 (17:16 -0700)]
Remove duplicate specification of features

Features for a given context are duplicated throughout the features
module. Use a macro for defining a Context and the applicable features
such that features only need to be defined for a Context in one place.
The Context provides bitmasks for selecting known and unknown feature
flags.

BOLT 1 and BOLT 9 refer to features as "known" if a peer understands
them. They also use the term "supported" to mean either optional or
required.

Update the features module to use similar terminology.
- Define contexts in terms of required and optional features rather than
  just supported features
- Define known features as those that are optional or required
- Rename supported() constructor to known()

For completeness, clear_optional_bit for each feature is now called
clear_bits and clears both optional and required bits.

4 years agoImprove features module documentation
Jeffrey Czyz [Tue, 14 Apr 2020 01:39:29 +0000 (18:39 -0700)]
Improve features module documentation

4 years agoEncapsulate feature flag checking and manipulation
Jeffrey Czyz [Fri, 10 Apr 2020 00:08:48 +0000 (17:08 -0700)]
Encapsulate feature flag checking and manipulation

Each feature is represented by two bits within Features' flags field.
Working with these flags requires bitwise operations, which can be error
prone. Rather than directly checking and manipulating bits, encapsulate
the bits within each feature trait and provide mechanisms for doing so.

This removes the need to comment on which features correspond to bitwise
expressions since the expressions use feature trait identifiers instead.

With this approach, byte literals and expressions can be evaluated at
compile time still. However, for these cases, knowing which byte within
the flags that a feature corresponds to still must be determined by the
implementor.

Remove the special case where initial_routing_sync has no even bit. Now,
it (bit 2) is considered known by the implementation.

4 years agoSet initial_routing_sync in InitFeatures
Jeffrey Czyz [Thu, 23 Apr 2020 16:47:15 +0000 (09:47 -0700)]
Set initial_routing_sync in InitFeatures

The initial_routing_sync feature is set by peer_handler whenever a full
sync of the network graph is desired. It is not explicitly set when
creating features with InitFeatures::supported().

An upcoming refactor will change supported() to known(), which will
return all features known by the implementation. Thus, the
initial_routing_sync flag will need to be set by default. This commit
makes the behavior change ahead of the refactor.

4 years agoMerge pull request #609 from LNP-BP/refactor-deps
Matt Corallo [Wed, 29 Apr 2020 17:15:38 +0000 (17:15 +0000)]
Merge pull request #609 from LNP-BP/refactor-deps

Refactor dependencies

4 years agoAdopting (W)PubkeyHash types
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 16:13:27 +0000 (18:13 +0200)]
Adopting (W)PubkeyHash types

4 years agoAdopting new bitcoin hash types and crate version
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 15:53:13 +0000 (17:53 +0200)]
Adopting new bitcoin hash types and crate version

4 years agoBDR: Linearizing secp256k1 deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:51:59 +0000 (16:51 +0200)]
BDR: Linearizing secp256k1 deps

4 years agoBitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:41:54 +0000 (16:41 +0200)]
Bitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps

4 years agoUnset upfront_shutdown_script using bit clearing
Jeffrey Czyz [Fri, 10 Apr 2020 18:36:47 +0000 (11:36 -0700)]
Unset upfront_shutdown_script using bit clearing

The test_upfront_shutdown_script functional test clears this feature
flag. However, the method used to clear the flag is implemented by bit
toggling. Thus, if the flag is not set the method would actually set it.
Implement the method using bit clearing instead.

4 years agoMerge pull request #608 from TheBlueMatt/2020-04-0.0.11
Matt Corallo [Sat, 25 Apr 2020 16:42:15 +0000 (16:42 +0000)]
Merge pull request #608 from TheBlueMatt/2020-04-0.0.11

0.0.11

4 years agoMerge pull request #598 from TheBlueMatt/2020-04-559-cleanups
Matt Corallo [Sat, 25 Apr 2020 16:42:03 +0000 (16:42 +0000)]
Merge pull request #598 from TheBlueMatt/2020-04-559-cleanups

Clean up ChannelKeys API

4 years agoBump versions to 0.0.11/net-tokio 0.0.3 2020-04-0.0.11
Matt Corallo [Sat, 25 Apr 2020 02:10:00 +0000 (22:10 -0400)]
Bump versions to 0.0.11/net-tokio 0.0.3

4 years agoRemove trivial assertions in LocalCommitmentTransaction fns 2020-04-559-cleanups
Matt Corallo [Fri, 24 Apr 2020 19:31:33 +0000 (15:31 -0400)]
Remove trivial assertions in LocalCommitmentTransaction fns

We don't need to assert that transaction structure is what we
expect when the transaction is created by a function twenty lines
up in the same file.

4 years agoRemove TODOs from documentation in keysinterface
Matt Corallo [Mon, 20 Apr 2020 05:07:18 +0000 (01:07 -0400)]
Remove TODOs from documentation in keysinterface

We should never be exposing our own TODOs to the world.

4 years agoDon't modify LocalCommitmemntTransaction after construction
Matt Corallo [Thu, 23 Apr 2020 19:43:21 +0000 (15:43 -0400)]
Don't modify LocalCommitmemntTransaction after construction

Instead of adding signatures to LocalCommitmentTransactions, we
instead leave them unsigned and use them to construct signed
Transactions when we want them. This cleans up the guts of
LocalCommitmentTransaction enough that we can, and do, expose its
state to the world, allowing external signers to have a basic
awareness of what they're signing.

4 years agoBatch-sign local HTLC txn with a well-doc'd API, returning sigs
Matt Corallo [Mon, 20 Apr 2020 02:59:53 +0000 (22:59 -0400)]
Batch-sign local HTLC txn with a well-doc'd API, returning sigs

1107ab06c33bd360bdee7ee64f4b690e753003f6 introduced an API to have a
ChannelKeys implementer sign HTLC transactions by calling into the
LocalCommitmentTransaction object, which would then store the tx.

This API was incredibly awkward, both because it required an
external signer trust our own internal interfaces, but also because
it didn't allow for any inspection of what was about to be signed.

Further, it signed the HTLC transactions one-by-one in a somewhat
inefficient way, and there isn't a clear way to resolve this (as
the which-HTLC parameter has to refer to something in between the
HTLC's arbitrary index, and its index in the commitment tx, which
has "holes" for the non-HTLC outputs and skips some HTLCs).

We replace it with a new function in ChannelKeys which allows us
to sign all HTLCs in a given commitment transaction (which allows
for a bit more effeciency on the signers' part, as well as
sidesteps the which-HTLC issue). This may also simplify the signer
implementation as we will always want to sign all HTLCs spending a
given commitment transaction at once anyway.

We also de-mut the LocalCommitmentTransaction passed to the
ChanKeys, instead opting to make LocalCommitmentTransaction const
and avoid storing any new HTLC-related data in it.

4 years agoReturn Result<Signature> instead of modifying args in ChannelKeys
Matt Corallo [Sun, 19 Apr 2020 21:26:41 +0000 (17:26 -0400)]
Return Result<Signature> instead of modifying args in ChannelKeys

This cleans up sign_local_commitment somewhat by returning a
Result<Signaure, ()> over the local commitment transaction instead
of modifying the struct which was passed in.

This is the first step in making LocalCommitmentTransaction a
completely pub struct, using it just to communicate enough
information to the user to allow them to construct a signaure
instead of having it contain a bunch of logic.

This should make it much easier to implement a custom ChannelKeys
by disconnecting the local commitment transaction signing from our
own datastructures.

4 years agoTrack signing of local txn in channelmonitor and refuse updates
Matt Corallo [Sun, 19 Apr 2020 18:15:56 +0000 (14:15 -0400)]
Track signing of local txn in channelmonitor and refuse updates

In e46e183084ed858f41aa304acd78503aea1a96ed we began tracking
whether a local commitment transaction had been signed and
broadcast in OnchainTxHandler, refusing to update the local
commitment transaction state in the ChannelMonitor on that basis.

This is fine, except that it doesn't make a lot of sense to store
the full local transaction state in OnchainTxHandler - we should be
providing it the unsigned local transaction at the time we wish to
broadcast and no more (just like we do all other transaction data).

4 years agoDry-up InputMaterial::Funding
Antoine Riard [Tue, 21 Apr 2020 01:19:00 +0000 (21:19 -0400)]
Dry-up InputMaterial::Funding

As channel_value last usage was for computing feerate but as this
one is static per-commitment and will always-be following specification,
we remove it.

4 years agoMerge pull request #579 from ariard/2020-04-sanitize-cltv-delay
Matt Corallo [Fri, 24 Apr 2020 22:50:45 +0000 (22:50 +0000)]
Merge pull request #579 from ariard/2020-04-sanitize-cltv-delay

Sanititze and document incoming HTLC cltv_expiry handling

4 years agoSanitize outgoing HTLC cltv_value
Antoine Riard [Fri, 10 Apr 2020 02:04:30 +0000 (22:04 -0400)]
Sanitize outgoing HTLC cltv_value

4 years agoDocument exactly our CLTV sanitization policy for final incoming HTLCs
Antoine Riard [Fri, 10 Apr 2020 01:51:29 +0000 (21:51 -0400)]
Document exactly our CLTV sanitization policy for final incoming HTLCs

We want to avoid a third-party channel closure, where a random node
by sending us a payment expiring at current height, would trigger our
onchain logic to close the channel due to a near-expiration.

4 years agoMerge pull request #607 from TheBlueMatt/2020-04-more-cleanups
Matt Corallo [Fri, 24 Apr 2020 22:17:53 +0000 (22:17 +0000)]
Merge pull request #607 from TheBlueMatt/2020-04-more-cleanups

CI and rustc warning cleanup

4 years agoInclude color when building fuzz targets in CI 2020-04-more-cleanups
Matt Corallo [Fri, 24 Apr 2020 21:35:18 +0000 (17:35 -0400)]
Include color when building fuzz targets in CI

4 years agoDisable timeout for full_stack_target runs in CI
Matt Corallo [Fri, 24 Apr 2020 20:56:20 +0000 (16:56 -0400)]
Disable timeout for full_stack_target runs in CI

It seems we've recently been seeing sporadic long-running
full_stack_target cases when running honggfuzz in CI. These
shouldn't be killed (as its possible they hit an error or a deadlock,
especially since the longest-running tests probably have the most
coverage).

4 years agoSilence fuzz build unused import warnings
Matt Corallo [Fri, 24 Apr 2020 20:24:25 +0000 (16:24 -0400)]
Silence fuzz build unused import warnings

4 years agoAddress new rustc warnings.
Matt Corallo [Fri, 24 Apr 2020 18:40:01 +0000 (14:40 -0400)]
Address new rustc warnings.

4 years agoFix step naming in fuzz tests in GitHub Actions
Matt Corallo [Fri, 24 Apr 2020 18:22:31 +0000 (14:22 -0400)]
Fix step naming in fuzz tests in GitHub Actions

4 years agoRun Github Actions on PRs, too
Matt Corallo [Fri, 24 Apr 2020 20:22:44 +0000 (16:22 -0400)]
Run Github Actions on PRs, too

4 years agoMerge pull request #593 from TheBlueMatt/2020-04-par-fuzz-check
Matt Corallo [Fri, 24 Apr 2020 20:52:19 +0000 (20:52 +0000)]
Merge pull request #593 from TheBlueMatt/2020-04-par-fuzz-check

Thread fuzz test cases

4 years agoDocument exactly our CLTV sanitization policy for incoming HTLCs
Antoine Riard [Fri, 10 Apr 2020 01:22:16 +0000 (21:22 -0400)]
Document exactly our CLTV sanitization policy for incoming HTLCs

4 years agoThread fuzz test cases 2020-04-par-fuzz-check
Matt Corallo [Fri, 21 Feb 2020 01:11:40 +0000 (20:11 -0500)]
Thread fuzz test cases

Adds threading (with logger capture) to fuzz targets so that we can
more effeciently test a failing fuzz corpus on new code changes.

4 years agoMerge pull request #587 from TheBlueMatt/2020-04-mpp-timeout
Matt Corallo [Fri, 24 Apr 2020 19:07:22 +0000 (19:07 +0000)]
Merge pull request #587 from TheBlueMatt/2020-04-mpp-timeout

Time out HTLCs before they expire

4 years agoAdd test for timing out HTLCs which are in the holding cell 2020-04-mpp-timeout
Matt Corallo [Mon, 20 Apr 2020 20:55:31 +0000 (16:55 -0400)]
Add test for timing out HTLCs which are in the holding cell

4 years agoTime out AwatingRemoteRAA outgoing HTLCs when we reach cltv_expiry
Antoine Riard [Sat, 8 Dec 2018 03:09:58 +0000 (22:09 -0500)]
Time out AwatingRemoteRAA outgoing HTLCs when we reach cltv_expiry

In case of committing out-of-time outgoing HTLCs, we force
ourselves to close the channel to avoid remote peer claims on a
non-backed HTLC

4 years agoAdd test for partial-send MPP due to monitor update failure
Matt Corallo [Tue, 14 Apr 2020 01:04:03 +0000 (21:04 -0400)]
Add test for partial-send MPP due to monitor update failure

Relatively simple test that, after a monitor update fails, we get
the right return value and continue with the bits of the MPP that
did not send after the monitor updating is restored.

4 years agoAdd a test for timeout'ing HTLCs which claim to be a part of an MPP
Matt Corallo [Thu, 19 Mar 2020 04:34:15 +0000 (00:34 -0400)]
Add a test for timeout'ing HTLCs which claim to be a part of an MPP

This is a key test for our automatic HTLC time-out logic, as it
ensures we don't allow an HTLC which indicates we should wait for
additional HTLCs before responding to cause us to force-close a
channel due to HTLC near-timeout.

4 years agoExpand expect_payment_failed!() to take error codes and use it more
Matt Corallo [Mon, 20 Apr 2020 19:46:35 +0000 (15:46 -0400)]
Expand expect_payment_failed!() to take error codes and use it more

expect_payment_failed!() was introduced after many of the tests
which could use it were written, so we take this opportunity to
switch them over now, increasing test coverage slightly by always
checking the payment hash expected.

4 years agoTime out incoming HTLCs when we reach cltv_expiry (+ test)
Matt Corallo [Thu, 9 Jan 2020 19:09:25 +0000 (14:09 -0500)]
Time out incoming HTLCs when we reach cltv_expiry (+ test)

We only do this for incoming HTLCs directly as we rely on channel
closure and HTLC-Timeout broadcast to fail any HTLCs which we
relayed onwards where our next-hop doesn't update_fail in time.

4 years agoAdd a constant and docs for when we should fail an HTLC.
Matt Corallo [Fri, 24 Apr 2020 00:39:01 +0000 (20:39 -0400)]
Add a constant and docs for when we should fail an HTLC.

4 years agoMerge pull request #601 from D4nte/ci-in-github-action
Matt Corallo [Fri, 24 Apr 2020 18:14:55 +0000 (18:14 +0000)]
Merge pull request #601 from D4nte/ci-in-github-action

Add GitHub Action to build the project

4 years agoAdd a pop of colour
Franck Royer [Fri, 24 Apr 2020 05:06:15 +0000 (15:06 +1000)]
Add a pop of colour

4 years agoAdd CI using GitHub Action
Franck Royer [Tue, 21 Apr 2020 10:24:39 +0000 (20:24 +1000)]
Add CI using GitHub Action

Same setup than Travis except for removing
`rm -f target/debug/lightning-*` as I do not believe
such file would exist on a fresh run.

I have not setup caching at this stage. The library is
small so I don't think it'd be that necessary/helpful.

I'd recommend to let both CI run for a bit to compare
performance and stability. The CI setup is straightforward
so I do not foresee any issue with GitHub actions.

Once happy, Travis file can be removed and branch
protection checks can be updated to block on the GitHub
actions.

You can also check the [Coverage report](https://codecov.io/gh/D4nte/rust-lightning/tree/752a58bc0441a49a0513f2cad979ad9e2621312a/lightning/src/chain) to ensure it is as expected.

4 years agoMerge pull request #597 from TheBlueMatt/2020-04-more-chanmon-cleanups
Matt Corallo [Thu, 23 Apr 2020 18:15:47 +0000 (18:15 +0000)]
Merge pull request #597 from TheBlueMatt/2020-04-more-chanmon-cleanups

Few more ChannelMonitor Cleanups

4 years agoDe-Option<> current_local_signed_commitment_tx in ChannelMonitor 2020-04-more-chanmon-cleanups
Matt Corallo [Sun, 19 Apr 2020 03:13:18 +0000 (23:13 -0400)]
De-Option<> current_local_signed_commitment_tx in ChannelMonitor

Since we now are always initialised with an initial local commitment
transaction available now, we might as well take advantage of it and
stop using an Option<> where we don't need to.

4 years agoDelay creating outbound ChannelMonitor until funding_signed rcpt
Matt Corallo [Sat, 18 Apr 2020 20:35:01 +0000 (16:35 -0400)]
Delay creating outbound ChannelMonitor until funding_signed rcpt

Previously, we created the initial ChannelMonitor on outbound
channels when we generated the funding_created message. This was
somewhat unnecessary as, at that time, we hadn't yet received
clearance to broadcast our initial funding transaction, and thus
there should never be any use for a ChannelMonitor. It also
complicated ChannelMonitor a bit as, at this point, we didn't have
an initial local commitment transaction.

By moving the creation of the initial ChannelMonitor to when we
receive our counterparty's funding_signed, we can ensure that any
ChannelMonitor will always have both a latest remote commitment tx
and a latest local commitment tx for broadcast.

This also fixes a strange API where we would close a channel
unceremoniously on peer-disconnection if we hadn't yet received the
funding_signed, but we'd already have a ChannelMonitor for that
channel. While it isn't strictly a bug (some potential DoS issues
aside), it is strange that these two definitions of a channel being
open were not in sync.

4 years agoAdd HTLC/extra data in LocalCommitmentTransaction from construction
Matt Corallo [Sat, 18 Apr 2020 04:10:24 +0000 (00:10 -0400)]
Add HTLC/extra data in LocalCommitmentTransaction from construction

1107ab06c33bd360bdee7ee64f4b690e753003f6 introduced some additional
metadata, including per-HTLC data in LocalCommitmentTransaction. To
keep diff reasonable it did so in ChannelMonitor after the
LocalCommitmentTransaction had been constructed and passed over the
wall, but there's little reason to do so - we should just be
constructing them with the data from the start, filled in by Channel.

This cleans up some internal interfaces a bit, slightly reduces
some data duplication and moves us one step forward to exposing
the guts of LocalCommitmentTransaction publicly in a sensible way.

4 years agoDrop redundant parameters in sign_local_commitment_tx
Matt Corallo [Sat, 18 Apr 2020 01:26:38 +0000 (21:26 -0400)]
Drop redundant parameters in sign_local_commitment_tx

The ChanKeys is created with knowledge of the Channel's value and
funding redeemscript up-front, so we should not be providing it
when making signing requests.

4 years agoAvoid a few useless clone() calls in onchaintx.rs
Matt Corallo [Sun, 19 Apr 2020 05:16:20 +0000 (01:16 -0400)]
Avoid a few useless clone() calls in onchaintx.rs

3d640da5c343111f538f006996c13c9a98e0d9e6 looped over a new HashMap
new_claims, clone()ing entries out of it right before droppng the
whole thing. This is an obvious candidate for drain(..).

4 years agoClarify documentation on deserialization reorg requirements
Matt Corallo [Tue, 21 Apr 2020 20:18:49 +0000 (16:18 -0400)]
Clarify documentation on deserialization reorg requirements

4 years agoUse more generic name as it will be use in GitHub Action too
Franck Royer [Tue, 21 Apr 2020 22:00:43 +0000 (08:00 +1000)]
Use more generic name as it will be use in GitHub Action too

4 years agoDrop ChannelMonitor::write_for_watchtower
Matt Corallo [Sun, 19 Apr 2020 01:36:33 +0000 (21:36 -0400)]
Drop ChannelMonitor::write_for_watchtower

Not only was watchtower mode never implemented, but the bits that
we had were removed some time ago. It doesn't seem likely we'll
move forward with a "watchtower-mode" ChannelMonitor, instead
we'll likely have some other, separate struct for this.

4 years agoMerge pull request #602 from murtyjones/test-byte-utils
Matt Corallo [Wed, 22 Apr 2020 20:45:04 +0000 (20:45 +0000)]
Merge pull request #602 from murtyjones/test-byte-utils

Add tests to byte_utils.rs

4 years agoMerge pull request #603 from moneyball/patch-3
Matt Corallo [Wed, 22 Apr 2020 20:43:45 +0000 (20:43 +0000)]
Merge pull request #603 from moneyball/patch-3

fixed typo

4 years agofixed typo
Steve Lee [Wed, 22 Apr 2020 17:52:32 +0000 (10:52 -0700)]
fixed typo

4 years agoUpdate lightning/src/util/byte_utils.rs
Marty Jones [Wed, 22 Apr 2020 00:29:46 +0000 (20:29 -0400)]
Update lightning/src/util/byte_utils.rs

4 years agoadd tests
Marty Jones [Wed, 22 Apr 2020 00:27:35 +0000 (20:27 -0400)]
add tests

4 years agoMerge pull request #594 from TheBlueMatt/2020-04-cleanups
Matt Corallo [Mon, 20 Apr 2020 21:54:35 +0000 (21:54 +0000)]
Merge pull request #594 from TheBlueMatt/2020-04-cleanups

Trivial Cleanups

4 years agoMerge pull request #596 from D4nte/586-update-htlc-error-code-content
Matt Corallo [Mon, 20 Apr 2020 05:14:18 +0000 (05:14 +0000)]
Merge pull request #596 from D4nte/586-update-htlc-error-code-content

Include `height` to `incorrect_or_unknown_payment_details` failure

4 years agoTest that `height` is included for incorrect payment details
Franck Royer [Sun, 19 Apr 2020 21:30:16 +0000 (07:30 +1000)]
Test that `height` is included for incorrect payment details

Ensure that the best know blockchain height is included in the
data of `incorrect_or_unknown_payment_details` message failure.

4 years agoInclude `height` to `incorrect_or_unknown_payment_details` failure
Franck Royer [Sun, 19 Apr 2020 12:14:14 +0000 (22:14 +1000)]
Include `height` to `incorrect_or_unknown_payment_details` failure

`incorrect_or_unknown_payment_details` failure message,
`0x4000 (PERM) | 15`, should include the following data:
- [u64:htlc_msat]
- [u32:height]
This patches ensure that the height is included in all
the occurrences of this failure message.

4 years agoDe-Option<> some fields in ChannelMonitor which are set at init 2020-04-cleanups
Matt Corallo [Sun, 19 Apr 2020 01:33:54 +0000 (21:33 -0400)]
De-Option<> some fields in ChannelMonitor which are set at init

After we moved the ChannelMonitor creation later during Channel
init, we never went back and cleaned up ChannelMonitor to remove
a number of now-useless Option<>s, so we do that now.

4 years agoDrop std::error::Error impl for DecodeError
Matt Corallo [Sat, 18 Apr 2020 01:14:54 +0000 (21:14 -0400)]
Drop std::error::Error impl for DecodeError

It appears to be effectively-deprecated in Rust now, and didn't
really appear to serve a lot of purpose anyway.

4 years agoConcretize some types in fuzz, addressing new rustc warnings
Matt Corallo [Sat, 18 Apr 2020 01:09:08 +0000 (21:09 -0400)]
Concretize some types in fuzz, addressing new rustc warnings

4 years agoFix new rustc warnings for unnecessary parenthesis
Matt Corallo [Sat, 18 Apr 2020 01:06:40 +0000 (21:06 -0400)]
Fix new rustc warnings for unnecessary parenthesis