]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
9 months ago[fuzz] Add a second full_stack_target seed test for gossip
Matt Corallo [Sat, 20 Jan 2024 08:27:23 +0000 (08:27 +0000)]
[fuzz] Add a second full_stack_target seed test for gossip

9 months ago[fuzz] De-dup hex in test_no_existing_test_breakage
Matt Corallo [Sat, 20 Jan 2024 08:26:07 +0000 (08:26 +0000)]
[fuzz] De-dup hex in test_no_existing_test_breakage

This will make test_no_existing_test_breakage marginally easier to
update.

9 months ago[fuzz] Add additional method calls in full_stack_target
Matt Corallo [Fri, 19 Jan 2024 00:42:17 +0000 (00:42 +0000)]
[fuzz] Add additional method calls in full_stack_target

The whole point of full_stack_target is to just expose our entire
API to the fuzzer and see what happens. Sadly, we're really only
exposing a small subset of our API. This improves that by exposing
a handful of other assorted methods from ChannelManager and
PeerManager.

9 months ago[fuzz] Use batch funding in full_stack_target
Matt Corallo [Fri, 19 Jan 2024 00:41:57 +0000 (00:41 +0000)]
[fuzz] Use batch funding in full_stack_target

To potentially get more test coverage

9 months ago[fuzz] Fix misc warnings in full_stack_target
Matt Corallo [Fri, 19 Jan 2024 01:12:14 +0000 (01:12 +0000)]
[fuzz] Fix misc warnings in full_stack_target

9 months ago[fuzz] Reduce size of `payments_sent` in full_stack_target
Matt Corallo [Fri, 19 Jan 2024 00:41:25 +0000 (00:41 +0000)]
[fuzz] Reduce size of `payments_sent` in full_stack_target

Slightly reducing the amount of data we read to do things.

9 months agoMerge pull request #2810 from TheBlueMatt/2023-12-arbitrary-fuzz-config
Matt Corallo [Mon, 5 Feb 2024 23:53:06 +0000 (23:53 +0000)]
Merge pull request #2810 from TheBlueMatt/2023-12-arbitrary-fuzz-config

Update `full_stack_target` to take an arbitrary config object

9 months agoMerge pull request #2847 from TheBlueMatt/2024-01-bindings-upstream
Matt Corallo [Mon, 5 Feb 2024 23:49:19 +0000 (23:49 +0000)]
Merge pull request #2847 from TheBlueMatt/2024-01-bindings-upstream

Misc Tweaks for bindings

9 months agoMerge pull request #2725 from shaavan/issue2096
Matt Corallo [Mon, 5 Feb 2024 23:44:36 +0000 (23:44 +0000)]
Merge pull request #2725 from shaavan/issue2096

Ensure successful message propagation in case of disconnection mid-handshake

9 months agoMerge pull request #2863 from benthecarman/breakup-coop-close
Matt Corallo [Mon, 5 Feb 2024 23:43:26 +0000 (23:43 +0000)]
Merge pull request #2863 from benthecarman/breakup-coop-close

Breakup CooperativeClosure into Local/Remote initiated

9 months agoMerge pull request #2872 from tnull/2024-02-add-features-to-channel-pending
Matt Corallo [Mon, 5 Feb 2024 19:58:51 +0000 (19:58 +0000)]
Merge pull request #2872 from tnull/2024-02-add-features-to-channel-pending

Expose `channel_type` in `Event::ChannelPending`

9 months agoExpose `channel_type` in `Event::ChannelPending`
Elias Rohrer [Mon, 5 Feb 2024 13:32:33 +0000 (14:32 +0100)]
Expose `channel_type` in `Event::ChannelPending`

It is useful to immediately know what kind of channel is being opened,
and not having to wait until `ChannelReady`.

9 months agoRename old CooperativeClosure to LegacyCooperativeClosure
benthecarman [Sun, 4 Feb 2024 16:33:08 +0000 (16:33 +0000)]
Rename old CooperativeClosure to LegacyCooperativeClosure

9 months agoBreakup CooperativeClosure into Local/Remote initiated
benthecarman [Wed, 31 Jan 2024 00:32:37 +0000 (00:32 +0000)]
Breakup CooperativeClosure into Local/Remote initiated

9 months ago[fuzz] Fix slice copy in `peer_crypt_target` 2023-12-arbitrary-fuzz-config
Matt Corallo [Wed, 31 Jan 2024 19:48:44 +0000 (19:48 +0000)]
[fuzz] Fix slice copy in `peer_crypt_target`

This has apparently been broken for quite some time...I guess
`peer_crypt_target` doesn't get much CPU anymore.

9 months agoFix test variable typos
Matt Corallo [Thu, 11 Jan 2024 21:33:53 +0000 (21:33 +0000)]
Fix test variable typos

9 months agoBump `hashbrown` dependency to 0.13
Matt Corallo [Thu, 18 Jan 2024 22:39:26 +0000 (22:39 +0000)]
Bump `hashbrown` dependency to 0.13

While this isn't expected to materially improve performance, it
does get us ahash 0.8, which allows us to reduce fuzzing
randomness, making our fuzzers much happier.

Sadly, by default `ahash` no longer tries to autodetect a
randomness source, so we cannot simply rely on `hashbrown` to do
randomization for us, but rather have to also explicitly depend on
`ahash`.

9 months agoStop relying on `Hash{Set,Map}::from_iter` directly
Matt Corallo [Thu, 18 Jan 2024 20:27:57 +0000 (20:27 +0000)]
Stop relying on `Hash{Set,Map}::from_iter` directly

In the next commit we'll bump the `hashbrown` version, which no
longer randomizes its hasher by default. Thus, we'll need to call
a different constructor in no-std builds from std builds.

Here we do a quick prefactor to use wrappers for `FromIterator`
constructors instead of calling the tables directly to make the
version bump changeset smaller.

9 months agoUse utility methods to construct `HashMap`s and `HashSet`s
Matt Corallo [Mon, 1 Jan 2024 21:53:36 +0000 (21:53 +0000)]
Use utility methods to construct `HashMap`s and `HashSet`s

In the next commit we'll bump the `hashbrown` version, which no
longer randomizes its hasher by default. Thus, we'll need to call
a different constructor in no-std builds from std builds.

Here we do a quick prefactor to use wrappers for constructors
instead of calling the tables directly to make the version bump
changeset smaller.

9 months agoUpdate fuzz CI job to use our MSRV rather than 1.58
Matt Corallo [Thu, 18 Jan 2024 20:34:56 +0000 (20:34 +0000)]
Update fuzz CI job to use our MSRV rather than 1.58

9 months agoUse arbitrary config object in full_stack_target fuzzer
Matt Corallo [Sat, 23 Dec 2023 19:13:34 +0000 (19:13 +0000)]
Use arbitrary config object in full_stack_target fuzzer

As we've added more and more configuration parameters which change
our behavior, we're increasingly missing coverage in the general
`full_stack_target` fuzzer. Sadly, a reachable `unwrap` slipped in
uncaught that should have been stopped by the `full_stack_target`.

Here, we update the `full_stack_target` fuzzer to read a full
config object to substantially increase coverage.

9 months agoDisable fuzzing-reachable debug assertions in `ChannelMonitor`s
Matt Corallo [Mon, 25 Dec 2023 00:54:45 +0000 (00:54 +0000)]
Disable fuzzing-reachable debug assertions in `ChannelMonitor`s

9 months agoDisable fuzzing-reachable debug assertion
Matt Corallo [Sun, 24 Dec 2023 17:12:18 +0000 (17:12 +0000)]
Disable fuzzing-reachable debug assertion

Because of txid conflicts, a txid can match both a local and remote
commitment transaction when fuzzing. Thus, we disable this
assertion when fuzzing.

9 months agoMerge pull request #2868 from orbitalturtle/export-send-onion-path
Jeffrey Czyz [Fri, 2 Feb 2024 17:18:24 +0000 (11:18 -0600)]
Merge pull request #2868 from orbitalturtle/export-send-onion-path

export send_onion_message_using_path for testing

9 months agoMerge pull request #2870 from benthecarman/pub-source-target
Matt Corallo [Fri, 2 Feb 2024 17:08:52 +0000 (17:08 +0000)]
Merge pull request #2870 from benthecarman/pub-source-target

Make DirectedChannelInfo `source` and `target` public

9 months agoMake DirectedChannelInfo `source` and `target` public
benthecarman [Fri, 2 Feb 2024 14:14:51 +0000 (14:14 +0000)]
Make DirectedChannelInfo `source` and `target` public

We use these params for our HubPreferentialScorer and without these
utility functions then we have to manually do this and calculate which
is the source and which is the target node.

9 months agoexport send_onion_message_using_path for testing
Orbital [Fri, 2 Feb 2024 02:22:53 +0000 (20:22 -0600)]
export send_onion_message_using_path for testing

9 months agoMerge pull request #2858 from tnull/2024-01-expose-skimmed-fee-msat
valentinewallace [Thu, 1 Feb 2024 14:42:22 +0000 (09:42 -0500)]
Merge pull request #2858 from tnull/2024-01-expose-skimmed-fee-msat

Expose withheld amount for underpaying HTLCs in `PaymentForwarded`

9 months agoExpose `skimmed_fee_msat` in `PaymentForwarded`
Elias Rohrer [Mon, 29 Jan 2024 15:16:08 +0000 (16:16 +0100)]
Expose `skimmed_fee_msat` in `PaymentForwarded`

We generally allow routing nodes to forward less than the expected HTLC
amount, if the receiver knowingly accepts this and claims the
underpaying HTLC (see `ChannelConfig::accept_underpaying_htlcs`). This
use case is in particular useful for the LSPS2/JIT channel setting where
the intial underpaying HTLC pays for the channel open.

While we previously exposed the withheld amount as
`PaymentClaimable::counterparty_skimmed_fee_msat` on the receiver side,
we did not individually provide it on the forwarding node's side.
Here, we therefore expose this additionally withheld amount via
`PaymentForwarded::skimmed_fee_msat`.

9 months agoMerge pull request #2864 from dunxen/2024-01-2797followups
dunxen [Thu, 1 Feb 2024 08:19:13 +0000 (10:19 +0200)]
Merge pull request #2864 from dunxen/2024-01-2797followups

Fix followups to PR2797

9 months agoAdd tests to check the introduced behaviour
shaavan [Wed, 31 Jan 2024 12:14:58 +0000 (17:44 +0530)]
Add tests to check the introduced behaviour

- The first test make sure that the OutboundV1Channel is not
immediately removed when peers disconnect, but is removed after N timer
ticks.
- The second test makes sure that the SendOpenChannel is rebroadcasted
for the OutboundV1Channel if peer reconnects within time.

9 months agoDo not remove Outbound Channel immediately when peer disconnects
shaavan [Sun, 10 Dec 2023 12:47:32 +0000 (18:17 +0530)]
Do not remove Outbound Channel immediately when peer disconnects

- Do not remove channel immediately when peer_disconnect, instead
  removed it after some time if peer doesn't reconnect soon (handled in
previous commit).
- Do not mark per ok_to_remove if we have some OutboundV1Channels too.
- Rebroadcast SendOpenChannel for outboundV1Channel when peer
  reconnects.
- Update the relevant tests to account for the behavior change.
- Repurpose the test_disconnect_in_funding_batch to test that all
  channels in the batch close when one them closes.

9 months agoRename `PaymentForwarded::fee_earned_msat` to `total_fee_earned_msat`
Elias Rohrer [Tue, 30 Jan 2024 08:18:28 +0000 (09:18 +0100)]
Rename `PaymentForwarded::fee_earned_msat` to `total_fee_earned_msat`

9 months agoTrack min HTLC overpay separately from skimmed fees in test utils
Valentine Wallace [Tue, 30 Jan 2024 19:43:59 +0000 (14:43 -0500)]
Track min HTLC overpay separately from skimmed fees in test utils

9 months agoStruct-ify claim_along_route args.
Valentine Wallace [Wed, 20 Dec 2023 20:45:34 +0000 (15:45 -0500)]
Struct-ify claim_along_route args.

Lays groundwork to make claim_payment* test utils easier to adapt without
changing a million callsites.

9 months agoFix followups to PR2797
Duncan Dean [Wed, 31 Jan 2024 05:58:56 +0000 (07:58 +0200)]
Fix followups to PR2797

9 months ago[bindings] Move additional score params from `&()` to `Default` 2024-01-bindings-upstream
Matt Corallo [Tue, 23 Jan 2024 06:19:24 +0000 (06:19 +0000)]
[bindings] Move additional score params from `&()` to `Default`

In 26c1639ab69d6780c97a118f09e42cb42304088a (and later in
50c55dcf32466e3ccf17acea50697fc664950deb) we switched to using
`Default::default()` to initialize `()` for scoring parameters in
tests. A number of `()`s slipped back in recently, which we replace
here.

9 months agoDrop manual `Debug` impl on RGS' `GraphSyncError`
Matt Corallo [Tue, 23 Jan 2024 19:20:05 +0000 (19:20 +0000)]
Drop manual `Debug` impl on RGS' `GraphSyncError`

As it does the same thing as a derived `Debug` does anyway.

9 months agoMove RGS `GraphSyncError` into the top-level module
Matt Corallo [Thu, 18 Jan 2024 20:53:20 +0000 (20:53 +0000)]
Move RGS `GraphSyncError` into the top-level module

The top-level module is only a few hundred lines, so there's not a
lot of reason to hide the `GraphSyncError` in its own module.
Instead, we simply move it to the top-level `lib.rs`, which doesn't
change the public API as it was previously re-exported at the top
level.

9 months agoStore `EntropySource` in `DefaultRouter` instead of passing it
Matt Corallo [Tue, 23 Jan 2024 19:49:36 +0000 (19:49 +0000)]
Store `EntropySource` in `DefaultRouter` instead of passing it

...as an arg to `Router`. Passing an `EntropySource` around all
the time is a bit strange as the `Router` may or may not actually
use it, and the `DefaultRouter` can just as easily store it.

9 months agoFix `three_hop_blinded_path_success` with different randomization
Matt Corallo [Tue, 30 Jan 2024 23:54:56 +0000 (23:54 +0000)]
Fix `three_hop_blinded_path_success` with different randomization

In `three_hop_blinded_path_success`, the nodes in the test ended up
at radically different block heights after channel opening. At that
point, if the CLTV randomization is done slightly different the
test payment may fail, which we fix here by ensuring all nodes are
at the same height before we go to send a payment.

9 months agoMerge pull request #2862 from arik-so/arik/2024/01/http-error-message-fix
Matt Corallo [Tue, 30 Jan 2024 23:36:36 +0000 (23:36 +0000)]
Merge pull request #2862 from arik-so/arik/2024/01/http-error-message-fix

Improve error message for invalid response lengths

9 months agoMerge pull request #2780 from wpaulino/2691-follow-ups
Matt Corallo [Tue, 30 Jan 2024 23:21:42 +0000 (23:21 +0000)]
Merge pull request #2780 from wpaulino/2691-follow-ups

2691 follow-ups

9 months agoMerge pull request #2797 from dunxen/2023-12-purgetochannelid
Matt Corallo [Tue, 30 Jan 2024 23:04:39 +0000 (23:04 +0000)]
Merge pull request #2797 from dunxen/2023-12-purgetochannelid

Remove `Outpoint::to_channel_id` method

9 months agoImprove error message for invalid response lengths.
Arik Sosman [Tue, 30 Jan 2024 19:43:04 +0000 (11:43 -0800)]
Improve error message for invalid response lengths.

9 months agoRemove `Outpoint::to_channel_id` method
Duncan Dean [Tue, 9 Jan 2024 07:07:01 +0000 (09:07 +0200)]
Remove `Outpoint::to_channel_id` method

To avoid confusion and for accuracy going forward, we remove this method
as it is inconsistent with channel IDs generated during V2 channel
establishment. If one wants to create a V1, funding outpoint-based
channel ID, then `ChannelId::v1_from_funding_outpoint` should be used
instead.

A large portion of the library has always made the assumption that having
the funding outpoint will always allow us to generate the channel ID.
This will not be the case anymore and we need to pass the channel ID along
where appropriate. All channels that could have been persisted up to this
point could only have used V1 establishment, so if some structures don't
store a channel ID for them they can safely fall back to the funding
outpoint-based version.

9 months agoEnforce compile-time check for flag getters and setters
Wilmer Paulino [Fri, 8 Dec 2023 19:33:06 +0000 (11:33 -0800)]
Enforce compile-time check for flag getters and setters

This ensures that we cannot define or use flag getters/setters on
`ChannelState` variants in which said flag is not valid.

9 months agoUse clear helper on flags copy to mask off bits
Wilmer Paulino [Mon, 29 Jan 2024 21:57:19 +0000 (13:57 -0800)]
Use clear helper on flags copy to mask off bits

9 months agoMerge pull request #2694 from Evanfeenstra/public-scid-utils
Matt Corallo [Thu, 25 Jan 2024 01:52:13 +0000 (01:52 +0000)]
Merge pull request #2694 from Evanfeenstra/public-scid-utils

public scid utils

9 months ago[bindings] No-export `RouteHopCandidate` lifetime'd fields
Matt Corallo [Tue, 23 Jan 2024 01:16:46 +0000 (01:16 +0000)]
[bindings] No-export `RouteHopCandidate` lifetime'd fields

The bindings cannot express lifetimes, so exposing any field which
is a reference (and not `clone`-able, at least for garbage
collected language bindings) is unsafe for those expecting a
high-level interface.

Thus, we simply no-export the `RouteHopCandidate` inner struct
fields which are references (there are relevant accessors for them
anyway).

9 months ago[bindings] Mark `WithContext` log wrapper with no-export
Matt Corallo [Thu, 18 Jan 2024 00:42:55 +0000 (00:42 +0000)]
[bindings] Mark `WithContext` log wrapper with no-export

There's not a lot of reason for downstream users to use the
`WithContext` wrapper, it mostly exists for our own downstream
crates anyway, and dealing with lifetimes in bindings isn't super
practical, so simply no-export it.

9 months ago[bindings] Drop the lifetime bound on `Record` for bindings builds
Matt Corallo [Wed, 20 Dec 2023 05:17:43 +0000 (05:17 +0000)]
[bindings] Drop the lifetime bound on `Record` for bindings builds

Because log `Record`s are now being passed by ownership to `log`,
the bindings get quite annoyed that there's a lifetime hanging
around. We already don't use this lifetime in bindings (the
`FormatArgs` is converted to a string and stored on the heap), so
we can just drop the lifetime, even though it requires some
macro'ing of the struct definition to do so.

9 months agoMerge pull request #2697 from jkczyz/2023-10-offer-functional-tests
Matt Corallo [Wed, 24 Jan 2024 23:14:01 +0000 (23:14 +0000)]
Merge pull request #2697 from jkczyz/2023-10-offer-functional-tests

Functional tests for BOLT 12 Offers payment flow

10 months agoMerge pull request #2844 from TheBlueMatt/2024-01-cut-121 v0.0.121
Matt Corallo [Mon, 22 Jan 2024 23:55:35 +0000 (23:55 +0000)]
Merge pull request #2844 from TheBlueMatt/2024-01-cut-121

Release 0.0.121

10 months agoBump versions to LDK 0.0.121/invoice 0.29 2024-01-cut-121
Matt Corallo [Mon, 22 Jan 2024 22:22:20 +0000 (22:22 +0000)]
Bump versions to LDK 0.0.121/invoice 0.29

10 months agoAdd CHANGELOG entry for 0.0.121
Matt Corallo [Mon, 22 Jan 2024 22:21:16 +0000 (22:21 +0000)]
Add CHANGELOG entry for 0.0.121

10 months agoMerge pull request #2841 from TheBlueMatt/2024-01-batch-deadlock
Matt Corallo [Mon, 22 Jan 2024 22:30:59 +0000 (22:30 +0000)]
Merge pull request #2841 from TheBlueMatt/2024-01-batch-deadlock

Fix deadlock when handling bad calls to `batch_funding.._generated`

10 months agoMerge pull request #2842 from jkczyz/2024-01-fix-peer-handler-unwrap
Matt Corallo [Mon, 22 Jan 2024 22:30:56 +0000 (22:30 +0000)]
Merge pull request #2842 from jkczyz/2024-01-fix-peer-handler-unwrap

Fix panic when peer is mid-handshake

10 months agoRemove unnecessary unwraps
Jeffrey Czyz [Mon, 22 Jan 2024 22:26:54 +0000 (16:26 -0600)]
Remove unnecessary unwraps

10 months agoFix panic when peer is mid-handshake
Jeffrey Czyz [Thu, 18 Jan 2024 21:34:19 +0000 (15:34 -0600)]
Fix panic when peer is mid-handshake

Peer::their_node_id is set to Some during the handshake process.
However, df3ab2ee2753e7f9ec02ddf1c8a51db77c50e35d accesses the field
unconditionally, causing a panic. This may be triggered if a gossip
message is received mid-handshake from another peer or if the user calls
broadcast_node_announcement during this time. The latter tends to be
executed on a timer.

Ensure that Peer::their_node_id is only accessed once the handshake is
complete.

10 months agoFix deadlock when handling bad calls to `batch_funding.._generated` 2024-01-batch-deadlock
Matt Corallo [Mon, 22 Jan 2024 20:26:32 +0000 (20:26 +0000)]
Fix deadlock when handling bad calls to `batch_funding.._generated`

When handling calls to `batch_funding_transaction_generated` which
were missing outputs for one of the batch channels, we'd previously
deadlock when trying to clean up the now-closed channels. This
fixes that and adds a new test case for it.

Found by the full_stack_target fuzzer.

10 months agopublic scid utils
Evan Feenstra [Sat, 28 Oct 2023 15:38:17 +0000 (08:38 -0700)]
public scid utils

10 months agoMerge pull request #2835 from TheBlueMatt/2024-01-cut-120
Elias Rohrer [Fri, 19 Jan 2024 20:41:51 +0000 (21:41 +0100)]
Merge pull request #2835 from TheBlueMatt/2024-01-cut-120

Change v0.0.120 release name

10 months agoChange v0.0.120 release name 2024-01-cut-120
Matt Corallo [Wed, 17 Jan 2024 23:18:47 +0000 (23:18 +0000)]
Change v0.0.120 release name

"Un"blinded makes more sense, since the fuzzer was unblinded :)

10 months agoMerge pull request #2834 from TheBlueMatt/2024-01-cut-120 v0.0.120
Matt Corallo [Wed, 17 Jan 2024 23:02:24 +0000 (23:02 +0000)]
Merge pull request #2834 from TheBlueMatt/2024-01-cut-120

Cut 0.0.120

10 months agoBump crate versions to 0.0.120/invoice 0.28
Matt Corallo [Wed, 17 Jan 2024 21:25:50 +0000 (21:25 +0000)]
Bump crate versions to 0.0.120/invoice 0.28

10 months agoAdd CHANGELOG entry for 0.0.120
Matt Corallo [Wed, 17 Jan 2024 21:00:26 +0000 (21:00 +0000)]
Add CHANGELOG entry for 0.0.120

10 months agoMerge pull request #2818 from valentinewallace/2024-01-blinded-path-retries
Matt Corallo [Wed, 17 Jan 2024 21:21:36 +0000 (21:21 +0000)]
Merge pull request #2818 from valentinewallace/2024-01-blinded-path-retries

Avoid retrying over previously failed blinded paths

10 months agoMerge pull request #2828 from TheBlueMatt/2024-01-crypto-module
valentinewallace [Wed, 17 Jan 2024 17:53:02 +0000 (12:53 -0500)]
Merge pull request #2828 from TheBlueMatt/2024-01-crypto-module

Move cryptographic algorithms and utilities to a new `crypto` mod

10 months agoTest that we won't retry over previously failed blinded paths.
Valentine Wallace [Tue, 9 Jan 2024 16:58:13 +0000 (11:58 -0500)]
Test that we won't retry over previously failed blinded paths.

10 months agoTest util: separate out code to construct a blinded path.
Valentine Wallace [Tue, 9 Jan 2024 16:53:51 +0000 (11:53 -0500)]
Test util: separate out code to construct a blinded path.

10 months agoAvoid building routes over previously failed blinded payment paths.
Valentine Wallace [Tue, 9 Jan 2024 16:52:37 +0000 (11:52 -0500)]
Avoid building routes over previously failed blinded payment paths.

10 months agoStore previously failed blinded paths on outbound payment failure.
Valentine Wallace [Tue, 9 Jan 2024 16:32:38 +0000 (11:32 -0500)]
Store previously failed blinded paths on outbound payment failure.

Useful so we don't retry over these paths.

10 months agoPersist previously failed blinded paths in RouteParameters.
Valentine Wallace [Tue, 9 Jan 2024 16:28:38 +0000 (11:28 -0500)]
Persist previously failed blinded paths in RouteParameters.

Useful so we don't retry over these paths.

10 months agoAdd failed_within_blinded_path to DecodedOnionFailure.
Valentine Wallace [Fri, 12 Jan 2024 16:35:08 +0000 (11:35 -0500)]
Add failed_within_blinded_path to DecodedOnionFailure.

Will be used to ensure correctness when we store previously failed blinded
paths to avoid retrying over them.

10 months agoAdd failed_within_blinded_path to onion util internal struct.
Valentine Wallace [Fri, 12 Jan 2024 01:11:14 +0000 (20:11 -0500)]
Add failed_within_blinded_path to onion util internal struct.

Will be used to ensure correctness when we store previously failed blinded
paths to avoid retrying over them.

10 months agoMerge pull request #2831 from jkczyz/2024-01-fix-cltv-expiry-delta
Matt Corallo [Wed, 17 Jan 2024 00:47:48 +0000 (00:47 +0000)]
Merge pull request #2831 from jkczyz/2024-01-fix-cltv-expiry-delta

Use consistent `cltv_expiry_delta` in `ForwardTlvs`

10 months agoMerge pull request #2832 from p2pderivatives/fix-ln-net-tokio-dropping-messages
Matt Corallo [Wed, 17 Jan 2024 00:37:09 +0000 (00:37 +0000)]
Merge pull request #2832 from p2pderivatives/fix-ln-net-tokio-dropping-messages

Fix lightning-net-tokio sometimes dropping messages

10 months agoMerge pull request #2812 from valentinewallace/2023-12-blinded-forwarding
Matt Corallo [Wed, 17 Jan 2024 00:28:30 +0000 (00:28 +0000)]
Merge pull request #2812 from valentinewallace/2023-12-blinded-forwarding

Complete route blinding support

10 months agoFix lightning-net-tokio sometimes dropping messages
Tibo-lg [Wed, 17 Jan 2024 00:20:30 +0000 (09:20 +0900)]
Fix lightning-net-tokio sometimes dropping messages

10 months agoUse consistent cltv_expiry_delta in ForwardTlvs
Jeffrey Czyz [Thu, 11 Jan 2024 19:13:12 +0000 (13:13 -0600)]
Use consistent cltv_expiry_delta in ForwardTlvs

When converting from CounterpartyForwardingInfo to PaymentRelay, the
cltv_expiry_delta is copied. Then, when forming a blinded payment path,
the value is mutated so that esoteric values don't reveal information
about the path. However, the value was only used in computing
PaymentConstraints and wasn't actually updated in PaymentRelay. Move the
logic for modifying the cltv_expiry_delta to the conversion code to
avoid this inconsistency.

10 months agoAdvertise route blinding feature as supported.
Valentine Wallace [Thu, 11 Jan 2024 18:47:17 +0000 (13:47 -0500)]
Advertise route blinding feature as supported.

Now that we fully support forwarding blinded payments, we should advertise
support so nodes on the network can include us in their blinded paths.

10 months agoFix sender double-including shadow offset in CLTV expiry height.
Valentine Wallace [Wed, 20 Dec 2023 19:04:04 +0000 (14:04 -0500)]
Fix sender double-including shadow offset in CLTV expiry height.

The excess delta is included in the final RouteHop::cltv_expiry_delta, so by
adding it explicitly to cur_cltv we were erroneously including it twice in the
total cltv expiry.

This could've add up to an extra MAX_SHADOW_CLTV_DELTA_OFFSET (432) blocks to
the total cltv expiry.

10 months agoRename test var to be more descriptive.
Valentine Wallace [Wed, 20 Dec 2023 19:00:17 +0000 (14:00 -0500)]
Rename test var to be more descriptive.

10 months agoComplete remaining TODOs for failing blinded non-intro forwards.
Valentine Wallace [Mon, 18 Dec 2023 19:42:07 +0000 (14:42 -0500)]
Complete remaining TODOs for failing blinded non-intro forwards.

10 months agoAdd failure mode info to BlindedForward struct.
Valentine Wallace [Mon, 18 Dec 2023 19:36:57 +0000 (14:36 -0500)]
Add failure mode info to BlindedForward struct.

See added docs.

10 months agoMove cryptographic algorithms and utilities to a new `crypto` mod 2024-01-crypto-module
Matt Corallo [Mon, 15 Jan 2024 01:25:10 +0000 (01:25 +0000)]
Move cryptographic algorithms and utilities to a new `crypto` mod

As we'd generally like the `lightning` crate to, over time, have
more modules rather than being very monolithic, we should move the
cryptographic things into their own module, which we do here.

We also take this opportunity to move stream adapters into their
own module and make clear that the ChaChaPoly `decrypt` method is
variable time.

10 months agoFix bench build warning
Jeffrey Czyz [Fri, 5 Jan 2024 05:40:43 +0000 (23:40 -0600)]
Fix bench build warning

10 months agoReorganize #[cfg(not(c_bindings))] imports
Jeffrey Czyz [Thu, 4 Jan 2024 23:39:18 +0000 (17:39 -0600)]
Reorganize #[cfg(not(c_bindings))] imports

10 months agoAdd ASCII art diagram explaining offers_tests
Jeffrey Czyz [Thu, 21 Dec 2023 00:05:42 +0000 (18:05 -0600)]
Add ASCII art diagram explaining offers_tests

10 months agoFunctional test for failing duplicate payments
Jeffrey Czyz [Wed, 20 Dec 2023 23:52:09 +0000 (17:52 -0600)]
Functional test for failing duplicate payments

10 months agoFunctional tests for failing without payment paths
Jeffrey Czyz [Wed, 20 Dec 2023 20:37:31 +0000 (14:37 -0600)]
Functional tests for failing without payment paths

10 months agoAdd Features::clear_route_blinding for testing
Jeffrey Czyz [Wed, 20 Dec 2023 20:32:53 +0000 (14:32 -0600)]
Add Features::clear_route_blinding for testing

10 months agoOffers functional tests for duplicated payment ids
Jeffrey Czyz [Tue, 19 Dec 2023 23:24:11 +0000 (17:24 -0600)]
Offers functional tests for duplicated payment ids

10 months agoFunctional tests for failing without blinded paths
Jeffrey Czyz [Tue, 19 Dec 2023 22:06:55 +0000 (16:06 -0600)]
Functional tests for failing without blinded paths

10 months agoFunctional tests for offers with blinded paths
Jeffrey Czyz [Fri, 15 Dec 2023 05:46:12 +0000 (23:46 -0600)]
Functional tests for offers with blinded paths

10 months agoFunctional tests for offers without blinded paths
Jeffrey Czyz [Fri, 3 Nov 2023 19:01:57 +0000 (14:01 -0500)]
Functional tests for offers without blinded paths

10 months agoFunctional tests for BOLT 12 Offers payment flow
Jeffrey Czyz [Tue, 31 Oct 2023 19:27:29 +0000 (14:27 -0500)]
Functional tests for BOLT 12 Offers payment flow

ChannelManager provides utilities to create offers and refunds along
with utilities to initiate and request payment for them, respectively.
It also manages the payment flow via implementing OffersMessageHandler.
Test that functionality, including the resulting event generation.

10 months agoConsolidate conditional imports
Jeffrey Czyz [Tue, 9 Jan 2024 21:05:29 +0000 (15:05 -0600)]
Consolidate conditional imports

10 months agoRemove redundant negations from feature check
Jeffrey Czyz [Tue, 9 Jan 2024 20:59:30 +0000 (14:59 -0600)]
Remove redundant negations from feature check