From 0d646b7c156aa4978593ee899ca3a354e290997f Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Thu, 14 Sep 2023 21:47:07 +0000 Subject: [PATCH] Drop `test_esplora_connects_to_public_server` `blockstream.info` is currently down, causing our CI to fail. This shouldn't really be a thing, so we drop the blockstream.info-based test here. More generally, I'm not really a fan of having tests which run (outside of CI) and call out to external servers - a developer working on LDK shouldn't have to have internet access to run our test suite and shouldn't be registering their presence with a third party to run our tests. --- .../tests/integration_tests.rs | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/lightning-transaction-sync/tests/integration_tests.rs b/lightning-transaction-sync/tests/integration_tests.rs index 151f98655..617b1213e 100644 --- a/lightning-transaction-sync/tests/integration_tests.rs +++ b/lightning-transaction-sync/tests/integration_tests.rs @@ -321,20 +321,3 @@ async fn test_esplora_syncs() { _ => panic!("Unexpected event"), } } - -#[tokio::test] -#[cfg(any(feature = "esplora-async-https", feature = "esplora-blocking"))] -async fn test_esplora_connects_to_public_server() { - let mut logger = TestLogger {}; - let esplora_url = "https://blockstream.info/api".to_string(); - let tx_sync = EsploraSyncClient::new(esplora_url, &mut logger); - let confirmable = TestConfirmable::new(); - - // Check we connect and pick up on new best blocks - assert_eq!(confirmable.best_block.lock().unwrap().1, 0); - #[cfg(feature = "esplora-async-https")] - tx_sync.sync(vec![&confirmable]).await.unwrap(); - #[cfg(feature = "esplora-blocking")] - tx_sync.sync(vec![&confirmable]).unwrap(); - assert_ne!(confirmable.best_block.lock().unwrap().1, 0); -} -- 2.39.5