From 0df01c140ebe3a49d7ddec6aa6f22f91d2e90a54 Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Wed, 3 Feb 2021 19:56:43 -0500 Subject: [PATCH] Drop stale and cleanup TODO entries in keysinterface --- lightning/src/chain/keysinterface.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/lightning/src/chain/keysinterface.rs b/lightning/src/chain/keysinterface.rs index 86b533b80..6d9a64906 100644 --- a/lightning/src/chain/keysinterface.rs +++ b/lightning/src/chain/keysinterface.rs @@ -138,8 +138,6 @@ pub enum SpendableOutputDescriptor { /// regenerated by passing the revocation_pubkey (derived as above), our delayed_payment pubkey /// (derived as above), and the to_self_delay contained here to /// chan_utils::get_revokeable_redeemscript. - // - // TODO: we need to expose utility methods in KeyManager to do all the relevant derivation. DynamicOutputP2WSH(DynamicP2WSHOutputDescriptor), /// An output to a P2WPKH, spendable exclusively by our payment key (ie the private key which /// corresponds to the public key in ChannelKeys::pubkeys().payment_point). @@ -225,14 +223,6 @@ impl Readable for SpendableOutputDescriptor { /// In any case, ChannelMonitor or fallback watchtowers are always going to be trusted /// to act, as liveness and breach reply correctness are always going to be hard requirements /// of LN security model, orthogonal of key management issues. -/// -/// If you're implementing a custom signer, you almost certainly want to implement -/// Readable/Writable to serialize out a unique reference to this set of keys so -/// that you can serialize the full ChannelManager object. -/// -// (TODO: We shouldn't require that, and should have an API to get them at deser time, due mostly -// to the possibility of reentrancy issues by calling the user's code during our deserialization -// routine). // TODO: We should remove Clone by instead requesting a new ChannelKeys copy when we create // ChannelMonitors instead of expecting to clone the one out of the Channel into the monitors. pub trait ChannelKeys : Send+Clone + Writeable { @@ -248,7 +238,7 @@ pub trait ChannelKeys : Send+Clone + Writeable { /// May be called more than once for the same index. /// /// Note that the commitment number starts at (1 << 48) - 1 and counts backwards. - /// TODO: return a Result so we can signal a validation error + // TODO: return a Result so we can signal a validation error fn release_commitment_secret(&self, idx: u64) -> [u8; 32]; /// Gets the holder's channel public keys and basepoints fn pubkeys(&self) -> &ChannelPublicKeys; -- 2.39.5