From a911ca84ebc8b44101278106cb609b607736cccc Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Wed, 13 Jul 2022 19:33:25 +0000 Subject: [PATCH] Rip out dependabot - its worse than useless - its annoying Dependabot has a ton of issues with its rust integration that makes it wholly useless, and very annoying: * It has no concept of MSRV, opening PRs that are not going to pass CI. * It has no concept of patch-level - if we depend on tokio 1.X, that means any version of tokio > 1.X, but dependabot insists on opening a PR to "update us" to tokio 1.X + 1, even though it doesn't impact what version of our users use (and often violates MSRV). * It has no concept of dependencies that rely on each other, causing it to open a PR to update us to bitcoin_hashes X + 1, even though we're still depending on rust-bitcoin Y which depends on bitcoin_hashes X, causing build failure. * It hogs CI resources, getting CI run twice, once for the branch once for the PR. * It creates branches directly on the rust-lightning repo, making it look like the work is somehow connected to the lightningdevkit project, even though it isn't, and spamming the local clones of project contributors. At the end of the day, dependabot has never meaningfully contributed to notifying us of an important dependency, and, really, we don't have enough dependencies for it to matter. --- .github/dependabot.yml | 36 ------------------------------------ 1 file changed, 36 deletions(-) delete mode 100644 .github/dependabot.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml deleted file mode 100644 index c8c6daa51..000000000 --- a/.github/dependabot.yml +++ /dev/null @@ -1,36 +0,0 @@ -# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates - -version: 2 -updates: - - package-ecosystem: "cargo" - directory: "/" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning-background-processor" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning-block-sync" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning-invoice" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning-net-tokio" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning-persister" - schedule: - interval: "daily" - - package-ecosystem: "cargo" - directory: "/lightning" - schedule: - interval: "daily" - - package-ecosystem: "github-actions" - directory: "/" - schedule: - interval: "daily" -- 2.39.5