Fix query compat with Postgres 13
[rapid-gossip-sync-server] / src / lookup.rs
index c96ef771e5cef7bb9e9875ab16c9fe97ebfb9f12..779b253d22e211bd5b06e2e48e5ed7c04fe8394a 100644 (file)
@@ -117,27 +117,24 @@ pub(super) async fn fetch_channel_announcements(delta_set: &mut DeltaSet, networ
                // here is where the channels whose first update in either direction occurred after
                // `last_seen_timestamp` are added to the selection
                let newer_oldest_directional_updates = client.query("
-               SELECT DISTINCT ON (short_channel_id) *
-               FROM (
-                       SELECT DISTINCT ON (short_channel_id, direction) blob_signed
-                       FROM channel_updates
-                       WHERE short_channel_id = any($1)
-                       ORDER BY seen ASC, short_channel_id ASC, direction ASC
-               ) AS directional_last_seens
-               ORDER BY short_channel_id ASC, seen DESC
-       ", &[&channel_ids]).await.unwrap();
+            SELECT DISTINCT ON (short_channel_id) *
+            FROM (
+                SELECT DISTINCT ON (short_channel_id, direction) short_channel_id, seen
+                FROM channel_updates
+                WHERE short_channel_id = any($1)
+                ORDER BY short_channel_id ASC, direction ASC, seen ASC
+            ) AS directional_last_seens
+            ORDER BY short_channel_id ASC, seen DESC
+        ", &[&channel_ids]).await.unwrap();
 
                for current_row in newer_oldest_directional_updates {
-                       let blob: Vec<u8> = current_row.get("blob_signed");
-                       let mut readable = Cursor::new(blob);
-                       let unsigned_update = ChannelUpdate::read(&mut readable).unwrap().contents;
-                       let scid = unsigned_update.short_channel_id;
+                       let scid: i64 = current_row.get("short_channel_id");
                        let current_seen_timestamp_object: SystemTime = current_row.get("seen");
                        let current_seen_timestamp: u32 = current_seen_timestamp_object.duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs() as u32;
 
                        if current_seen_timestamp > last_sync_timestamp {
                                // the newer of the two oldest seen directional updates came after last sync timestamp
-                               let current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
+                               let current_channel_delta = delta_set.entry(scid as u64).or_insert(ChannelDelta::default());
                                // first time a channel was seen in both directions
                                (*current_channel_delta).first_bidirectional_updates_seen = Some(current_seen_timestamp);
                        }
@@ -156,32 +153,29 @@ pub(super) async fn fetch_channel_announcements(delta_set: &mut DeltaSet, networ
                let read_only_graph = network_graph.read_only();
 
                let older_latest_directional_updates = client.query("
-               SELECT DISTINCT ON (short_channel_id) *
-               FROM (
-                       SELECT DISTINCT ON (short_channel_id, direction) *
-                       FROM channel_updates
-                       WHERE short_channel_id = any($1)
-                       ORDER BY short_channel_id ASC, direction ASC, seen DESC
-               ) AS directional_last_seens
-               ORDER BY short_channel_id ASC, seen ASC
-       ", &[&channel_ids]).await.unwrap();
+                       SELECT DISTINCT ON (short_channel_id) *
+                       FROM (
+                               SELECT DISTINCT ON (short_channel_id, direction) short_channel_id, seen
+                               FROM channel_updates
+                               WHERE short_channel_id = any($1)
+                               ORDER BY short_channel_id ASC, direction ASC, seen DESC
+                       ) AS directional_last_seens
+                       ORDER BY short_channel_id ASC, seen ASC
+               ", &[&channel_ids]).await.unwrap();
 
                for current_row in older_latest_directional_updates {
-                       let blob: Vec<u8> = current_row.get("blob_signed");
-                       let mut readable = Cursor::new(blob);
-                       let unsigned_update = ChannelUpdate::read(&mut readable).unwrap().contents;
-                       let scid = unsigned_update.short_channel_id;
+                       let scid: i64 = current_row.get("short_channel_id");
                        let current_seen_timestamp_object: SystemTime = current_row.get("seen");
                        let current_seen_timestamp: u32 = current_seen_timestamp_object.duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs() as u32;
 
                        if current_seen_timestamp <= reminder_threshold_timestamp {
                                // annotate this channel as requiring that reminders be sent to the client
-                               let current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
+                               let current_channel_delta = delta_set.entry(scid as u64).or_insert(ChannelDelta::default());
 
                                // way might be able to get away with not using this
                                (*current_channel_delta).requires_reminder = true;
 
-                               if let Some(current_channel_info) = read_only_graph.channel(scid) {
+                               if let Some(current_channel_info) = read_only_graph.channel(scid as u64) {
                                        if current_channel_info.one_to_two.is_none() || current_channel_info.two_to_one.is_none() {
                                                // we don't send reminders if we don't have bidirectional update data
                                                continue;
@@ -214,7 +208,17 @@ pub(super) async fn fetch_channel_updates(delta_set: &mut DeltaSet, client: &Cli
        // get the latest channel update in each direction prior to last_sync_timestamp, provided
        // there was an update in either direction that happened after the last sync (to avoid
        // collecting too many reference updates)
-       let reference_rows = client.query("SELECT DISTINCT ON (short_channel_id, direction) id, direction, blob_signed FROM channel_updates WHERE seen < $1 AND short_channel_id IN (SELECT short_channel_id FROM channel_updates WHERE seen >= $1 GROUP BY short_channel_id) ORDER BY short_channel_id ASC, direction ASC, seen DESC", &[&last_sync_timestamp_object]).await.unwrap();
+       let reference_rows = client.query("
+               SELECT DISTINCT ON (short_channel_id, direction) id, direction, blob_signed
+               FROM channel_updates
+               WHERE seen < $1 AND short_channel_id IN (
+                       SELECT short_channel_id
+                       FROM channel_updates
+                       WHERE seen >= $1
+                       GROUP BY short_channel_id
+               )
+               ORDER BY short_channel_id ASC, direction ASC, seen DESC
+               ", &[&last_sync_timestamp_object]).await.unwrap();
 
        println!("Fetched reference rows ({}): {:?}", reference_rows.len(), start.elapsed());
 
@@ -252,7 +256,12 @@ pub(super) async fn fetch_channel_updates(delta_set: &mut DeltaSet, client: &Cli
                intermediate_update_prefix = "DISTINCT ON (short_channel_id, direction)";
        }
 
-       let query_string = format!("SELECT {} id, direction, blob_signed, seen FROM channel_updates WHERE seen >= $1 ORDER BY short_channel_id ASC, direction ASC, seen DESC", intermediate_update_prefix);
+       let query_string = format!("
+               SELECT {} id, direction, blob_signed, seen
+               FROM channel_updates
+               WHERE seen >= $1
+               ORDER BY short_channel_id ASC, direction ASC, seen DESC
+               ", intermediate_update_prefix);
        let intermediate_updates = client.query(&query_string, &[&last_sync_timestamp_object]).await.unwrap();
        println!("Fetched intermediate rows ({}): {:?}", intermediate_updates.len(), start.elapsed());