[fktv] Correct thumbnail extraction and add the test

[youtube-dl] / youtube_dl / extractor / fktv.py

diff --git a/youtube_dl/extractor/fktv.py b/youtube_dl/extractor/fktv.py
index 93c4fd641b34a77383eb87abc8b9f6f469252704..289cbb8c87a374d82f41f2d9840f57f6c4de63dd 100644 (file)
--- a/youtube_dl/extractor/fktv.py
+++ b/youtube_dl/extractor/fktv.py
@@ -6,6 +6,7 @@ from .common import InfoExtractor
 from ..utils import (
     clean_html,
     determine_ext,
+    ExtractorError,
 )
 
 
@@ -20,6 +21,7 @@ class FKTVIE(InfoExtractor):
             'id': '1',
             'ext': 'mp4',
             'title': 'Folge 1 vom 10. April 2007',
+            'thumbnail': 're:^https?://.*\.jpg$',
         },
     }
 
@@ -27,16 +29,20 @@ class FKTVIE(InfoExtractor):
         episode = self._match_id(url)
 
         webpage = self._download_webpage('http://fernsehkritik.tv/folge-%s/play' % episode, episode)
-        title = clean_html(self._html_search_regex('<h3>([^<]+?)</h3>', webpage, 'title'))
-        matches = re.search(r'(?s)<video[^>]*poster="([^"]+)"[^>]*>(.*?)</video>', webpage)
-        if matches:
-            poster, sources = matches.groups()
-            urls = re.findall(r'(?s)<source[^>]*src="([^"]+)"[^>]*>', sources)
-            if sources:
-                formats = [{'url': url, 'format_id': determine_ext(url)} for url in urls]
-                return {
-                    'id': episode,
-                    'title': title,
-                    'formats': formats,
-                    'thumbnail': poster,
-                }
+        title = clean_html(self._html_search_regex('<h3>([^<]+)</h3>', webpage, 'title'))
+        matches = re.search(r'(?s)<video[^>]+(?:poster="([^"]+)")?[^>]*>(.*)</video>', webpage)
+        if matches is None:
+            raise ExtractorError('Unable to extract the video')
+
+        poster, sources = matches.groups()
+        if poster is None:
+            self.report_warning('unable to extract thumbnail')
+
+        urls = re.findall(r'<source[^>]+src="([^"]+)"', sources)
+        formats = [{'url': url, 'format_id': determine_ext(url)} for url in urls]
+        return {
+            'id': episode,
+            'title': title,
+            'formats': formats,
+            'thumbnail': poster,
+        }