X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=.github%2Fworkflows%2Fbuild.yml;h=440cc240399bcc9f1f5172a52e6979381fa3858a;hb=a7934d7ecee5d524ebcf2b01e84eb89adb861b10;hp=ad9d875214be579eb00c5f4db3c74ccdaf5c7f14;hpb=8e7b5905fd84999318bdcf9cbcb9cfecbf58f532;p=rust-lightning diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ad9d8752..440cc240 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -5,6 +5,7 @@ on: [push, pull_request] jobs: build: strategy: + fail-fast: false matrix: platform: [ ubuntu-latest ] toolchain: [ stable, @@ -14,21 +15,34 @@ jobs: # 1.41.0 is Debian stable 1.41.0, # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation - 1.45.2] + 1.45.2, + # 1.49.0 is MSRV for no_std builds using hashbrown + 1.49.0] include: - toolchain: stable build-net-tokio: true + build-no-std: true - toolchain: stable platform: macos-latest build-net-tokio: true + build-no-std: true - toolchain: stable platform: windows-latest build-net-tokio: true + build-no-std: true - toolchain: beta build-net-tokio: true + build-no-std: true + - toolchain: 1.36.0 + build-no-std: false + - toolchain: 1.41.0 + build-no-std: false - toolchain: 1.45.2 build-net-tokio: true + build-no-std: false coverage: true + - toolchain: 1.49.0 + build-no-std: true runs-on: ${{ matrix.platform }} steps: - name: Checkout source code @@ -47,7 +61,10 @@ jobs: run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always - name: Build on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" - run: cargo build --verbose --color always -p lightning && cargo build --verbose --color always -p lightning-invoice && cargo build --verbose --color always -p lightning-persister + run: | + cargo build --verbose --color always -p lightning + cargo build --verbose --color always -p lightning-invoice + cargo build --verbose --color always -p lightning-persister - name: Build Block Sync Clients on Rust ${{ matrix.toolchain }} with features if: "matrix.build-net-tokio && !matrix.coverage" run: | @@ -56,7 +73,6 @@ jobs: cargo build --verbose --color always --features rpc-client cargo build --verbose --color always --features rpc-client,rest-client cargo build --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Build Block Sync Clients on Rust ${{ matrix.toolchain }} with features and full code-linking for coverage generation if: matrix.coverage run: | @@ -65,16 +81,32 @@ jobs: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Test on Rust ${{ matrix.toolchain }} with net-tokio if: "matrix.build-net-tokio && !matrix.coverage" run: cargo test --verbose --color always - name: Test on Rust ${{ matrix.toolchain }} with net-tokio and full code-linking for coverage generation if: matrix.coverage run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always + - name: Test on no_std bullds Rust ${{ matrix.toolchain }} + if: "matrix.build-no-std && !matrix.coverage" + run: | + cd lightning + cargo test --verbose --color always --no-default-features --features no_std + # check if there is a conflict between no_std and the default std feature + cargo test --verbose --color always --features no_std + cd .. + - name: Test on no_std bullds Rust ${{ matrix.toolchain }} and full code-linking for coverage generation + if: "matrix.build-no-std && matrix.coverage" + run: | + cd lightning + RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --no-default-features --features no_std + cd .. - name: Test on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" - run: cargo test --verbose --color always -p lightning && cargo test --verbose --color always -p lightning-invoice && cargo build --verbose --color always -p lightning-persister + run: | + cargo test --verbose --color always -p lightning + cargo test --verbose --color always -p lightning-invoice + cargo build --verbose --color always -p lightning-persister - name: Test Block Sync Clients on Rust ${{ matrix.toolchain }} with features if: "matrix.build-net-tokio && !matrix.coverage" run: | @@ -83,7 +115,6 @@ jobs: cargo test --verbose --color always --features rpc-client cargo test --verbose --color always --features rpc-client,rest-client cargo test --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Test Block Sync Clients on Rust ${{ matrix.toolchain }} with features and full code-linking for coverage generation if: matrix.coverage run: | @@ -92,7 +123,6 @@ jobs: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client,rest-client RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Install deps for kcov if: matrix.coverage run: | @@ -143,13 +173,13 @@ jobs: id: cache-graph uses: actions/cache@v2 with: - path: lightning/net_graph-2021-02-12.bin - key: ldk-net_graph-05f0c5a0d772-2020-02-12.bin + path: lightning/net_graph-2021-05-31.bin + key: ldk-net_graph-v0.0.15-2021-05-31.bin - name: Fetch routing graph snapshot if: steps.cache-graph.outputs.cache-hit != 'true' run: | - wget -O lightning/net_graph-2021-02-12.bin https://bitcoin.ninja/ldk-net_graph-05f0c5a0d772-2020-02-12.bin - if [ "$(sha256sum lightning/net_graph-2021-02-12.bin | awk '{ print $1 }')" != "7116fca78551fedc714a604cec0ad1ca66caa77bb4d0051290258e7a10e0c6e7" ]; then + wget -O lightning/net_graph-2021-05-31.bin https://bitcoin.ninja/ldk-net_graph-v0.0.15-2021-05-31.bin + if [ "$(sha256sum lightning/net_graph-2021-05-31.bin | awk '{ print $1 }')" != "05a5361278f68ee2afd086cc04a1f927a63924be451f3221d380533acfacc303" ]; then echo "Bad hash" exit 1 fi @@ -157,6 +187,7 @@ jobs: run: | cd lightning RUSTFLAGS="--cfg=require_route_graph_test" cargo test + RUSTFLAGS="--cfg=require_route_graph_test" cargo test --features hashbrown cd .. - name: Run benchmarks on Rust ${{ matrix.toolchain }} run: | @@ -165,7 +196,9 @@ jobs: check_commits: runs-on: ubuntu-latest env: - TOOLCHAIN: stable + # rustc 1.53 regressed and panics when building our (perfectly fine) docs. + # See https://github.com/rust-lang/rust/issues/84738 + TOOLCHAIN: 1.52.1 steps: - name: Checkout source code uses: actions/checkout@v2