X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=.github%2Fworkflows%2Fbuild.yml;h=7d9cf422aca59bed4ed4bbce21b9c1507facbc20;hb=0fa18658cdd7d1510f21fd81d29aec233a55c0f8;hp=09cef0ffceb5c7d34c26c79f1f875b56a6a151f4;hpb=c9321c5ec07ee2daa895b5136e9472a42d4eff1d;p=rust-lightning diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 09cef0ff..7d9cf422 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -5,30 +5,52 @@ on: [push, pull_request] jobs: build: strategy: + fail-fast: false matrix: platform: [ ubuntu-latest ] toolchain: [ stable, beta, - # 1.30.0 is MSRV for Rust-Lightning - 1.30.0, - # 1.34.2 is Debian stable - 1.34.2, + # 1.36.0 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister + 1.36.0, + # 1.41.0 is Debian stable + 1.41.0, # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation - 1.45.2] + 1.45.2, + # 1.47.0 will be the MSRV for no_std builds using hashbrown once core2 is updated + 1.47.0] include: - toolchain: stable build-net-tokio: true + build-no-std: true - toolchain: stable platform: macos-latest build-net-tokio: true + build-no-std: true + - toolchain: beta + platform: macos-latest + build-net-tokio: true + build-no-std: true - toolchain: stable platform: windows-latest build-net-tokio: true + build-no-std: true + - toolchain: beta + platform: windows-latest + build-net-tokio: true + build-no-std: true - toolchain: beta build-net-tokio: true + build-no-std: true + - toolchain: 1.36.0 + build-no-std: false + - toolchain: 1.41.0 + build-no-std: false - toolchain: 1.45.2 build-net-tokio: true + build-no-std: false coverage: true + - toolchain: 1.47.0 + build-no-std: false runs-on: ${{ matrix.platform }} steps: - name: Checkout source code @@ -47,7 +69,10 @@ jobs: run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always - name: Build on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" - run: cargo build --verbose --color always -p lightning + run: | + cargo build --verbose --color always -p lightning + cargo build --verbose --color always -p lightning-invoice + cargo build --verbose --color always -p lightning-persister - name: Build Block Sync Clients on Rust ${{ matrix.toolchain }} with features if: "matrix.build-net-tokio && !matrix.coverage" run: | @@ -56,7 +81,6 @@ jobs: cargo build --verbose --color always --features rpc-client cargo build --verbose --color always --features rpc-client,rest-client cargo build --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Build Block Sync Clients on Rust ${{ matrix.toolchain }} with features and full code-linking for coverage generation if: matrix.coverage run: | @@ -65,16 +89,32 @@ jobs: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Test on Rust ${{ matrix.toolchain }} with net-tokio if: "matrix.build-net-tokio && !matrix.coverage" run: cargo test --verbose --color always - name: Test on Rust ${{ matrix.toolchain }} with net-tokio and full code-linking for coverage generation if: matrix.coverage run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always + - name: Test on no_std bullds Rust ${{ matrix.toolchain }} + if: "matrix.build-no-std && !matrix.coverage" + run: | + cd lightning + cargo test --verbose --color always --no-default-features --features no_std + # check if there is a conflict between no_std and the default std feature + cargo test --verbose --color always --features no_std + cd .. + - name: Test on no_std bullds Rust ${{ matrix.toolchain }} and full code-linking for coverage generation + if: "matrix.build-no-std && matrix.coverage" + run: | + cd lightning + RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --no-default-features --features no_std + cd .. - name: Test on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" - run: cargo test --verbose --color always -p lightning + run: | + cargo test --verbose --color always -p lightning + cargo test --verbose --color always -p lightning-invoice + cargo build --verbose --color always -p lightning-persister - name: Test Block Sync Clients on Rust ${{ matrix.toolchain }} with features if: "matrix.build-net-tokio && !matrix.coverage" run: | @@ -83,7 +123,6 @@ jobs: cargo test --verbose --color always --features rpc-client cargo test --verbose --color always --features rpc-client,rest-client cargo test --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Test Block Sync Clients on Rust ${{ matrix.toolchain }} with features and full code-linking for coverage generation if: matrix.coverage run: | @@ -92,7 +131,6 @@ jobs: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client,rest-client RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --features rpc-client,rest-client,tokio - cd .. - name: Install deps for kcov if: matrix.coverage run: | @@ -143,26 +181,32 @@ jobs: id: cache-graph uses: actions/cache@v2 with: - path: lightning/net_graph-2021-02-12.bin - key: net_graph-2021-02-12 + path: lightning/net_graph-2021-05-31.bin + key: ldk-net_graph-v0.0.15-2021-05-31.bin - name: Fetch routing graph snapshot if: steps.cache-graph.outputs.cache-hit != 'true' run: | - wget -O lightning/net_graph-2021-02-12.bin https://bitcoin.ninja/ldk-net_graph-879e309c128-2020-02-12.bin - if [ "$(sha256sum lightning/net_graph-2021-02-12.bin | awk '{ print $1 }')" != "890a1f80dfb6ef674a1e4ff0f23cd73d740731c395f99d85abbede0cfbb701ab" ]; then + wget -O lightning/net_graph-2021-05-31.bin https://bitcoin.ninja/ldk-net_graph-v0.0.15-2021-05-31.bin + if [ "$(sha256sum lightning/net_graph-2021-05-31.bin | awk '{ print $1 }')" != "05a5361278f68ee2afd086cc04a1f927a63924be451f3221d380533acfacc303" ]; then echo "Bad hash" exit 1 fi - - name: Run benchmarks on Rust ${{ matrix.toolchain }} + - name: Test with Network Graph on Rust ${{ matrix.toolchain }} run: | cd lightning - cargo bench --features unstable + RUSTFLAGS="--cfg=require_route_graph_test" cargo test + RUSTFLAGS="--cfg=require_route_graph_test" cargo test --features hashbrown cd .. + - name: Run benchmarks on Rust ${{ matrix.toolchain }} + run: | + cargo bench --features unstable check_commits: runs-on: ubuntu-latest env: - TOOLCHAIN: stable + # rustc 1.53 regressed and panics when building our (perfectly fine) docs. + # See https://github.com/rust-lang/rust/issues/84738 + TOOLCHAIN: 1.52.1 steps: - name: Checkout source code uses: actions/checkout@v2 @@ -204,7 +248,9 @@ jobs: - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }} run: cd fuzz && RUSTFLAGS="--cfg=fuzzing" cargo test --verbose --color always - name: Run fuzzers - run: cd fuzz && ./ci-fuzz.sh + run: cd fuzz && ./ci-fuzz.sh && cd .. + - name: Run lightning-invoice fuzzers + run: cd lightning-invoice/fuzz && RUSTFLAGS="--cfg=fuzzing" cargo test --verbose && ./ci-fuzz.sh linting: runs-on: ubuntu-latest