X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=.github%2Fworkflows%2Fbuild.yml;h=f27a2ccf863fa0348295a3f0c56810fa48280eb7;hb=08d296ad77e554147e58a524826cf78f4566ce2e;hp=d25e9a43c19ab4682e4ab75105c372d3ab35b9df;hpb=996d3d8058f2342b9e23d53f9dd81ae472822120;p=rust-lightning diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d25e9a43..f27a2ccf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,7 +12,7 @@ jobs: beta, # 1.41.1 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister 1.41.1, - # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation + # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, lightning-background-processor, and coverage generation 1.45.2, # 1.47.0 will be the MSRV for no-std builds using hashbrown once core2 is updated 1.47.0] @@ -20,34 +20,43 @@ jobs: - toolchain: stable build-net-tokio: true build-no-std: true + build-futures: true - toolchain: stable platform: macos-latest build-net-tokio: true build-no-std: true + build-futures: true - toolchain: beta platform: macos-latest build-net-tokio: true build-no-std: true + build-futures: true - toolchain: stable platform: windows-latest build-net-tokio: true build-no-std: true + build-futures: true - toolchain: beta platform: windows-latest build-net-tokio: true build-no-std: true + build-futures: true - toolchain: beta build-net-tokio: true build-no-std: true + build-futures: true - toolchain: 1.41.1 build-no-std: false test-log-variants: true + build-futures: false - toolchain: 1.45.2 build-net-old-tokio: true build-net-tokio: true build-no-std: false + build-futures: true coverage: true - toolchain: 1.47.0 + build-futures: true build-no-std: true runs-on: ${{ matrix.platform }} steps: @@ -62,6 +71,8 @@ jobs: - name: Pin tokio to 1.14 for Rust 1.45 if: "matrix.build-net-old-tokio" run: cargo update -p tokio --precise "1.14.0" --verbose + env: + CARGO_NET_GIT_FETCH_WITH_CLI: "true" - name: Build on Rust ${{ matrix.toolchain }} with net-tokio if: "matrix.build-net-tokio && !matrix.coverage" run: cargo build --verbose --color always @@ -98,7 +109,7 @@ jobs: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features rpc-client,rest-client,tokio - name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }} - if: "matrix.build-no-std" + if: "matrix.toolchain == 'stable'" run: | cd lightning && cargo test --verbose --color always --features backtrace - name: Test on Rust ${{ matrix.toolchain }} with net-tokio @@ -107,39 +118,57 @@ jobs: - name: Test on Rust ${{ matrix.toolchain }} with net-tokio and full code-linking for coverage generation if: matrix.coverage run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always - - name: Test on no-std bullds Rust ${{ matrix.toolchain }} + - name: Test no-std builds on Rust ${{ matrix.toolchain }} if: "matrix.build-no-std && !matrix.coverage" shell: bash # Default on Winblows is powershell run: | - cd lightning - cargo test --verbose --color always --no-default-features --features no-std - # check if there is a conflict between no-std and the default std feature - cargo test --verbose --color always --features no-std - # check if there is a conflict between no-std and the c_bindings cfg - RUSTFLAGS="--cfg=c_bindings" cargo test --verbose --color always --no-default-features --features=no-std - cd .. - cd lightning-invoice - cargo test --verbose --color always --no-default-features --features no-std - # check if there is a conflict between no-std and the default std feature - cargo test --verbose --color always --features no-std + for DIR in lightning lightning-invoice lightning-rapid-gossip-sync; do + cd $DIR + cargo test --verbose --color always --no-default-features --features no-std + # check if there is a conflict between no-std and the default std feature + cargo test --verbose --color always --features no-std + # check that things still pass without grind_signatures + # note that outbound_commitment_test only runs in this mode, because of hardcoded signature values + cargo test --verbose --color always --no-default-features --features std + # check if there is a conflict between no-std and the c_bindings cfg + RUSTFLAGS="--cfg=c_bindings" cargo test --verbose --color always --no-default-features --features=no-std + cd .. + done # check no-std compatibility across dependencies - cd .. cd no-std-check cargo check --verbose --color always - cd .. + - name: Build no-std-check on Rust ${{ matrix.toolchain }} for ARM Embedded + if: "matrix.build-no-std && matrix.platform == 'ubuntu-latest'" + run: | + cd no-std-check + rustup target add thumbv7m-none-eabi + sudo apt-get -y install gcc-arm-none-eabi + cargo build --target=thumbv7m-none-eabi - name: Test on no-std builds Rust ${{ matrix.toolchain }} and full code-linking for coverage generation if: "matrix.build-no-std && matrix.coverage" run: | cd lightning RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --no-default-features --features no-std - cd .. + - name: Test futures builds on Rust ${{ matrix.toolchain }} + if: "matrix.build-futures && !matrix.coverage" + shell: bash # Default on Winblows is powershell + run: | + cd lightning-background-processor + cargo test --verbose --color always --no-default-features --features futures + - name: Test futures builds on Rust ${{ matrix.toolchain }} and full code-linking for coverage generation + if: "matrix.build-futures && matrix.coverage" + shell: bash # Default on Winblows is powershell + run: | + cd lightning-background-processor + RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always --no-default-features --features futures - name: Test on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" run: | - cargo test --verbose --color always -p lightning - cargo test --verbose --color always -p lightning-invoice - cargo build --verbose --color always -p lightning-persister - cargo build --verbose --color always -p lightning-background-processor + cargo test --verbose --color always -p lightning + cargo test --verbose --color always -p lightning-invoice + cargo test --verbose --color always -p lightning-rapid-gossip-sync + cargo test --verbose --color always -p lightning-persister + cargo test --verbose --color always -p lightning-background-processor - name: Test C Bindings Modifications on Rust ${{ matrix.toolchain }} if: "! matrix.build-net-tokio" run: | @@ -188,7 +217,7 @@ jobs: done - name: Upload coverage if: matrix.coverage - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 with: # Could you use this to fake the coverage report for your PR? Sure. # Will anyone be impressed by your amazing coverage? No @@ -199,7 +228,7 @@ jobs: benchmark: runs-on: ubuntu-latest env: - TOOLCHAIN: nightly + TOOLCHAIN: stable steps: - name: Checkout source code uses: actions/checkout@v3 @@ -211,18 +240,31 @@ jobs: profile: minimal - name: Cache routing graph snapshot id: cache-graph - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: lightning/net_graph-2021-05-31.bin key: ldk-net_graph-v0.0.15-2021-05-31.bin - name: Fetch routing graph snapshot if: steps.cache-graph.outputs.cache-hit != 'true' run: | - wget -O lightning/net_graph-2021-05-31.bin https://bitcoin.ninja/ldk-net_graph-v0.0.15-2021-05-31.bin - if [ "$(sha256sum lightning/net_graph-2021-05-31.bin | awk '{ print $1 }')" != "05a5361278f68ee2afd086cc04a1f927a63924be451f3221d380533acfacc303" ]; then + curl --verbose -L -o lightning/net_graph-2021-05-31.bin https://bitcoin.ninja/ldk-net_graph-v0.0.15-2021-05-31.bin + echo "Sha sum: $(sha256sum lightning/net_graph-2021-05-31.bin | awk '{ print $1 }')" + if [ "$(sha256sum lightning/net_graph-2021-05-31.bin | awk '{ print $1 }')" != "${EXPECTED_ROUTING_GRAPH_SNAPSHOT_SHASUM}" ]; then + echo "Bad hash" + exit 1 + fi + env: + EXPECTED_ROUTING_GRAPH_SNAPSHOT_SHASUM: 05a5361278f68ee2afd086cc04a1f927a63924be451f3221d380533acfacc303 + - name: Fetch rapid graph sync reference input + run: | + curl --verbose -L -o lightning-rapid-gossip-sync/res/full_graph.lngossip https://bitcoin.ninja/ldk-compressed_graph-285cb27df79-2022-07-21.bin + echo "Sha sum: $(sha256sum lightning-rapid-gossip-sync/res/full_graph.lngossip | awk '{ print $1 }')" + if [ "$(sha256sum lightning-rapid-gossip-sync/res/full_graph.lngossip | awk '{ print $1 }')" != "${EXPECTED_RAPID_GOSSIP_SHASUM}" ]; then echo "Bad hash" exit 1 fi + env: + EXPECTED_RAPID_GOSSIP_SHASUM: e0f5d11641c11896d7af3a2246d3d6c3f1720b7d2d17aab321ecce82e6b7deb8 - name: Test with Network Graph on Rust ${{ matrix.toolchain }} run: | cd lightning @@ -231,14 +273,12 @@ jobs: cd .. - name: Run benchmarks on Rust ${{ matrix.toolchain }} run: | - cargo bench --features _bench_unstable + RUSTC_BOOTSTRAP=1 cargo bench --features _bench_unstable check_commits: runs-on: ubuntu-latest env: - # rustc 1.53 regressed and panics when building our (perfectly fine) docs. - # See https://github.com/rust-lang/rust/issues/84738 - TOOLCHAIN: 1.52.1 + TOOLCHAIN: 1.57.0 steps: - name: Checkout source code uses: actions/checkout@v3 @@ -260,6 +300,28 @@ jobs: - name: For each commit, run cargo check (including in fuzz) run: ci/check-each-commit.sh upstream/main + check_release: + runs-on: ubuntu-latest + env: + TOOLCHAIN: stable + steps: + - name: Checkout source code + uses: actions/checkout@v3 + with: + fetch-depth: 0 + - name: Install Rust ${{ env.TOOLCHAIN }} toolchain + uses: actions-rs/toolchain@v1 + with: + toolchain: ${{ env.TOOLCHAIN }} + override: true + profile: minimal + - name: Run cargo check for release build. + run: | + cargo check --release + cargo check --no-default-features --features=no-std --release + cargo check --no-default-features --features=futures --release + cargo doc --release + fuzz: runs-on: ubuntu-latest env: