X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=CONTRIBUTING.md;h=2c1fb0d8a7376db6a0b7624fa8d0c0583423c64c;hb=refs%2Fheads%2F2021-07-warning-msgs;hp=9ddd792b238c57dae399b19d0d1a7abf86e12181;hpb=58e4ce251e202cacadb82341ed16d299057fc646;p=rust-lightning diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9ddd792b..2c1fb0d8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,8 +21,8 @@ Communication about Rust-Lightning happens primarily on #ldk-dev on the Discussion about code base improvements happens in GitHub issues and on pull requests. -Major projects are tracked [here](https://github.com/rust-bitcoin/rust-lightning/projects). -Major milestones are tracked [here](https://github.com/rust-bitcoin/rust-lightning/milestones?direction=asc&sort=title&state=open). +Major projects are tracked [here](https://github.com/lightningdevkit/rust-lightning/projects). +Major milestones are tracked [here](https://github.com/lightningdevkit/rust-lightning/milestones?direction=asc&sort=title&state=open). Getting Started --------------- @@ -33,7 +33,7 @@ This doesn't mean don't be ambitious with the breadth and depth of your contribu understand the project culture before investing an asymmetric number of hours on development compared to your merged work. -Browsing through the [meeting minutes](https://github.com/rust-bitcoin/rust-lightning/wiki/Meetings) +Browsing through the [meeting minutes](https://github.com/lightningdevkit/rust-lightning/wiki/Meetings) is a good first step. You will learn who is working on what, how releases are drafted, what are the pending tasks to deliver, where you can contribute review bandwidth, etc. @@ -113,6 +113,14 @@ rustup component add clippy cargo clippy ``` +Significant structures that users persist should always have their serialization methods (usually +`Writeable::write` and `ReadableArgs::read`) begin with +`write_ver_prefix!()`/`read_ver_prefix!()` calls, and end with calls to +`write_tlv_fields!()`/`read_tlv_fields!()`. + +Updates to the serialized format which has implications for backwards or forwards compatibility +must be included in release notes. + Security --------