X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=lightning%2Fsrc%2Fln%2Fblinded_payment_tests.rs;h=2eacdc839d0d31c21991642cb7e1bc9f759540a2;hb=b767d379c118228994706ba4ef589aee91c87bbd;hp=826eaa86f48f1dd073a57d11dbb0831129b99e27;hpb=cd16cdd806ca3806e4c42868d5ef0b53caaad2e5;p=rust-lightning diff --git a/lightning/src/ln/blinded_payment_tests.rs b/lightning/src/ln/blinded_payment_tests.rs index 826eaa86..2eacdc83 100644 --- a/lightning/src/ln/blinded_payment_tests.rs +++ b/lightning/src/ln/blinded_payment_tests.rs @@ -7,18 +7,66 @@ // You may not use this file except in accordance with one or both of these // licenses. -use bitcoin::secp256k1::Secp256k1; +use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey}; use crate::blinded_path::BlindedPath; -use crate::blinded_path::payment::{PaymentConstraints, ReceiveTlvs}; +use crate::blinded_path::payment::{ForwardNode, ForwardTlvs, PaymentConstraints, PaymentRelay, ReceiveTlvs}; use crate::events::MessageSendEventsProvider; +use crate::ln::PaymentSecret; use crate::ln::channelmanager; use crate::ln::channelmanager::{PaymentId, RecipientOnionFields}; -use crate::ln::features::Bolt12InvoiceFeatures; +use crate::ln::features::BlindedHopFeatures; use crate::ln::functional_test_utils::*; +use crate::ln::msgs; +use crate::ln::msgs::ChannelMessageHandler; +use crate::ln::onion_utils; +use crate::ln::onion_utils::INVALID_ONION_BLINDING; use crate::ln::outbound_payment::Retry; use crate::prelude::*; use crate::routing::router::{PaymentParameters, RouteParameters}; use crate::util::config::UserConfig; +use crate::util::test_utils; + +pub fn get_blinded_route_parameters( + amt_msat: u64, payment_secret: PaymentSecret, node_ids: Vec, + channel_upds: &[&msgs::UnsignedChannelUpdate], keys_manager: &test_utils::TestKeysInterface +) -> RouteParameters { + let mut intermediate_nodes = Vec::new(); + for (node_id, chan_upd) in node_ids.iter().zip(channel_upds) { + intermediate_nodes.push(ForwardNode { + node_id: *node_id, + tlvs: ForwardTlvs { + short_channel_id: chan_upd.short_channel_id, + payment_relay: PaymentRelay { + cltv_expiry_delta: chan_upd.cltv_expiry_delta, + fee_proportional_millionths: chan_upd.fee_proportional_millionths, + fee_base_msat: chan_upd.fee_base_msat, + }, + payment_constraints: PaymentConstraints { + max_cltv_expiry: u32::max_value(), + htlc_minimum_msat: chan_upd.htlc_minimum_msat, + }, + features: BlindedHopFeatures::empty(), + }, + htlc_maximum_msat: chan_upd.htlc_maximum_msat, + }); + } + let payee_tlvs = ReceiveTlvs { + payment_secret, + payment_constraints: PaymentConstraints { + max_cltv_expiry: u32::max_value(), + htlc_minimum_msat: channel_upds.last().unwrap().htlc_minimum_msat, + }, + }; + let mut secp_ctx = Secp256k1::new(); + let blinded_path = BlindedPath::new_for_payment( + &intermediate_nodes[..], *node_ids.last().unwrap(), payee_tlvs, + channel_upds.last().unwrap().htlc_maximum_msat, keys_manager, &secp_ctx + ).unwrap(); + + RouteParameters::from_payment_params_and_value( + PaymentParameters::blinded(vec![blinded_path]), amt_msat + ) +} #[test] fn one_hop_blinded_path() { @@ -47,10 +95,10 @@ fn do_one_hop_blinded_path(success: bool) { nodes[1].node.get_our_node_id(), payee_tlvs, &chanmon_cfgs[1].keys_manager, &secp_ctx ).unwrap(); - let route_params = RouteParameters { - payment_params: PaymentParameters::blinded(vec![blinded_path]), - final_value_msat: amt_msat - }; + let route_params = RouteParameters::from_payment_params_and_value( + PaymentParameters::blinded(vec![blinded_path]), + amt_msat, + ); nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap(); check_added_monitors(&nodes[0], 1); @@ -88,13 +136,12 @@ fn mpp_to_one_hop_blinded_path() { nodes[3].node.get_our_node_id(), payee_tlvs, &chanmon_cfgs[3].keys_manager, &secp_ctx ).unwrap(); - let bolt12_features: Bolt12InvoiceFeatures = - channelmanager::provided_invoice_features(&UserConfig::default()).to_context(); - let route_params = RouteParameters { - payment_params: PaymentParameters::blinded(vec![blinded_path]) - .with_bolt12_features(bolt12_features).unwrap(), - final_value_msat: amt_msat, - }; + let bolt12_features = + channelmanager::provided_bolt12_invoice_features(&UserConfig::default()); + let route_params = RouteParameters::from_payment_params_and_value( + PaymentParameters::blinded(vec![blinded_path]).with_bolt12_features(bolt12_features).unwrap(), + amt_msat, + ); nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap(); check_added_monitors(&nodes[0], 2); @@ -111,3 +158,137 @@ fn mpp_to_one_hop_blinded_path() { Some(payment_secret), ev.clone(), true, None); claim_payment_along_route(&nodes[0], expected_route, false, payment_preimage); } + +enum ForwardCheckFail { + // Fail a check on the inbound onion payload. In this case, we underflow when calculating the + // outgoing cltv_expiry. + InboundOnionCheck, + // The forwarding node's payload is encoded as a receive, i.e. the next hop HMAC is [0; 32]. + ForwardPayloadEncodedAsReceive, + // Fail a check on the outbound channel. In this case, our next-hop peer is offline. + OutboundChannelCheck, +} + +#[test] +fn forward_checks_failure() { + do_forward_checks_failure(ForwardCheckFail::InboundOnionCheck); + do_forward_checks_failure(ForwardCheckFail::ForwardPayloadEncodedAsReceive); + do_forward_checks_failure(ForwardCheckFail::OutboundChannelCheck); +} + +fn do_forward_checks_failure(check: ForwardCheckFail) { + // Ensure we'll fail backwards properly if a forwarding check fails on initial update_add + // receipt. + let chanmon_cfgs = create_chanmon_cfgs(3); + let node_cfgs = create_node_cfgs(3, &chanmon_cfgs); + let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]); + let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs); + // We need the session priv to construct a bogus onion packet later. + *nodes[0].keys_manager.override_random_bytes.lock().unwrap() = Some([3; 32]); + create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0); + let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents; + + let amt_msat = 5000; + let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None); + let route_params = get_blinded_route_parameters(amt_msat, payment_secret, + nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2], + &chanmon_cfgs[2].keys_manager); + + let route = get_route(&nodes[0], &route_params).unwrap(); + node_cfgs[0].router.expect_find_route(route_params.clone(), Ok(route.clone())); + nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap(); + check_added_monitors(&nodes[0], 1); + + let mut events = nodes[0].node.get_and_clear_pending_msg_events(); + assert_eq!(events.len(), 1); + let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events); + let mut payment_event = SendEvent::from_event(ev); + + let mut update_add = &mut payment_event.msgs[0]; + match check { + ForwardCheckFail::InboundOnionCheck => { + update_add.cltv_expiry = 10; // causes outbound CLTV expiry to underflow + }, + ForwardCheckFail::ForwardPayloadEncodedAsReceive => { + let session_priv = SecretKey::from_slice(&[3; 32]).unwrap(); + let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap(); + let cur_height = nodes[0].best_block_info().1; + let (mut onion_payloads, ..) = onion_utils::build_onion_payloads( + &route.paths[0], amt_msat, RecipientOnionFields::spontaneous_empty(), cur_height, &None).unwrap(); + // Remove the receive payload so the blinded forward payload is encoded as a final payload + // (i.e. next_hop_hmac == [0; 32]) + onion_payloads.pop(); + update_add.onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash).unwrap(); + }, + ForwardCheckFail::OutboundChannelCheck => { + // The intro node will see that the next-hop peer is disconnected and fail the HTLC backwards. + nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id()); + }, + } + nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]); + check_added_monitors!(nodes[1], 0); + do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, true, true); + + let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()); + nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]); + do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false); + expect_payment_failed_conditions(&nodes[0], payment_hash, false, + PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32])); +} + +#[test] +fn failed_backwards_to_intro_node() { + // Ensure the intro node will error backwards properly even if the downstream node did not blind + // their error. + let chanmon_cfgs = create_chanmon_cfgs(3); + let node_cfgs = create_node_cfgs(3, &chanmon_cfgs); + let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]); + let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs); + create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0); + let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents; + + let amt_msat = 5000; + let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None); + let route_params = get_blinded_route_parameters(amt_msat, payment_secret, + nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2], + &chanmon_cfgs[2].keys_manager); + + nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap(); + check_added_monitors(&nodes[0], 1); + + let mut events = nodes[0].node.get_and_clear_pending_msg_events(); + assert_eq!(events.len(), 1); + let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events); + let mut payment_event = SendEvent::from_event(ev); + + nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]); + check_added_monitors!(nodes[1], 0); + do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, false, false); + expect_pending_htlcs_forwardable!(nodes[1]); + check_added_monitors!(&nodes[1], 1); + + let mut events = nodes[1].node.get_and_clear_pending_msg_events(); + assert_eq!(events.len(), 1); + let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events); + let mut payment_event = SendEvent::from_event(ev); + + // Ensure the final node fails to handle the HTLC. + payment_event.msgs[0].onion_routing_packet.hop_data[0] ^= 1; + nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]); + check_added_monitors!(nodes[2], 0); + do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event.commitment_msg, true, true); + nodes[2].node.process_pending_htlc_forwards(); + + let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id()); + let mut update_malformed = &mut updates.update_fail_malformed_htlcs[0]; + // Ensure the final hop does not correctly blind their error. + update_malformed.sha256_of_onion = [1; 32]; + nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed); + do_commitment_signed_dance(&nodes[1], &nodes[2], &updates.commitment_signed, true, false); + + let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()); + nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]); + do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false); + expect_payment_failed_conditions(&nodes[0], payment_hash, false, + PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32])); +}