X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=lightning%2Fsrc%2Fonion_message%2Ffunctional_tests.rs;h=40b6177921fb144a66924707fab1101a2a0dced0;hb=3ccf06416091e107f443ee92027501105c48054b;hp=0c2342ca15403f31a6bd7e35808951802bfd12bb;hpb=b95cfed7bb230d6eea26a404f58070f3affd911f;p=rust-lightning

diff --git a/lightning/src/onion_message/functional_tests.rs b/lightning/src/onion_message/functional_tests.rs
index 0c2342ca..40b61779 100644
--- a/lightning/src/onion_message/functional_tests.rs
+++ b/lightning/src/onion_message/functional_tests.rs
@@ -19,11 +19,12 @@ use crate::routing::test_utils::{add_channel, add_or_update_node};
 use crate::sign::{NodeSigner, Recipient};
 use crate::util::ser::{FixedLengthReader, LengthReadable, Writeable, Writer};
 use crate::util::test_utils;
+use super::async_payments::{AsyncPaymentsMessageHandler, HeldHtlcAvailable, ReleaseHeldHtlc};
 use super::messenger::{CustomOnionMessageHandler, DefaultMessageRouter, Destination, OnionMessagePath, OnionMessenger, PendingOnionMessage, Responder, ResponseInstruction, SendError, SendSuccess};
 use super::offers::{OffersMessage, OffersMessageHandler};
 use super::packet::{OnionMessageContents, Packet};
 
-use bitcoin::network::constants::Network;
+use bitcoin::network::Network;
 use bitcoin::hashes::hex::FromHex;
 use bitcoin::secp256k1::{All, PublicKey, Secp256k1, SecretKey};
 
@@ -50,6 +51,7 @@ struct MessengerNode {
 			Arc<test_utils::TestKeysInterface>
 		>>,
 		Arc<TestOffersMessageHandler>,
+		Arc<TestAsyncPaymentsMessageHandler>,
 		Arc<TestCustomMessageHandler>
 	>,
 	custom_message_handler: Arc<TestCustomMessageHandler>,
@@ -79,6 +81,17 @@ impl OffersMessageHandler for TestOffersMessageHandler {
 	}
 }
 
+struct TestAsyncPaymentsMessageHandler {}
+
+impl AsyncPaymentsMessageHandler for TestAsyncPaymentsMessageHandler {
+	fn held_htlc_available(
+		&self, _message: HeldHtlcAvailable, _responder: Option<Responder>,
+	) -> ResponseInstruction<ReleaseHeldHtlc> {
+		ResponseInstruction::NoResponse
+	}
+	fn release_held_htlc(&self, _message: ReleaseHeldHtlc) {}
+}
+
 #[derive(Clone, Debug, PartialEq)]
 enum TestCustomMessage {
 	Ping,
@@ -249,18 +262,19 @@ fn create_nodes_using_cfgs(cfgs: Vec<MessengerCfg>) -> Vec<MessengerNode> {
 			DefaultMessageRouter::new(network_graph.clone(), entropy_source.clone())
 		);
 		let offers_message_handler = Arc::new(TestOffersMessageHandler {});
+		let async_payments_message_handler = Arc::new(TestAsyncPaymentsMessageHandler {});
 		let custom_message_handler = Arc::new(TestCustomMessageHandler::new());
 		let messenger = if cfg.intercept_offline_peer_oms {
 			OnionMessenger::new_with_offline_peer_interception(
 				entropy_source.clone(), node_signer.clone(), logger.clone(),
 				node_id_lookup, message_router, offers_message_handler,
-				custom_message_handler.clone()
+				async_payments_message_handler, custom_message_handler.clone()
 			)
 		} else {
 			OnionMessenger::new(
 				entropy_source.clone(), node_signer.clone(), logger.clone(),
 				node_id_lookup, message_router, offers_message_handler,
-				custom_message_handler.clone()
+				async_payments_message_handler, custom_message_handler.clone()
 			)
 		};
 		nodes.push(MessengerNode {
@@ -437,6 +451,74 @@ fn async_response_over_one_blinded_hop() {
 	pass_along_path(&nodes);
 }
 
+#[test]
+fn async_response_with_reply_path_succeeds() {
+	// Simulate an asynchronous interaction between two nodes, Alice and Bob.
+	// Create a channel between the two nodes to establish them as announced nodes,
+	// which allows the creation of the reply_path for successful communication.
+
+	let mut nodes = create_nodes(2);
+	let alice = &nodes[0];
+	let bob = &nodes[1];
+	let secp_ctx = Secp256k1::new();
+
+	add_channel_to_graph(alice, bob, &secp_ctx, 24);
+
+	// Alice receives a message from Bob with an added reply_path for responding back.
+	let message = TestCustomMessage::Ping;
+	let path_id = Some([2; 32]);
+	let reply_path = BlindedPath::new_for_message(&[], bob.node_id, &*bob.entropy_source, &secp_ctx).unwrap();
+
+	// Alice asynchronously responds to Bob, expecting a response back from him.
+	let responder = Responder::new(reply_path, path_id);
+	alice.custom_message_handler.expect_message_and_response(message.clone());
+	let response_instruction = alice.custom_message_handler.handle_custom_message(message, Some(responder));
+
+	assert_eq!(
+		alice.messenger.handle_onion_message_response(response_instruction),
+		Ok(Some(SendSuccess::Buffered)),
+	);
+
+	// Set Bob's expectation and pass the Onion Message along the path.
+	bob.custom_message_handler.expect_message(TestCustomMessage::Pong);
+	pass_along_path(&nodes);
+
+	// Bob responds back to Alice using the reply_path she included with the OnionMessage.
+	// Set Alice's expectation and reverse the path for the response.
+	alice.custom_message_handler.expect_message(TestCustomMessage::Ping);
+	nodes.reverse();
+	pass_along_path(&nodes);
+}
+
+#[test]
+fn async_response_with_reply_path_fails() {
+	// Simulate an asynchronous interaction between two unannounced nodes, Alice and Bob.
+	// Since the nodes are unannounced, attempting to respond using a reply_path
+	// will fail, leading to an expected failure in communication.
+
+	let nodes = create_nodes(2);
+	let alice = &nodes[0];
+	let bob = &nodes[1];
+	let secp_ctx = Secp256k1::new();
+
+	// Alice receives a message from Bob with an added reply_path for responding back.
+	let message = TestCustomMessage::Ping;
+	let path_id = Some([2; 32]);
+	let reply_path = BlindedPath::new_for_message(&[], bob.node_id, &*bob.entropy_source, &secp_ctx).unwrap();
+
+	// Alice tries to asynchronously respond to Bob, but fails because the nodes are unannounced and
+	// disconnected. Thus, a reply path could no be created for the response.
+	disconnect_peers(alice, bob);
+	let responder = Responder::new(reply_path, path_id);
+	alice.custom_message_handler.expect_message_and_response(message.clone());
+	let response_instruction = alice.custom_message_handler.handle_custom_message(message, Some(responder));
+
+	assert_eq!(
+		alice.messenger.handle_onion_message_response(response_instruction),
+		Err(SendError::PathNotFound),
+	);
+}
+
 #[test]
 fn too_big_packet_error() {
 	// Make sure we error as expected if a packet is too big to send.