X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=lightning%2Fsrc%2Futil%2Fconfig.rs;h=d5ff2885cc4ae4131c95a63a9b8ab2095fd7bb15;hb=dac8b7b399d020bc79a6a6c4a119345da0ee8acd;hp=712b5937bab7ea2517f41cef155a7fe8d707c2b9;hpb=4441a06dee6967fd9667f8d07a666b3ed7ed1a3a;p=rust-lightning diff --git a/lightning/src/util/config.rs b/lightning/src/util/config.rs index 712b5937..d5ff2885 100644 --- a/lightning/src/util/config.rs +++ b/lightning/src/util/config.rs @@ -15,7 +15,7 @@ use ln::channelmanager::{BREAKDOWN_TIMEOUT, MAX_LOCAL_BREAKDOWN_TIMEOUT}; /// Configuration we set when applicable. /// /// Default::default() provides sane defaults. -#[derive(Clone, Debug)] +#[derive(Copy, Clone, Debug)] pub struct ChannelHandshakeConfig { /// Confirmations we will wait for before considering the channel locked in. /// Applied only for inbound channels (see ChannelHandshakeLimits::max_minimum_depth for the @@ -23,18 +23,21 @@ pub struct ChannelHandshakeConfig { /// /// Default value: 6. pub minimum_depth: u32, - /// Set to the amount of time we require our counterparty to wait to claim their money. + /// Set to the number of blocks we require our counterparty to wait to claim their money (ie + /// the number of blocks we have to punish our counterparty if they broadcast a revoked + /// transaction). /// - /// It's one of the main parameter of our security model. We (or one of our watchtowers) MUST - /// be online to check for peer having broadcast a revoked transaction to steal our funds - /// at least once every our_to_self_delay blocks. + /// This is one of the main parameters of our security model. We (or one of our watchtowers) MUST + /// be online to check for revoked transactions on-chain at least once every our_to_self_delay + /// blocks (minus some margin to allow us enough time to broadcast and confirm a transaction, + /// possibly with time in between to RBF the spending transaction). /// /// Meanwhile, asking for a too high delay, we bother peer to freeze funds for nothing in /// case of an honest unilateral channel close, which implicitly decrease the economic value of /// our channel. /// - /// Default value: BREAKDOWN_TIMEOUT (currently 144), we enforce it as a minimum at channel - /// opening so you can tweak config to ask for more security, not less. + /// Default value: [`BREAKDOWN_TIMEOUT`], we enforce it as a minimum at channel opening so you + /// can tweak config to ask for more security, not less. pub our_to_self_delay: u16, /// Set to the smallest value HTLC we will accept to process. /// @@ -95,22 +98,6 @@ pub struct ChannelHandshakeLimits { /// /// Default value: 0. pub min_max_accepted_htlcs: u16, - /// Outputs below a certain value will not be added to on-chain transactions. The dust value is - /// required to always be higher than this value so this only applies to HTLC outputs (and - /// potentially to-self outputs before any payments have been made). - /// Thus, HTLCs below this amount plus HTLC transaction fees are not enforceable on-chain. - /// This setting allows you to set a minimum dust limit for their commitment transactions, - /// reflecting the reality that tiny outputs are not considered standard transactions and will - /// not propagate through the Bitcoin network. - /// - /// Default value: 546, the current dust limit on the Bitcoin network. - pub min_dust_limit_satoshis: u64, - /// Maximum allowed threshold above which outputs will not be generated in their commitment - /// transactions. - /// HTLCs below this amount plus HTLC transaction fees are not enforceable on-chain. - /// - /// Default value: u64::max_value. - pub max_dust_limit_satoshis: u64, /// Before a channel is usable the funding transaction will need to be confirmed by at least a /// certain number of blocks, specified by the node which is not the funder (as the funder can /// assume they aren't going to double-spend themselves). @@ -129,8 +116,8 @@ pub struct ChannelHandshakeLimits { /// Not checking this value would be a security issue, as our peer would be able to set it to /// max relative lock-time (a year) and we would "lose" money as it would be locked for a long time. /// - /// Default value: MAX_LOCAL_BREAKDOWN_TIMEOUT (1008), which we also enforce as a maximum value - /// so you can tweak config to reduce the loss of having useless locked funds (if your peer accepts) + /// Default value: 2016, which we also enforce as a maximum value so you can tweak config to + /// reduce the loss of having useless locked funds (if your peer accepts) pub their_to_self_delay: u16 } @@ -142,8 +129,6 @@ impl Default for ChannelHandshakeLimits { min_max_htlc_value_in_flight_msat: 0, max_channel_reserve_satoshis: ::max_value(), min_max_accepted_htlcs: 0, - min_dust_limit_satoshis: 546, - max_dust_limit_satoshis: ::max_value(), max_minimum_depth: 144, force_announced_channel_preference: true, their_to_self_delay: MAX_LOCAL_BREAKDOWN_TIMEOUT, @@ -161,6 +146,26 @@ pub struct ChannelConfig { /// /// Default value: 0. pub fee_proportional_millionths: u32, + /// The difference in the CLTV value between incoming HTLCs and an outbound HTLC forwarded over + /// the channel this config applies to. + /// + /// This is analogous to [`ChannelHandshakeConfig::our_to_self_delay`] but applies to in-flight + /// HTLC balance when a channel appears on-chain whereas + /// [`ChannelHandshakeConfig::our_to_self_delay`] applies to the remaining + /// (non-HTLC-encumbered) balance. + /// + /// Thus, for HTLC-encumbered balances to be enforced on-chain when a channel is force-closed, + /// we (or one of our watchtowers) MUST be online to check for broadcast of the current + /// commitment transaction at least once per this many blocks (minus some margin to allow us + /// enough time to broadcast and confirm a transaction, possibly with time in between to RBF + /// the spending transaction). + /// + /// Default value: 72 (12 hours at an average of 6 blocks/hour). + /// Minimum value: [`MIN_CLTV_EXPIRY_DELTA`], any values less than this will be treated as + /// [`MIN_CLTV_EXPIRY_DELTA`] instead. + /// + /// [`MIN_CLTV_EXPIRY_DELTA`]: crate::ln::channelmanager::MIN_CLTV_EXPIRY_DELTA + pub cltv_expiry_delta: u16, /// Set to announce the channel publicly and notify all nodes that they can route via this /// channel. /// @@ -192,24 +197,25 @@ impl Default for ChannelConfig { fn default() -> Self { ChannelConfig { fee_proportional_millionths: 0, + cltv_expiry_delta: 6 * 12, // 6 blocks/hour * 12 hours announced_channel: false, commit_upfront_shutdown_pubkey: true, } } } -//Add write and readable traits to channelconfig -impl_writeable!(ChannelConfig, 8+1+1, { - fee_proportional_millionths, - announced_channel, - commit_upfront_shutdown_pubkey +impl_writeable_tlv_based!(ChannelConfig, { + (0, fee_proportional_millionths, required), + (2, cltv_expiry_delta, required), + (4, announced_channel, required), + (6, commit_upfront_shutdown_pubkey, required), }); /// Top-level config which holds ChannelHandshakeLimits and ChannelConfig. /// /// Default::default() provides sane defaults for most configurations /// (but currently with 0 relay fees!) -#[derive(Clone, Debug)] +#[derive(Copy, Clone, Debug)] pub struct UserConfig { /// Channel config that we propose to our counterparty. pub own_channel_config: ChannelHandshakeConfig,