X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=blobdiff_plain;f=test%2Fhelper.py;h=bdd7acca4d91c490f29c21aeac7cc9ba01c86952;hb=e38cafe986994d65230e6518752def8b53ad7308;hp=e50d7ff286ce7649b31554168d45e9e78cda834a;hpb=40c931de4b3c06c1959362c2380f4bf243ef5702;p=youtube-dl diff --git a/test/helper.py b/test/helper.py index e50d7ff28..bdd7acca4 100644 --- a/test/helper.py +++ b/test/helper.py @@ -120,23 +120,24 @@ def expect_value(self, got, expected, field): contains_str in got, 'field %s (value: %r) should contain %r' % (field, got, contains_str)) elif isinstance(expected, type): - self.assertTrue(isinstance(got, expected), - 'Expected type %r for field %s, but got value %r of type %r' % (expected, field, got, type(got))) + self.assertTrue( + isinstance(got, expected), + 'Expected type %r for field %s, but got value %r of type %r' % (expected, field, got, type(got))) elif isinstance(expected, dict) and isinstance(got, dict): expect_dict(self, got, expected) elif isinstance(expected, list) and isinstance(got, list): - self.assertEqual(len(expected), len(got), - 'Expect a list of length %d, but got a list of length %d' % ( - len(expected), len(got))) - _id = 0 - for i, j in zip(got, expected): - _type_i = type(i) - _type_j = type(j) - self.assertEqual(_type_j, _type_i, - 'Type doesn\'t match at element %d of the list in field %s, expect %s, got %s' % ( - _id, field, _type_j, _type_i)) - expect_value(self, i, j, field) - _id += 1 + self.assertEqual( + len(expected), len(got), + 'Expect a list of length %d, but got a list of length %d for field %s' % ( + len(expected), len(got), field)) + for index, (item_got, item_expected) in enumerate(zip(got, expected)): + type_got = type(item_got) + type_expected = type(item_expected) + self.assertEqual( + type_expected, type_got, + 'Type mismatch for list item at index %d for field %s, expected %r, got %r' % ( + index, field, type_expected, type_got)) + expect_value(self, item_got, item_expected, field) else: if isinstance(expected, compat_str) and expected.startswith('md5:'): got = 'md5:' + md5(got) @@ -148,13 +149,11 @@ def expect_value(self, got, expected, field): expected_num = int(expected.partition(':')[2]) assertGreaterEqual( self, len(got), expected_num, - 'Expected %d items in field %s, but only got %d' % ( - expected_num, field, len(got) - ) - ) + 'Expected %d items in field %s, but only got %d' % (expected_num, field, len(got))) return - self.assertEqual(expected, got, - 'invalid value for field %s, expected %r, got %r' % (field, expected, got)) + self.assertEqual( + expected, got, + 'Invalid value for field %s, expected %r, got %r' % (field, expected, got)) def expect_dict(self, got_dict, expected_dict):