]> git.bitcoin.ninja Git - rust-lightning/commit
Track incoming UpdateAddHTLC until HTLC resolution
authorWilmer Paulino <wilmer@wilmerpaulino.com>
Mon, 22 Jan 2024 23:24:51 +0000 (15:24 -0800)
committerWilmer Paulino <wilmer@wilmerpaulino.com>
Wed, 27 Mar 2024 21:27:59 +0000 (14:27 -0700)
commit4ad00f4074bfaf3ae5e6aa816aaa488d473624ed
tree79a95811888e67848556729fb22b4a4af4ec9ac3
parentc096a2416116b8249c3d45deeff03b154742b1c7
Track incoming UpdateAddHTLC until HTLC resolution

This commit serves as a stepping stone to moving towards resolving HTLCs
once the HTLC has been fully committed to by both sides.

Currently, we decode HTLC onions immediately upon receiving an
`update_add_htlc`. Doing so determines what we should do with the HTLC:
forward it, or immediately fail it back if it cannot be accepted. This
action is tracked until the HTLC is fully committed to by both sides,
and a new commitment in the latter case is proposed to fully remove the
HTLC. While this has worked so far, it has some minor privacy
implications, as forwarding/failing back do not go through the usual
`PendingHTLCsForwardable` flow. It also presents issues with the
quiescence handshake, as failures through this path do not go through
the holding cell abstraction, leading to a potential violation of the
handshake by sending an `update_fail_*` after already having sent
`stfu`.

Since `pending_inbound_htlcs` are written pre-TLVs, we introduce a new
serialization version in which we change the `PendingHTLCStatus`
serialization of
`InboundHTLC::AwaitingRemoteRevokeToRemove/AwaitingRemovedRemoteRevoke`
to be an option instead. We'll still write it as the current version
(`MIN_SERIALIZATION_VERSION`), but we'll support reading the new version
to allow users to downgrade back to this commit.
lightning/src/ln/channel.rs
lightning/src/util/ser.rs