projects
/
youtube-dl
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
1220352
)
[YouTubeDL] Best practices (Closes #3370)
author
Philipp Hagemeister
<phihag@phihag.de>
Fri, 25 Jul 2014 21:37:32 +0000
(23:37 +0200)
committer
Philipp Hagemeister
<phihag@phihag.de>
Fri, 25 Jul 2014 21:37:32 +0000
(23:37 +0200)
youtube_dl/YoutubeDL.py
patch
|
blob
|
history
diff --git
a/youtube_dl/YoutubeDL.py
b/youtube_dl/YoutubeDL.py
index f295174cf32c9c9289ff97652d2228b17f701395..14a1d06ab1ed3350547822cac71501745a14842a 100755
(executable)
--- a/
youtube_dl/YoutubeDL.py
+++ b/
youtube_dl/YoutubeDL.py
@@
-275,7
+275,7
@@
class YoutubeDL(object):
return message
assert hasattr(self, '_output_process')
return message
assert hasattr(self, '_output_process')
- assert
type(message) == type(''
)
+ assert
isinstance(message, compat_str
)
line_count = message.count('\n') + 1
self._output_process.stdin.write((message + '\n').encode('utf-8'))
self._output_process.stdin.flush()
line_count = message.count('\n') + 1
self._output_process.stdin.write((message + '\n').encode('utf-8'))
self._output_process.stdin.flush()
@@
-303,7
+303,7
@@
class YoutubeDL(object):
def to_stderr(self, message):
"""Print message to stderr."""
def to_stderr(self, message):
"""Print message to stderr."""
- assert
type(message) == type(''
)
+ assert
isinstance(message, compat_str
)
if self.params.get('logger'):
self.params['logger'].error(message)
else:
if self.params.get('logger'):
self.params['logger'].error(message)
else:
@@
-849,7
+849,7
@@
class YoutubeDL(object):
# Keep for backwards compatibility
info_dict['stitle'] = info_dict['title']
# Keep for backwards compatibility
info_dict['stitle'] = info_dict['title']
- if
not 'format'
in info_dict:
+ if
'format' not
in info_dict:
info_dict['format'] = info_dict['ext']
reason = self._match_entry(info_dict)
info_dict['format'] = info_dict['ext']
reason = self._match_entry(info_dict)