projects
/
youtube-dl
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
fd5ff02
)
Don't be too clever
author
Philipp Hagemeister
<phihag@phihag.de>
Wed, 12 Dec 2012 14:00:03 +0000
(15:00 +0100)
committer
Philipp Hagemeister
<phihag@phihag.de>
Wed, 12 Dec 2012 14:00:03 +0000
(15:00 +0100)
test/test_download.py
patch
|
blob
|
history
diff --git
a/test/test_download.py
b/test/test_download.py
index bce0e4fcdc8e6e0595e75fdba90c7e257e5c53fa..114ff178309c72a275c81ddb2cf6cd85efb948ec 100644
(file)
--- a/
test/test_download.py
+++ b/
test/test_download.py
@@
-49,14
+49,13
@@
class TestDownload(unittest.TestCase):
self.tearDown()
def tearDown(self):
self.tearDown()
def tearDown(self):
- for fn in [ test.get('file', False) for test in self.defs ]:
+ for test in self.defs:
+ fn = test['file']
if fn and os.path.exists(fn):
os.remove(fn)
if fn and os.path.exists(fn):
os.remove(fn)
-### Dinamically generate tests
-def generator(test_case):
-
+def make_test_method(test_case):
def test_template(self):
ie = getattr(youtube_dl.InfoExtractors, test_case['name'] + 'IE')
if not ie._WORKING:
def test_template(self):
ie = getattr(youtube_dl.InfoExtractors, test_case['name'] + 'IE')
if not ie._WORKING:
@@
-81,14
+80,13
@@
def generator(test_case):
md5_for_file = _file_md5(test_case['file'])
self.assertEqual(md5_for_file, test_case['md5'])
md5_for_file = _file_md5(test_case['file'])
self.assertEqual(md5_for_file, test_case['md5'])
+ # TODO proper skipping annotations
return test_template
return test_template
-### And add them to TestDownload
for test_case in defs:
for test_case in defs:
- test_method =
generator
(test_case)
+ test_method =
make_test_method
(test_case)
test_method.__name__ = "test_{0}".format(test_case["name"])
setattr(TestDownload, test_method.__name__, test_method)
test_method.__name__ = "test_{0}".format(test_case["name"])
setattr(TestDownload, test_method.__name__, test_method)
- del test_method
if __name__ == '__main__':
if __name__ == '__main__':