From: Yuntai Kyong Date: Mon, 5 Nov 2018 12:10:17 +0000 (+0900) Subject: fail channel when BADONION is not set. X-Git-Tag: v0.0.12~276^2 X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=05b580e10b23e70c9f28ec018b654c20dfc4c7e3;p=rust-lightning fail channel when BADONION is not set. --- diff --git a/src/ln/channelmanager.rs b/src/ln/channelmanager.rs index 1141d7dfb..af2af9d80 100644 --- a/src/ln/channelmanager.rs +++ b/src/ln/channelmanager.rs @@ -2194,8 +2194,8 @@ impl ChannelManager { //TODO: here and below MsgHandleErrInternal, #153 case return Err(MsgHandleErrInternal::send_err_msg_no_close("Got a message for a channel from the wrong node!", msg.channel_id)); } - if (msg.failure_code & 0x8000) != 0 { - return Err(MsgHandleErrInternal::send_err_msg_close_chan("Got update_fail_malformed_htlc with BADONION set", msg.channel_id)); + if (msg.failure_code & 0x8000) == 0 { + return Err(MsgHandleErrInternal::send_err_msg_close_chan("Got update_fail_malformed_htlc with BADONION not set", msg.channel_id)); } chan.update_fail_malformed_htlc(&msg, HTLCFailReason::Reason { failure_code: msg.failure_code, data: Vec::new() }) .map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, msg.channel_id))?;