From: alimirjamali Date: Mon, 16 Dec 2013 16:44:28 +0000 (+0330) Subject: Incorrect variable is used to check whether thumbnail exists X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=0a9ce268bad2d2bfaba1498e3843784a2f14e856;p=youtube-dl Incorrect variable is used to check whether thumbnail exists Dear @phihag I believe in line 848, the correct variable to check is 'thumb_filename' rather than 'infofn' Kindly advise Mit freundlichen Gruessen Ali --- diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py index 2fa34ebc9..b1f87415b 100644 --- a/youtube_dl/YoutubeDL.py +++ b/youtube_dl/YoutubeDL.py @@ -845,7 +845,7 @@ class YoutubeDL(object): if info_dict.get('thumbnail') is not None: thumb_format = determine_ext(info_dict['thumbnail'], u'jpg') thumb_filename = os.path.splitext(filename)[0] + u'.' + thumb_format - if self.params.get('nooverwrites', False) and os.path.exists(encodeFilename(infofn)): + if self.params.get('nooverwrites', False) and os.path.exists(encodeFilename(thumb_filename)): self.to_screen(u'[%s] %s: Thumbnail is already present' % (info_dict['extractor'], info_dict['id'])) else: