From: Wilmer Paulino <wilmer@wilmerpaulino.com>
Date: Fri, 8 Dec 2023 18:21:29 +0000 (-0800)
Subject: Simplify ChannelState checks
X-Git-Tag: v0.0.123-beta~90^2~4
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=12f06c3fff74e181a0f2290121943d1693d32780;p=rust-lightning

Simplify ChannelState checks
---

diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
index 5cbc72994..e77f502d1 100644
--- a/lightning/src/ln/channel.rs
+++ b/lightning/src/ln/channel.rs
@@ -2389,11 +2389,7 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider  {
 			// funding transaction, don't return a funding txo (which prevents providing the
 			// monitor update to the user, even if we return one).
 			// See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
-			let generate_monitor_update = match self.channel_state {
-				ChannelState::AwaitingChannelReady(_)|ChannelState::ChannelReady(_)|ChannelState::ShutdownComplete => true,
-				_ => false,
-			};
-			if generate_monitor_update {
+			if !self.channel_state.is_pre_funded_state() {
 				self.latest_monitor_update_id = CLOSED_CHANNEL_UPDATE_ID;
 				Some((self.get_counterparty_node_id(), funding_txo, ChannelMonitorUpdate {
 					update_id: self.latest_monitor_update_id,